00:02 fdobridge: <g​fxstrand> Ugh... Let me try that again
00:07 fdobridge: <g​fxstrand> Okay, fixed.
00:08 fdobridge: <r​edsheep> Much better, thanks
00:15 fdobridge: <M​isyl with Max-Q Design> ah, shouldn't be a problem for Gamescope then
00:15 fdobridge: <M​isyl with Max-Q Design> no EGL involved there
00:22 fdobridge: <r​edsheep> Had to use Sid's PKGBUILD since mine makes it a real pain to change where I get the source, but I have finally got a viable build in progress. I am going to shoot straight for the moon and put `export NOUVEAU_USE_ZINK=1` in my /etc/environment right away and hope for the best
00:25 fdobridge: <r​edsheep> Oh something else I am hoping for, until now not only has it always been 5 fps to run a zink session, but wayland has always resulted in a crashed session. I will update soon, rebooting now to test
00:40 fdobridge: <r​edsheep> I can confirm that resulted in a stable and wonderfully performant zink plasma-x11 session
00:41 fdobridge: <r​edsheep> Hmmm plasma Wayland still explodes.
00:45 fdobridge: <r​edsheep> It messes up switching to a virtual terminal and my screens go black so it's kernel or maybe even the hardware that is giving up. I can also tell from my external CPU temp read out that it's getting stuck spinning on something pretty hard
00:46 fdobridge: <r​edsheep> I'll see if I can recover kernel logs
00:53 fdobridge: <r​edsheep> Gamescope is working on the x11 session, still working on logs
00:59 fdobridge: <r​edsheep> Looks like I got a load of spam like this:
00:59 fdobridge: <r​edsheep> ```May 08 18:43:56 jared-linux kwin_wayland_wrapper[1211]: MESA: error: zink: display server doesn't support DRI3 modifiers and driver can't handle INVALID<->LINEAR!
00:59 fdobridge: <r​edsheep> May 08 18:43:56 jared-linux kwin_wayland[1211]: kwin_scene_opengl: Error creating EGLImageKHR: "EGL_BAD_ALLOC"
00:59 fdobridge: <r​edsheep> May 08 18:43:56 jared-linux kwin_wayland[1211]: kwin_wayland_drm: Failed to find a working setup for new outputs!```
01:01 fdobridge: <r​edsheep> Here's the only other relevant section
01:01 fdobridge: <r​edsheep> ```May 08 18:43:57 jared-linux kcminit_startup[1216]: qt.qpa.wayland: Creating a fake screen in order for Qt not to crash
01:01 fdobridge: <r​edsheep> May 08 18:43:57 jared-linux ksplashqml[1214]: qt.qpa.wayland: Creating a fake screen in order for Qt not to crash
01:01 fdobridge: <r​edsheep> May 08 18:43:57 jared-linux kcminit_startup[1216]: Initializing "/usr/lib/qt6/plugins/plasma/kcms/systemsettings/kcm_mouse.so"
01:01 fdobridge: <r​edsheep> May 08 18:43:57 jared-linux kcminit_startup[1216]: Initializing "/usr/lib/qt6/plugins/plasma/kcms/systemsettings/kcm_style.so"
01:01 fdobridge: <r​edsheep> May 08 18:43:57 jared-linux kernel: Module nvidia is blacklisted
01:01 fdobridge: <r​edsheep> May 08 18:43:57 jared-linux ksplashqml[1214]: mesa: Kopper interface not found!
01:01 fdobridge: <r​edsheep> May 08 18:43:57 jared-linux ksplashqml[1214]: Ensure the versions of libEGL_mesa and libGLX_mesa built with this version of Zink are
01:01 fdobridge: <r​edsheep> May 08 18:43:57 jared-linux ksplashqml[1214]: in your library path!
01:01 fdobridge: <r​edsheep> May 08 18:43:57 jared-linux ksplashqml[1214]: libEGL warning: egl: failed to create dri2 screen```
01:09 fdobridge: <r​edsheep> @gfxstrand ^ there are your results. In summary, gamescope works, plasma x11 works, plasma wayland blows up an dnothing notable ends up in the equivalent of dmesg, but plasma complains plenty about modifiers. Maybe a plasma bug, but hard to be sure until somebody has tested mutter. The performance of the session itself seems to be very slightly better, which gets games running a few percent faster, but nothing crazy huge.
01:09 fdobridge: <S​id> I've got a test in 3h, but after that I can try out both i3wm and sway on NVK+zink
01:09 fdobridge: <r​edsheep> To be clear I mean better than nvc0 session performance
01:09 fdobridge: <S​id> and maybe sway vulkan renderer on nvk natively
01:10 fdobridge: <r​edsheep> The session perf vs zink before is at least 20x improvement
01:11 fdobridge: <g​fxstrand> That's an interesting Zink message. I'll look into it tomorrow.
01:15 fdobridge: <g​fxstrand> @zmike. What's up with `can_do_invalid_linear_modifier_swap`?
01:16 fdobridge: <g​fxstrand> We might be able to set that for NVK
01:17 fdobridge: <g​fxstrand> @redsheep Try it with the patch I just pushed.
01:17 fdobridge: <g​fxstrand> @zmike. can explain to us in the morning what that does. 😅
01:20 fdobridge: <r​edsheep> Alright cooking up some fresh mesa builds now
01:22 fdobridge: <z​mike.> basically if the driver can do implicit modifiers successfully
01:23 fdobridge: <r​edsheep> That resulted in a really crazy looking corrupt screen for a few moments before backing out to sddm
01:23 fdobridge: <z​mike.> i.e., the driver gets INVALID and magically selecting a modifier works
01:23 fdobridge: <r​edsheep> I'll take it over having to reboot but not ideal
01:32 fdobridge: <r​edsheep> The attempted plasma wayland session didn't kick out anything in dmesg
01:34 fdobridge: <r​edsheep> I am no expert of course but the corruption looks a lot like there's a tiled vs linear mismatch
01:35 fdobridge: <r​edsheep> It's visually similar to the previously broken gamescope screenshots
01:50 fdobridge: <r​edsheep> Hmm the old zink corruption on discord server icons is still here. Not sure if anyone has replicated with radv to see if that was nvk specific
01:50 fdobridge: <r​edsheep> https://cdn.discordapp.com/attachments/1034184951790305330/1237944662673723504/image.png?ex=663d7d4f&is=663c2bcf&hm=887da0d23d8bd48ef1c4948995b90c285c819ed80183d98921c8d6ddcce7fc6c&
01:50 fdobridge: <S​id> oh yeah, zink+nvk also has massive artifacting if MSAA is enabled
01:50 fdobridge: <S​id> which didn't exist on nvc0
01:51 fdobridge: <g​fxstrand> Ah. I might be able to make that work (ish)
01:52 fdobridge: <S​id> granted, I was running 8x MSAA on both cases.. I should be able to try 2x MSAA as well
01:57 fdobridge: <r​edsheep> Yeah it's not like all the bugs magically went away, this session now gets heaven and valley flashing blue by default, and my Konsole seems to be doing a little bit of a rave party from time to time, flashing between the last two frames.
01:58 fdobridge: <r​edsheep> Probably best not to merge something that defaults zink until some of that is ironed out, but none of that is new to this branch
01:58 fdobridge: <S​id> alternatively, call it party mode and say it's always on to celebrate the release of the driver /j
01:58 fdobridge: <S​id> :SCrainBowDance:
02:01 fdobridge: <z​mike.> really it needs a vk extension to allow querying the buffer to select the modifier, but that's SI
02:03 fdobridge: <g​fxstrand> I think plumbing modifiers is the better easy
02:03 fdobridge: <g​fxstrand> I think plumbing modifiers is the better way (edited)
02:09 fdobridge: <z​mike.> you can't really "plumb" modifiers for this
02:09 fdobridge: <z​mike.> it's implicit
02:11 fdobridge: <g​fxstrand> But why is it implicit?
02:11 fdobridge: <g​fxstrand> Or is this for ancient X11 nonsense?
02:12 fdobridge: <z​mike.> this is the first dmabuf extension
02:12 fdobridge: <z​mike.> the one that doesn't allow explicit modifier selection
02:12 fdobridge: <z​mike.> so the api says "gimme a dmabuf" and the driver is supposed to export a dmabuf with $modifier that the importer can then query and select the right modifier off
02:14 fdobridge: <g​fxstrand> I mean, if you just want INVALID to mean dealers choice, I can do that.
02:15 fdobridge: <z​mike.> it's not that either?
02:15 fdobridge: <g​fxstrand> But I thought old school dma-buf is more magic
02:15 fdobridge: <z​mike.> it is
02:15 fdobridge: <z​mike.> that's what I'm describing
02:15 fdobridge: <z​mike.> the driver uses a kernel interface to query the buffer and detect which modifier to use for import
02:15 fdobridge: <g​fxstrand> Yeah, I can do the more magic, too. It's not great but whatever.
02:15 fdobridge: <z​mike.> with INVALID, zink just selects the first valid modifier and yolos it on both export and import
02:16 fdobridge: <z​mike.> so if both ends are always zink+nvk then this should be fine in theory
02:16 fdobridge: <g​fxstrand> Right
02:16 fdobridge: <z​mike.> but then if you try to do something like multiple gpus probably you're screwed
02:16 fdobridge: <z​mike.> because it might choose a different modifier for different gpu gen
02:16 fdobridge: <g​fxstrand> Multiple GPUs are screwed without modifiers anyway
02:17 fdobridge: <z​mike.> oh tremendous
02:17 fdobridge: <z​mike.> then it might work out
02:17 fdobridge: <z​mike.> conceptually anyway
02:18 fdobridge: <r​edsheep> I am not using multiple gpus
02:19 fdobridge: <r​edsheep> Unless something is broken with NOUVEAU_USE_ZINK=1 absolutely everything on my system should be nvk and zink
02:19 fdobridge: <z​mike.> you're holding it wrong probably
02:21 fdobridge: <r​edsheep> Let me try MESA_LOADER_DRIVER_OVERRIDE=zink instead
02:23 fdobridge: <r​edsheep> Yeah no change, it flashes a corrupt desktop a few times and then gives up and goes back to sddm
02:24 fdobridge: <g​fxstrand> Are there any tests for this back door?
02:28 fdobridge: <r​edsheep> I don't think I am holding it wrong, glxinfo and vulkaninfo all show the right commit
02:30 fdobridge: <r​edsheep> I wonder how hard it would be to patch kwin to not use the implicit selection. I can't imagine it would be huge, but it's probably pointless since that ideally should be able to work if people are using it
02:31 fdobridge: <g​fxstrand> It may not be possible if there's enough X11 in the way
02:31 fdobridge: <g​fxstrand> Or maybe it needs modifiers? 🤷🏻‍♀️
02:32 fdobridge: <r​edsheep> Not certain which message you are responding to, but plasma x11 is certainly helped by working modifiers considering it fixed the performance
02:33 fdobridge: <z​mike.> the test is to run all the piglit dmabuf tests
02:34 fdobridge: <z​mike.> if they pass you're probably good
02:34 fdobridge: <g​fxstrand> Okay. That's probably doable
02:34 fdobridge: <z​mike.> really nothing should use this path anymore
02:35 fdobridge: <z​mike.> dri3 exists with explicit modifier selection
02:35 fdobridge: <z​mike.> if you're using a modern piece of software and you see that error, file a ticket with the app
02:45 fdobridge: <r​edsheep> I tried to find something about the state of this in kwin wayland, and I found this issue: https://invent.kde.org/plasma/kwin/-/issues/139
02:46 fdobridge: <r​edsheep> So with 6.2 they seem to be planning a split that would include not even using dri3, let alone dri2, if I am reading this right.
02:47 fdobridge: <r​edsheep> Not sure if that interpretation even makes sense, there was very little mention of that part
02:56 fdobridge: <r​edsheep> Oh there's also this https://invent.kde.org/plasma/kwin/-/issues/92
03:01 fdobridge: <z​mike.> yep that'll do it
03:02 fdobridge: <r​edsheep> They claim all that code is already merged though, long ago
06:11 fdobridge: <a​irlied> haven't tested it yet, but did a f40/rawhide v24.1-rc3 build with modifiers and nvk/zink defaulted on for turing+ https://copr.fedorainfracloud.org/coprs/airlied/mesa-nvk/build/7428248/
06:23 fdobridge: <S​id> the things I do for testing
06:23 fdobridge: <S​id> `[sidpr@constructor ~]$ sudo pacman -S plasma gnome`
06:24 fdobridge: <S​id> make that
06:24 fdobridge: <S​id> plasma-desktop and gnome-shell
06:24 fdobridge: <S​id> because I really want minimal environments I can test in and uninstall .-.
06:25 fdobridge: <S​id> :wolfFIRE:
08:06 fdobridge: <S​id> I tried to start a session on ziNVK without NVK installed
08:06 fdobridge: <S​id> < so smart
08:06 fdobridge: <S​id> :clueless:
08:32 fdobridge: <S​id> okay, getting any kind of logs out of this is gonna be painful, I'll do it when I'm in the mood to screw around my systen
09:00 karolherbst: Lyude: okay, apparently it's a thing that some users get a broken edid: https://gitlab.freedesktop.org/drm/nouveau/-/issues/356
09:45 fdobridge: <m​ohamexiety> welp, ~ 10 hours of memtest later, no errors. so RAM should be fine. CPU is also fine at both sustained heavy and light workloads, so I wonder if that ICE popped up due to improper LLC default from the motherboard (motherboard essentially undervolting the CPU). compiler work is transient heavy so it'd make sense to expose something like this
09:45 fdobridge: <m​ohamexiety> this is reassuring at least
09:46 fdobridge: <k​arolherbst🐧🦀> @gfxstrand using any static inline functions on the rust side? I'm going to cleanup and merge https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25265 soonish, so I'll bump to meson 1.4 and bindgen 0.65
09:48 fdobridge: <m​ohamexiety> oo, static inline now being generateable is really nice and convenient
09:49 fdobridge: <k​arolherbst🐧🦀> yeah
09:49 fdobridge: <k​arolherbst🐧🦀> it's an "experimental" feature in bindgen but they don't seem to break the interface so far
09:52 fdobridge: <k​arolherbst🐧🦀> but like.. it's literally doing the same I've done more or less
09:52 fdobridge: <k​arolherbst🐧🦀> just being smarter about it
09:53 fdobridge: <k​arolherbst🐧🦀> they use `link_name` in the generated rust file
09:53 fdobridge: <k​arolherbst🐧🦀> and append `__extern`
09:54 fdobridge: <k​arolherbst🐧🦀> but anyway, the nice meson integration makes it really nice to use 🙂
10:11 fdobridge: <m​arysaka> oh that's awesome
12:05 fdobridge: <g​fxstrand> We're not using that right now, no. The like 3 things NIL needed I just reimplemented. For NAK and NIR, I almost always wanted something different and more rusty anyway.
12:28 fdobridge: <k​arolherbst🐧🦀> yeah, entirely fair
12:30 fdobridge: <g​fxstrand> A lot of the NIR ones exist so we can assert things. The Rust wrappers I made return `Option<_>` instead.
12:36 fdobridge: <k​arolherbst🐧🦀> yeah.. fair
12:37 fdobridge: <k​arolherbst🐧🦀> I just need a lot of those `glsl_type` things
12:37 fdobridge: <k​arolherbst🐧🦀> though... could probably also just inline the code
12:38 fdobridge: <k​arolherbst🐧🦀> but I kinda want to stick with the interface and not make it painful to rework things later
12:55 fdobridge: <g​fxstrand> Yeah, probably for the best there.
12:56 fdobridge: <g​fxstrand> The one that really annoyed me was `drm_fourcc()` which is all function-like macros. 🤦🏻‍♀️
12:57 fdobridge: <g​fxstrand> In the end, I said "this is all fixed in stone. I can just reimplement."
12:57 fdobridge: <k​arolherbst🐧🦀> yeah
13:02 fdobridge: <g​fxstrand> IDK what we'll do about ioctls when the time comes. Those I want to pull from headers.
13:02 fdobridge: <k​arolherbst🐧🦀> use the `libc` crate?
13:02 fdobridge: <g​fxstrand> I may have to write my own parser of some sort.
13:03 fdobridge: <g​fxstrand> Honestly, you can probably run the C preprocessor on rust code... Oh, this is cursed...
13:03 fdobridge: <k​arolherbst🐧🦀> heh
13:03 fdobridge: <k​arolherbst🐧🦀> I used php once as a preprocessor in C :ferrisUpsideDown:
13:05 fdobridge: <g​fxstrand> So, yeah. You have a rust file which has a `#include` at the top and a bunch of `const FOO: u32 = MACRO;` and then run cpp on it. 🤔 You'd have to postprocess somehow up strip out any structs it defines but that could be done.
13:05 fdobridge: <g​fxstrand> Thanks, I hate it.
13:05 fdobridge: <k​arolherbst🐧🦀> that exists already I think
13:07 fdobridge: <k​arolherbst🐧🦀> @gfxstrand https://github.com/zdimension/embed-c
13:08 fdobridge: <k​arolherbst🐧🦀> `C2Rust` is just cursed
13:08 bencoh: o.O
13:23 fdobridge: <m​ohamexiety> huh I didnt know this was possible o_o
13:52 fdobridge: <b​abblebones> Neat, also spooky
14:02 fdobridge: <g​fxstrand> It's very unclear what that would actually look like when you need to define constants, invoke macros, etc.
14:37 fdobridge: <k​arolherbst🐧🦀> people parse SQL queries in proc macros and make sure it's all valid
16:03 Lyude: karolherbst: thank you for reminding me - I'll tty taking a look at that asap
16:13 fdobridge: <g​fxstrand> Just installed on my desktop and it's rebooting now. Soon we'll see just how much of a mess this is. 😅
16:16 fdobridge: <r​edsheep> Do you use the discord app? I'm curious if you will see the icon corruption
16:18 fdobridge: <r​edsheep> Provided mutter is using explicit modifiers I would expect it just to work, my x11 session was solid
16:18 fdobridge: <r​edsheep> Aside from the usual zink bugs that you can replicate on a normal session
16:22 fdobridge: <g​fxstrand> No, I just have discord in FF
16:22 fdobridge: <g​fxstrand> And I'm not running any of that on my laptop where I do actual work.
16:23 fdobridge: <r​edsheep> Fair, though you could install the flatpak of you want to avoid infesting your system with gamerness
16:23 fdobridge: <g​fxstrand> Well, this is entertaining... I'm getting X11 and not Wayland in my session now. 😬
16:23 fdobridge: <S​id> and then there's me, running code to test on my only machine e-e
16:24 fdobridge: <S​id> like, filesystem code at that
16:24 fdobridge: <g​fxstrand> Oh, that's probably because that copr has 24.1-rc3 and not my branch
16:25 fdobridge: <g​fxstrand> Still, should have reasonable Zink
16:25 fdobridge: <r​edsheep> Maybe it's not a plasma issue causing Wayland to fail then? And yeah before and after that branch I got the same result with Wayland
16:26 fdobridge: <r​edsheep> The only think that changes behavior was your later patch for invalid
16:30 fdobridge: <r​edsheep> Best as I could figure after a few more hours of digging into kwin I think we're somehow ending up in a fallback we should not be. Kwin is not supposed to use implicit modifiers
16:38 soreau: gfxstrand: does 'reasonable zink' mean doesn't require modifiers?
16:38 HdkR: t/15
16:40 fdobridge: <g​fxstrand> I mean it's got lots of bugs fixed
16:48 fdobridge: <z​mike.> an average day in zink
17:18 fdobridge: <g​fxstrand> Oh, good... We have a use-after-free in Zink when it's used for XWayland.
17:19 fdobridge: <z​mike.> @gfxstrand I'm testing my new parallel conformance script and I think it might actually work
17:21 fdobridge: <z​mike.> it's for sure slower than my deqp-runner splitter script, but it does theoretically generate a legitimate output that can be used for a submission package
17:22 fdobridge: <g​fxstrand> More specifically, Zink is calling `GetMemoryFdKHR` on destroyed memory objects. Either that or we've got a crazy stack smash going on. Use-after-free seems more likely.
17:22 fdobridge: <z​mike.> 🤔
17:23 fdobridge: <z​mike.> that seems like a problem in the frontend if it's happening
17:23 fdobridge: <g​fxstrand> Yeah, it feels really unlikely
17:23 fdobridge: <g​fxstrand> Refcounting bug, maybe?
17:23 fdobridge: <z​mike.> also feels very unlikely
17:24 fdobridge: <z​mike.> I've never seen it though, so who knows
17:41 fdobridge: <z​mike.> https://gist.github.com/zmike/e8eec8fdb6eb1d264828b2affede993b
17:44 fdobridge: <z​mike.> this should generate all the same files you'd get from using cts-runner normally
17:44 fdobridge: <z​mike.> and the resulting package should pass verification
17:44 fdobridge: <z​mike.> ...I think
17:47 fdobridge: <z​mike.> cc @airlied if you want to test for llvmpipe^
17:47 fdobridge: <z​mike.> looks like it'll take about an hour on a 32 core machine on radv
17:51 fdobridge: <g​fxstrand> Is that going to be an officially valid way to run CTS?
17:52 fdobridge: <z​mike.> yes, the WG agreed on it yesterday
17:52 fdobridge: <z​mike.> I just have to update the official documentation
17:53 fdobridge: <z​mike.> the idea is that as long as you run the commands output by `cts-runner` directly then your submission is valid regardless of how many processes/machines you split it across
17:53 fdobridge: <g​fxstrand> cool
17:53 fdobridge: <z​mike.> but sharding those caselists is not currently permitted
17:54 fdobridge: <z​mike.> ooof radv fails so many of these
17:58 fdobridge: <z​mike.> testing on nvk now to hopefully get something that can actually pass for verification...
17:59 fdobridge: <g​fxstrand> The plot thickens! `PRIME_HANDLE_TO_FD` returns `-EBADF` which should only happen if the DRM file has been closed.
17:59 fdobridge: <z​mike.> https://media.giphy.com/media/CaiVJuZGvR8HK/giphy.gif
18:02 fdobridge: <g​fxstrand> It's happening in `zink_screen_export_dmabuf_semaphore`
18:03 fdobridge: <z​mike.> sounds bad?
18:03 fdobridge: <z​mike.> but also it should be impossible for a dead resource to reach that point
18:04 fdobridge: <g​fxstrand> There's a lot of load-bearing "should"s going on. 😅
18:04 fdobridge: <z​mike.> I mean the function would explode elsewhere if that weren't true
18:05 fdobridge: <z​mike.> argh I made a new build dir and I'm getting rust errors again
18:05 fdobridge: <z​mike.> I hate build systems
18:05 fdobridge: <g​fxstrand> It's coming from `zink_resource_image_barrier()`
18:06 fdobridge: <z​mike.> yes
18:06 fdobridge: <g​fxstrand> I wish I knew how to attach a debugger to this disaster
18:06 fdobridge: <z​mike.> file:line always works
18:07 fdobridge: <!​DodoNVK (she) 🇱🇹> This should help then: https://www.youtube.com/watch?v=7_DExGdUw7w
18:11 fdobridge: <z​mike.> hm well the runner works but nvk isn't passing here
18:11 fdobridge: <z​mike.> GOOD ENOUGH
18:11 fdobridge: <S​id> 🚢
18:11 fdobridge: <S​id> ship it
18:21 fdobridge: <a​irlied> The copr should have debug info bits I think, or do you mean gnome shell?
18:22 fdobridge: <a​irlied> I have a hacky mutter debug, go to rl3. Login to a vt, run screen, run gdb --args mutter --display-server --wayland
18:23 fdobridge: <a​irlied> Then connect to the screen and use it
18:25 fdobridge: <g​fxstrand> Yeah, we've definitely got a use-after-free going on. I've got GDB broken at the segfault.
18:31 fdobridge: <z​mike.> WOW
18:31 fdobridge: <z​mike.> idk if you've tried out that sparse cts split CL recently
18:31 fdobridge: <z​mike.> but I can do an all-versions GL run in deqp-runner now in under 30s
18:31 fdobridge: <z​mike.> unreal
18:31 fdobridge: <z​mike.> this has to be a mistake...
18:33 fdobridge: <z​mike.> ok yeah it's a mistake
18:33 fdobridge: <z​mike.> damn
18:39 fdobridge: <z​mike.> under 2:30 now though, which is a definite improvement
18:46 fdobridge: <g​fxstrand> Ugh... All the Zink reference counts look sane but my nvk_device_memory is definitely trash
18:48 fdobridge: <!​DodoNVK (she) 🇱🇹> ~~Winter should double-check that though just in case~~
18:54 fdobridge: <z​mike.> @gfxstrand what does the backtrace look like
19:21 fdobridge: <g​fxstrand> https://cdn.discordapp.com/attachments/1034184951790305330/1238209231631683594/bt_full?ex=663e73b5&is=663d2235&hm=b4f770bf102220ccb395b62d02bfce998bdea3858a3334c615abc1046e95c7b5&
19:21 fdobridge: <z​mike.> huh
19:21 fdobridge: <z​mike.> normal enough
19:28 fdobridge: <g​fxstrand> Yeah, there's nothing obvious in there
19:29 fdobridge: <g​fxstrand> But my BO is definitely trashed
19:29 fdobridge: <g​fxstrand> I'm gonna memset some stuff to zero on destroy...
19:31 fdobridge: <g​fxstrand> I guess it's theoretically possible I have a BO refcount bug in nouveau.
19:31 fdobridge: <g​fxstrand> That'd be a bit crazy
19:31 fdobridge: <g​fxstrand> But totally possible with import/export
19:32 fdobridge: <g​fxstrand> Damn! I do...
19:36 fdobridge: <g​fxstrand> That's my 4th Zink-found NVK bug, I think.
19:36 fdobridge: <z​mike.> dear diary
19:36 fdobridge: <z​mike.> today was a good day.
19:36 fdobridge: <g​fxstrand> But who's counting? 😉
19:43 fdobridge: <g​fxstrand> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28843/diffs?commit_id=b3c133ab4541e4bb47a2c4a8da4e27f06d9fef79 for those following along at home.
19:44 fdobridge: <g​fxstrand> Yeah, with that Xwayland feels pretty solid. 🎉
19:47 fdobridge: <a​irlied> I will rebuild the copr in a bit
19:50 fdobridge: <a​irlied> I feel like I'd want to ship 24.1 with zink and modifiers enabled if I can in F41 at least, not sure about f40
19:50 fdobridge: <a​irlied> But F41 will have 24.2 anyways
19:52 fdobridge: <g​fxstrand> Yeah.
19:52 fdobridge: <g​fxstrand> I'm thinking of back-porting the modifiers branch to 24.1
19:53 fdobridge: <g​fxstrand> But that means we need to get it reveiwed and the kernel bits merged ASAP
20:08 fdobridge: <g​fxstrand> I'm going to re-try gles with that patch. I bet I'll pass the EGL tests now. 😅
20:14 fdobridge: <g​fxstrand> Nope!
20:18 fdobridge: <a​irlied> copr is rebuilding onw
20:19 fdobridge: <g​fxstrand> Cool
20:20 fdobridge: <g​fxstrand> Building from my branch? Because I don't think the old one did.
20:21 fdobridge: <a​irlied> not from the branch, from that patch on top of 24.1
20:21 fdobridge: <a​irlied> well the whole MR diff on top of 24.1
20:21 fdobridge: <g​fxstrand> I'm going to try running them with only one GPU in the machine. Multi-GPU seems to be problematic and that may be why EGL is falling over.
20:22 fdobridge: <g​fxstrand> @mohamexiety I left a comment on your kernel patch. Please fix and re-send and I'll RB it.
20:28 fdobridge: <g​fxstrand> @mohamexiety Also, please update the MR link to the original one: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24795
20:28 fdobridge: <m​ohamexiety> woops, didn't see that one, sorry. on it
20:28 fdobridge: <m​ohamexiety> got it
20:29 fdobridge: <g​fxstrand> No particular reason but I needed to close one and figured it was better to use the original now that I've taken it back over.
20:29 fdobridge: <g​fxstrand> Thanks a bunch for your work rebasing!
20:34 fdobridge: <!​DodoNVK (she) 🇱🇹> How is VK_EXT_queue_family_foreign related to the modifier work?
20:40 fdobridge: <g​fxstrand> Yeah, it's basically part of the modifiers extension
20:42 fdobridge: <d​wlsalmeida> @karolherbst Hey, do you mind if we get back to this? Not sure I get this still, is 1inc only a thing for array methods?
20:42 fdobridge: <d​wlsalmeida> @marysaka Mary do you know something about this? Since you wrote the dump tool I assume you can help?
20:43 fdobridge: <d​wlsalmeida> Note that I am running the whole CTS with a breakpoint here:
20:43 fdobridge: <d​wlsalmeida>
20:43 fdobridge: <d​wlsalmeida> else if (is_1inc)
20:43 fdobridge: <d​wlsalmeida> distance = MIN2(1, distance); <---------
20:43 fdobridge: <d​wlsalmeida>
20:43 fdobridge: <d​wlsalmeida> Apparently this line is never hit
20:44 fdobridge: <d​wlsalmeida> I wonder what exactly is being incremented then, if distance==0 always
20:45 fdobridge: <m​ohamexiety> done for both
20:46 fdobridge: <m​ohamexiety> and yeah sorry about that. I basically couldn't do the rebase the "traditional" way so I just branched from `main` and cherry-picked/rewrote commits manually but then didn't know how to push it back to the original branch :blobcatnotlikethis:
20:49 fdobridge: <g​fxstrand> That's okay. You did fine.
20:49 fdobridge: <g​fxstrand> Thanks!
20:50 fdobridge: <g​fxstrand> @airlied, @karolherbst Can I get one or both of you to RB https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24795 ? Ideally both given how dicy all this is. I need a review for UAPI reasons but I'd also like some sign-off on the plan laid out at the top of the MR so it's not just me who gets blamed with the bugs. 😅
21:01 fdobridge: <g​fxstrand> @airlied We've basically got the week-end if we want to push this in to rc4. I think we can probably do that.
21:06 fdobridge: <g​fxstrand> IDK how much I'll have to back-port, though.
21:06 fdobridge: <g​fxstrand> Probably not much. The first RC was only cut a few weeks ago and I've been traveling.
21:07 fdobridge: <d​wlsalmeida> @karolherbst ah, I think I get this, so here:
21:07 fdobridge: <d​wlsalmeida>
21:07 fdobridge: <d​wlsalmeida> ```
21:07 fdobridge: <d​wlsalmeida> P_1INC(p, NV9097, CALL_MME_MACRO(NVK_MME_DRAW));
21:07 fdobridge: <d​wlsalmeida> P_INLINE_DATA(p, begin);
21:07 fdobridge: <d​wlsalmeida> P_INLINE_DATA(p, 0 /* draw_idx */);
21:07 fdobridge: <d​wlsalmeida> P_INLINE_DATA(p, vertexCount);
21:07 fdobridge: <d​wlsalmeida> P_INLINE_DATA(p, instanceCount);
21:07 fdobridge: <d​wlsalmeida> P_INLINE_DATA(p, firstVertex);
21:07 fdobridge: <d​wlsalmeida> P_INLINE_DATA(p, firstInstance);
21:07 fdobridge: <d​wlsalmeida> ```
21:07 fdobridge: <d​wlsalmeida>
21:07 fdobridge: <d​wlsalmeida> First one is CALL_MME_MACRO, then all others count against the subsequent one, CALL_MME_DATA, right?
21:09 fdobridge: <g​fxstrand> Sort-of? There are some methods which take inline data. `CALL_MME_MACRO()` is one example. The data that follows on the command stream isn't so much additional methods as just data.
21:11 fdobridge: <g​fxstrand> There's a few others such as `LOAD_CONSTANT_BUFFER` and the various inline DMAs that work similarly.
21:11 fdobridge: <g​fxstrand> That's why you're seeing a bunch of `CALL_MME_DATA(2)`
21:11 fdobridge: <g​fxstrand> @dwlsalmeida ^^
21:13 fdobridge: <a​irlied> the MR diff applies pretty cleanly to rc3
21:17 fdobridge: <d​wlsalmeida> @gfxstrand my point being, given what Karol said:
21:17 fdobridge: <d​wlsalmeida>
21:17 fdobridge: <d​wlsalmeida> > the inc just means how often the "method" gets increased, like 1inc means that the first value is against the initial mehtod, the second and subsequent against the next (useful for those INLINE_DATA methods, where the first is e.g. the size and the next the data), ninc just increases with each value and 0inc never
21:17 fdobridge: <d​wlsalmeida> >
21:17 fdobridge: <d​wlsalmeida>
21:17 fdobridge: <d​wlsalmeida> Then, this align with the example shown, because the dump first shows CALL_MME_MACRO, then CALL_MME_DATA (which is right below it in the header)
21:20 fdobridge: <g​fxstrand> Yes
21:21 fdobridge: <g​fxstrand> So 1inc means `CALL_MME_MACRO` and then as many `CALL_MME_DATA` as needed.
21:21 fdobridge: <g​fxstrand> 0inc, on the other hand, means the first one repeated as many times as needed.
21:23 fdobridge: <g​fxstrand> I don't think we're using 0INC anywhere right now
21:24 fdobridge: <g​fxstrand> I'll be using it all over everywhere soon when I start doing more inline constant data
21:29 fdobridge: <g​fxstrand> Wow, it's been a while since I ran piglit...
21:38 fdobridge: <d​wlsalmeida> @gfxstrand I assume this is done by the HW automatically, right? When you set the bits for 1INC, it derives how many times to call the subsequent method from the `size` variable that was passed in?
21:39 fdobridge: <d​wlsalmeida> seems like it anyways
21:39 fdobridge: <d​wlsalmeida> ok this is finally making a lot of sense lol
21:43 fdobridge: <g​fxstrand> yes
22:41 fdobridge: <g​fxstrand> @zmike. `egl_image_dma_buf*` pass with that hack.
22:47 fdobridge: <z​mike.> nice
22:47 fdobridge: <z​mike.> then I guess nvk is one of the chosen few
22:49 fdobridge: <r​edsheep> @gfxstrand Do you want me to test again with the new changes? Are you expecting that to fix the plasma wayland session, since it fixed gnome for you?
22:50 fdobridge: <g​fxstrand> Please. I think most stuff should be fixed now
22:50 fdobridge: <r​edsheep> Are you planning to try to get 24.1 set to default zink on?
22:50 fdobridge: <g​fxstrand> I'm not sure if I want to go that far but I at least want GameScope to work and I want NVK+Zink to be an option in 24.1.
22:51 fdobridge: <r​edsheep> No new kernel changes, correct? I don't see anything obviously new with your branch
22:51 fdobridge: <s​amantas5855> How does Zink fare compared to Nouveau
22:52 fdobridge: <s​amantas5855> for running a desktop environment like KDE or Gnome
22:52 fdobridge: <r​edsheep> As of just now it should work and in many cases it is more performant, however there are also some zink specific bugs
22:52 fdobridge: <r​edsheep> It's not like the nouveau gl driver is bug free though
22:53 fdobridge: <s​amantas5855> What kind of bugs
22:53 fdobridge: <s​amantas5855> Freezes?
22:53 fdobridge: <s​amantas5855> Graphical glitches?
22:53 fdobridge: <g​fxstrand> Correct
22:54 fdobridge: <r​edsheep> No freezes, just trippy stuff here and there. MSAA related flicker, weird UI corruption in discord, that kind of thing
22:58 fdobridge: <r​edsheep> If there's room tomorrow and this weekend it would be cool to see if it's possible to squeeze some last minute fixes in for those to get zink on more equal footing
22:58 fdobridge: <r​edsheep> I would be happy to provide whatever testing I can, and debugging what I know how to.
22:58 fdobridge: <r​edsheep> I can get captures of the msaa issue in heaven at will
23:00 fdobridge: <r​edsheep> It's entirely possible both issues are the same bug, given UI rendering probably involves msaa
23:11 fdobridge: <r​edsheep> Well, my plasma x11 session segfaulted. This was something I did actually see yesterday too.
23:11 fdobridge: <r​edsheep>
23:11 fdobridge: <r​edsheep> ```[ 667.038196] plasmashe:zfq0[31798]: segfault at 0 ip 00007f217d298c03 sp 00007f215fdff1c0 error 4 in libvulkan_nouveau.so[7f217d25c000+578000] likely on CPU 30 (core 14, socket 0)
23:11 fdobridge: <r​edsheep> [ 667.038205] Code: ff 4d 8b 73 18 49 c1 e5 02 4c 89 85 f0 f7 ff ff 44 8b 8d 30 f8 ff ff 4c 8b 95 18 f8 ff ff 66 0f 1f 84 00 00 00 00 00 44 89 c8 <4d> 8b 04 77 31 ff 48 8d 04 40 48 c1 e0 04 4c 01 d0 4d 85 e4 74 04```
23:13 fdobridge: <r​edsheep> It seems to generally happen shortly after logging in, and then it will be fairly stable again for a few hours
23:15 fdobridge: <r​edsheep> Also something notable, the icon corruption is very rare, unless you put the system under load, in which case it is immediate.
23:18 fdobridge: <r​edsheep> I think the flicker in Konsole is gone now, or at least I can't replicate it anymore
23:21 fdobridge: <r​edsheep> Hmm the plasma Wayland session still isn't quite there, instead of repeating a corrupt screen over and over it's just once, and then stuck on a black screen with a cursor. Nothing in dmesg.
23:26 fdobridge: <r​edsheep> I can confirm gamescope works on NVK+zink plasma x11, as well as nvc0 plasma x11
23:27 fdobridge: <r​edsheep> Unfortunately, plasma Wayland on nvc0 is resulting in a frozen game. Again, no dmesg.
23:28 fdobridge: <r​edsheep> Plasma Wayland on nvc0 also results in a currupt cursor after a few moments. Has anyone been running this configuration to know if this was broken before?
23:32 fdobridge: <r​edsheep> @gfxstrand ^ results. Not sure what else to test, if anything.
23:36 fdobridge: <r​edsheep> IIRC corrupt cursor with nvc0 on the plasma wayland session is not new, but I dismissed it months ago as plasma wayland being buggy. In that time plasma wayland has become pretty stable for almost everything else though.
23:37 fdobridge: <g​fxstrand> Ugh...
23:41 fdobridge: <r​edsheep> How can I help? I am down to do a call to get to the bottom of it more rapidly, or to just leave it and not bother you with it again