00:45 fdobridge: <a​irlied> I think something else we fixed in nil or nvk in the meantime might have fixed it
03:00 fdobridge: <g​fxstrand> Could be
03:03 fdobridge: <g​fxstrand> And... looks like fp16 is busted on Turing.
03:03 fdobridge: <g​fxstrand> It's probably `hfma`. I bet the modifiers encoding is different on Turing. Or maybe it doesn't support a swizzle in src2. 🤷🏻‍♀️
03:15 fdobridge: <g​fxstrand> And here I was happily assuming that Turing and Ampere were basically the same... 😩
06:19 fdobridge: <!​DodoNVK (she) 🇱🇹> What are the fails and crashes?
06:32 fdobridge: <m​arysaka> I thought the same, I guess I will have to put the Turing card on the bench more then :vReiAgony:
09:28 fdobridge: <m​agic_rb.> Can nouveau do wayland somewhat? At least display out on a hybrid graphics laptop. I want to test kde plasma somewhat
09:35 fdobridge: <!​DodoNVK (she) 🇱🇹> That's what I'm using right now
11:32 fdobridge: <s​amantas5855> Won't this just run on your iGPU?
11:32 fdobridge: <s​amantas5855> Also Ive been running gnome wayland on a gt710 with nouveau
11:32 fdobridge: <m​agic_rb.> my hdmi's are hooked into the nvidiia gpu
11:32 fdobridge: <m​agic_rb.> my hdmi's are hooked into the nvidia gpu (edited)
11:32 fdobridge: <s​amantas5855> it has some graphical glitches
11:32 fdobridge: <m​agic_rb.> all of them, usbc included
11:32 fdobridge: <s​amantas5855> but it can even run minecraft
11:33 fdobridge: <m​agic_rb.> yeah its working fine on x11, but i seem to recall dri3 not being in place for nouveau
11:35 fdobridge: <m​agic_rb.> but ive no clue, the whole graphics is a mystery to me still
11:38 fdobridge: <r​hed0x> interesting, turning on the DXVK HUD breaks renderdoc captures with NVK
11:38 fdobridge: <r​hed0x> if I make a capture without the HUD, it works
11:38 fdobridge: <r​hed0x> if I make one with the HUD, it doesnt
11:47 fdobridge: <m​agic_rb.> im going to attempt to bump to mesa master again, hopefully it wont break everything
12:52 fdobridge: <z​mike.> does this mean your kc-cts MR is no longer needed
13:09 fdobridge: <m​arysaka> I think Faith had issues on Ada for those tests, the Turing issue is scheduling related :blobcatnotlikethis:
13:10 fdobridge: <m​arysaka> (there was also a bug around HFMA2 source 2 when using immediate that I fixed a bit earlier)
13:11 fdobridge: <p​avlo_kozlenko> Can nouveau know how to swap vram?
13:11 fdobridge: <S​id> ..why would you want to do that
13:12 fdobridge: <p​avlo_kozlenko> My vram is clogged, what should I do?
13:13 fdobridge: <p​avlo_kozlenko> If I'm not mistaken, amd implements this
13:13 fdobridge: <t​riang3l> ~~bindless was a mistake~~
13:14 fdobridge: <p​avlo_kozlenko> If I'm not mistaken, AMD implements this (edited)
13:15 fdobridge: <t​riang3l> I'm not sure about Nouveau specifically, but I think every non-meme driver should be able to automatically demote allocations to system memory at least in OpenGL in non-bindless-resources scenarios
13:16 fdobridge: <p​avlo_kozlenko> Windows analogy
13:16 fdobridge: <p​avlo_kozlenko> https://cdn.discordapp.com/attachments/1034184951790305330/1230869654906470451/image.png?ex=6634e3b2&is=66226eb2&hm=12f6ec5ed4a6190173f00a6258aa656b5efb0ea68f5975c39b6b665784e6c60f&
13:17 fdobridge: <p​avlo_kozlenko> https://forums.developer.nvidia.com/t/non-existent-shared-vram-on-nvidia-linux-drivers/260304
13:17 fdobridge: <t​riang3l> on Vulkan that's the responsibility of applications unfortunately, as there are many ways to reference buffers and textures without explicitly individually binding them, and often many resources are placed in one allocation
13:18 fdobridge: <t​riang3l> on Vulkan that's the responsibility of applications unfortunately, as there are many ways to reference buffers and textures without explicitly individually binding them, and often applications place many resources in one allocation (edited)
13:19 fdobridge: <t​riang3l> on Vulkan that's the responsibility of applications unfortunately, as there are many ways to reference buffers and textures without explicitly individually binding them, and often applications place many textures/buffers in one allocation (edited)
13:20 fdobridge: <t​riang3l> I'm not sure about Nouveau specifically, but I think every non-meme kernel driver should be able to automatically demote allocations to system memory at least in OpenGL in non-bindless-resources scenarios (edited)
13:22 fdobridge: <g​fxstrand> I disabled fp16 for my runs. I think we have a swizzle bug but Mary couldn't repro so I'm going to try and look at it.
13:22 fdobridge: <g​fxstrand> One of the MRs definitely is needed because it fixes the build on F40.
13:23 fdobridge: <z​mike.> ok
13:23 fdobridge: <g​fxstrand> Those are all CTS bugs
13:24 fdobridge: <t​riang3l> `nouveau_gem.c` appears to have the VRAM/GART domain placement preference logic typical of a DRM driver, I think unless something is broken, demotion should work
13:25 fdobridge: <g​fxstrand> Yes it can.
13:25 fdobridge: <g​fxstrand> Bindless has nothing to do with it.
13:26 fdobridge: <g​fxstrand> Except on Intel DG2. :blobcatnotlikethis:
13:28 fdobridge: <g​fxstrand> The kernel moves BOs back and forth and patches up the page tables accordingly. The GPU never notices.
13:29 fdobridge: <t​riang3l> It still needs specific work from the application's side (calling glMakeTextureHandleNonResidentARB) for residency to be tracked more granularly than just "everything is needed"… or not?
13:29 fdobridge: <g​fxstrand> Unless you're Intel DG2 where color compression only works if it's pinned to VRAM for all of time. 🤡
13:30 fdobridge: <g​fxstrand> Nope. It'll just move stuff to system RAM and map that I've the GPU address space. The descriptor doesn't have to change.
13:30 fdobridge: <t​riang3l> something like textures of fully occlusion-culled objects though are still a waste of usable VRAM of course though
13:31 fdobridge: <g​fxstrand> Nope. It'll just move stuff to system RAM and map that into the GPU address space. The descriptor doesn't have to change. (edited)
13:31 fdobridge: <t​riang3l> even if they're bound explicitly
13:31 fdobridge: <t​riang3l> something like textures of fully occlusion-culled objects are still a waste of usable VRAM of course though (edited)
13:31 fdobridge: <t​riang3l> something like textures of fully occluded objects are still a waste of usable VRAM of course though (edited)
13:33 fdobridge: <t​riang3l> Yes, but the BO of a bindless texture will be assumed to be referenced in every submission using bindless textures at all unless you explicitly specify it as non-resident if I understand correctly
13:35 fdobridge: <g​fxstrand> The only thing that unbind/residency does is give more of a hint that it's not going to be used so the kernel should evict those first. It doesn't affect whether or not the kernel can evict it. As long as the page tables support mapping system RAM into the GPU address space (they all do), the kernel can evict anything it wants and no one will notice except that access to things in system RAM will be expensive.
13:36 fdobridge: <t​riang3l> Yeah, just without explicit binding, eviction is less aware of what's really important, that's what I wanted to say
13:37 fdobridge: <t​riang3l> Yeah, just without explicit binding, and with one VkDeviceMemory shared between resources without bothering about things like spatial/temporal locality in the game's world, eviction is less aware of what's really important, that's what I wanted to say (edited)
13:38 fdobridge: <t​riang3l> Yeah, just without explicit binding, and even if everything was bound explicitly, but one BO was shared between resources without bothering about things like spatial/temporal locality in the game's world, eviction is less aware of what's really important, that's what I wanted to say (edited)
13:38 fdobridge: <t​riang3l> Yeah, just without explicit binding, and even if everything was bound explicitly, but one BO (VkDeviceMemory) was shared between resources without bothering about things like spatial/temporal locality in the game's world, eviction is less aware of what's really important, that's what I wanted to say (edited)
13:39 fdobridge: <g​fxstrand> On some older GPUs, there are limits on the size of the address space or on the amount of system RAM that can be mapped. With those GPUs, explicit BO tracking is necessary to ensure things stay within those limits, even if the application has more allocated. Intel GM45, for instance, has a limit of something like 512MB at a time, even if you have 4GB of RAM. On modern GPUs, it's "You have a 40 bit address space. Have fun!"
13:40 fdobridge: <t​riang3l> i really want to make `prefersDedicatedAllocation = VK_TRUE` for everything in my bindless-incapable driver 🍩 🤰
13:40 fdobridge: <g​fxstrand> You're welcome to do that
13:41 fdobridge: <t​riang3l> I'm not because that'd ruin render target aliasing possibly in many games and that's probably more important in memory-constrained situation 🙃
13:41 fdobridge: <g​fxstrand> And it kinda makes sense for bindless-incapable drivers.
13:41 fdobridge: <t​riang3l> I'm not because that'd ruin render target aliasing possibly in many games and that's probably be more important in memory-constrained situation 🙃 (edited)
13:41 fdobridge: <t​riang3l> I'm not because that'd ruin render target aliasing possibly in many games and that's probably be more important in memory-constrained situations 🙃 (edited)
13:41 fdobridge: <t​riang3l> I'm not because that'd ruin render target aliasing possibly in many games and that's probably more important in memory-constrained situations 🙃 (edited)
13:42 fdobridge: <g​fxstrand> Especially if you have a 32-bit address space and depend on kernel patching of addresses.
13:42 fdobridge: <g​fxstrand> Hasvk is very much in that boat. 🚢
13:42 fdobridge: <t​riang3l> But can disable it for render targets and storage images/buffer specifically
13:43 fdobridge: <t​riang3l> and get one 128 MB VMA allocation with only a few megabytes actually used by some RTs :xenia_sob:
13:44 fdobridge: <t​riang3l> But can disable it for render targets and storage images/buffers specifically (edited)
14:17 fdobridge: <t​riang3l> On that Evergreen ship?
15:39 fdobridge: <g​fxstrand> Ugh... Trying to remember which one is MaxwellB...
15:41 fdobridge: <m​arysaka> Maxwell B = GTX 9XX (SM52) / Tegra X1 (SM53)
15:41 fdobridge: <m​arysaka> or GM2XX
15:41 fdobridge: <g​fxstrand> Right...
15:41 fdobridge: <g​fxstrand> Not 750 TI. I really need to put labels on things. 😅
15:41 fdobridge: <m​arysaka> yeah 750 Ti is GM10X or something so Maxwell Gen 3
15:41 fdobridge: <m​arysaka> yeah 750 Ti is GM10X or something so Maxwell Gen 1 (edited)
15:42 fdobridge: <m​arysaka> ~~Gen 3 is Pascal in my heart~~
15:42 fdobridge: <m​ohamexiety> ~~mine too~~
15:42 fdobridge: <m​ohamexiety> the changes were really so small lol
15:43 fdobridge: <m​arysaka> not really right? There is shader interlock I believe and the new texture headers
15:44 fdobridge: <m​arysaka> oh you mean for Pascal
15:44 fdobridge: <m​ohamexiety> yep. maxwell 2 -> pascal
15:47 fdobridge: <g​fxstrand> Now the real question: Why did I buy such giant GPUs when I was back-filling my collection? This 980 TI is a beast and it can't even reclock. 😂
16:00 RSpliet: gfxstrand: I think I obtained an NVA0 back when I was still working on reclocking. I had to make the case bulge and slide it through the HDD bracket to make it fit...
16:00 fdobridge: <g​fxstrand> Totally believable
16:01 fdobridge: <g​fxstrand> This 980 TI is a solid inch longer than my big 2060 which is already a full-sized card.
16:01 fdobridge: <g​fxstrand> It's no 4090 but still...
16:02 RSpliet: If I had a banana and I knew I had the card here in my flat I'd send you a picture. Think it's in the Netherlands though...
16:07 fdobridge: <r​edsheep> There's no such thing as a video card that's too big :p
16:08 fdobridge: <z​mike.> my-spoon-is-too-big.meme
16:10 fdobridge: <r​edsheep> 4 slot cards make me unreasonably happy
16:11 RSpliet: Oh no no, way too much girth for me
16:12 fdobridge: <r​edsheep> I buy big cases fully expecting that within a few years I'll use the space, and I've always been right
16:12 RSpliet: redsheep: the most powerful computer in my house is this https://dlcdnimgs.asus.com/websites/global/products/tt1jzvjitkwxzo6s/img/main/saving_s.jpg
16:13 fdobridge: <t​riang3l> Seeing this makes me want the Xi3 Piston
16:13 fdobridge: <r​edsheep> I bet the 5090 will be massive, and I'll probably be picking one up for testing as soon as they go up for sale
16:13 fdobridge: <r​edsheep> "testing"
16:15 fdobridge: <r​edsheep> Hmm. Now that we are doing GSP the bring up for new generations should be pretty rapid, right? Just need to make the kernel use new enough firmware
16:16 fdobridge: <S​id> not that easy
16:16 fdobridge: <r​edsheep> Though I suppose the compiler work might be a big bigger if Blackwell makes some big changes
16:16 RSpliet: and provided the firmware is released in time
16:16 fdobridge: <S​id> because no stable ABI between GSP versions
16:17 fdobridge: <r​edsheep> RSpliet: We just use the firmware from nvidia's open module, no waiting around
16:18 fdobridge: <r​edsheep> Also like airlied mentioned at one point, the abi not being stable doesn't mean it actually did change. Afaict the harder problem there is solving the multiple firmware versions thing that it sounds like was already being discussed to address with adding 555 firmware
16:26 fdobridge: <r​edsheep> Wanting to not fill up everyone's boot partition and all that
16:36 fdobridge: <m​tijanic> The hardest part of unstable ABI is that you need the infra to handle it, regardless of whether it's a 1% change or a 50% change
16:37 fdobridge: <m​tijanic> Actual changes in runtime communication are probably going to be 99% _API_ compatible (e.g. new fields in the structure)
16:38 fdobridge: <m​tijanic> (this is a consequence of our internal source control where breaking the API requires a lot of complex changes and rebasing so it's usually very rare. But ABI breaks are 'free')
16:38 fdobridge: <m​tijanic> The one exception to the above is the actual bootup flow, which tends to change from chip family to family.
16:38 fdobridge: <m​tijanic> The one exception to the above is the actual GSP bootup flow, which tends to change from chip family to family. (edited)
16:42 fdobridge: <r​edsheep> I see, thanks for the explanation. That makes more sense to me now.
17:10 Lyude: airlied: btw regarding your responses - yeah that makes sense, I kind of figured it might end up needing to be a special path
17:45 fdobridge: <g​fxstrand> That's pretty standard for windows-focused driver dev models. In the Windows world, the only ABIs that are sacrosanct are the ones provided by Microsoft and everyone ships UMD+KMD+FW together. As long as they work together, no one cares if things change.
17:46 fdobridge: <g​fxstrand> The linux world is the weird one here where we have a backwards compatible UAPI guarantee
17:46 fdobridge: <g​fxstrand> In theory, KMD+FW dev could be done in parallel but that would require us having the FW sources checked into the Linux tree and that ain't gonna happen. 😅
18:20 fdobridge: <g​fxstrand> @airlied @ahuillet Looks like S8 is in good shape all the way back to MaxwellB. I'm doing one more full run on Ampere since I reworked all the PTE kinds but I'm 99.9% sure it'll be fine.
18:20 fdobridge: <g​fxstrand> @airlied @ahuillet Looks like S8 is now in good shape all the way back to MaxwellB. I'm doing one more full run on Ampere since I reworked all the PTE kinds but I'm 99.9% sure it'll be fine. (edited)
18:20 fdobridge: <g​fxstrand> I pulled in the hwref headers from OGK and we're using those in NIL now so no more magic hex values. 😁
18:26 fdobridge: <a​huillet> _ => NV_MMU_PTE_KIND_PITCH,
18:26 fdobridge: <a​huillet> still pretty sure this is wrong for at least the one format I saw it hit for
18:27 fdobridge: <g​fxstrand> In the Maxwell function, I think we could replace that with a panic
18:28 fdobridge: <g​fxstrand> On Turing, that's where all color formats end up
18:28 fdobridge: <g​fxstrand> Arguably, those should maybe be `GENERIC_MEMORY`
18:30 fdobridge: <g​fxstrand> However, the moment `pte_kind != 0`, we have to sparse bind it so I'd rather avoid that unless there's a perf reason to do so.
18:31 fdobridge: <g​fxstrand> Unless buffers can be `GENERIC_MEMORY`, too.
18:33 fdobridge: <a​huillet> with the blob? they're definitely not supposed to be pitch leni
18:33 fdobridge: <a​huillet> with the blob? they're definitely not supposed to be pitch linear though (edited)
18:33 fdobridge: <a​huillet> "generic" is also what gets you the compression IIRC
18:34 fdobridge: <a​huillet> if you're really using pitch linear for image data then there's an obvious perf reason but I'm sure you're aware of that
18:34 fdobridge: <g​fxstrand> Yeah, there's `GENERIC_MEMORY`, `GENERIC_MEMORY_COMPRESSIBLE`, and `GENERIC_MEMORY_COMPRESSIBLE_DISABLE_PLC`.
18:34 fdobridge: <g​fxstrand> Oh, we're very much not. It's tiled. But tiling works with `PTE_KIND_PITCH` on Turing+
18:35 fdobridge: <g​fxstrand> That or the kernel is smashing everything to `GENERIC_MEMORY` under the hood.
18:35 fdobridge: <g​fxstrand> If it is, that might actually explain some of the kepler issues....
18:35 fdobridge: <g​fxstrand> @airlied ^^
18:36 fdobridge: <a​huillet> (we call it "block linear" btw)
18:37 fdobridge: <a​irlied> Yeah there is something about 0xfe i think on kepler
18:38 fdobridge: <g​fxstrand> But there's nothing "linear" about it. 😂
18:38 fdobridge: <a​huillet> it is linear, but per block!
18:38 fdobridge: <a​huillet> or the blocks are linear I don't know :)
18:39 fdobridge: <g​fxstrand> An image is a linear 3D array of blocks which are a linear 3D array of GOBs which are a linear 3D array of pixels.
18:39 fdobridge: <g​fxstrand> It's still better than Intel's crazy Yf/Ys formats, though. 😅
18:39 fdobridge: <g​fxstrand> And don't get anyone started on AMD...
18:40 fdobridge: <g​fxstrand> NVIDIA is downright sane!
18:41 fdobridge: <m​arysaka> *nods* I will call that GOB linear now 😕
18:41 fdobridge: <g​fxstrand> 🌶️
18:42 fdobridge: <g​fxstrand> And then there's Intel's W Tiling Format...
18:43 fdobridge: <a​huillet> pre-NV50 (I think) there was another "tiled" format which wasn't called block linear, I think it was called swizzled (?)
18:44 fdobridge: <g​fxstrand> Oof
18:44 fdobridge: <g​fxstrand> Because no one will ever get "swizzled" confused with texture swizzles...
18:44 fdobridge: <g​fxstrand> (Though that might predate the GL texture swizzle extension"
18:45 fdobridge: <g​fxstrand> I think we called them swizzles at Intel some. I know another HW vendor or two calls it that.
18:45 fdobridge: <a​huillet> same problem with "compression" and GL texture compression
18:45 fdobridge: <g​fxstrand> *sigh*
18:45 fdobridge: <g​fxstrand> Yes...
18:47 fdobridge: <g​fxstrand> Back to the topic at the top, though... I'm passing 0 to the kernel and block-linear is fine with that. IDK if that means 0 works or if that means the kernel is smashing to 6 behind my back.
18:58 fdobridge: <a​huillet> understood. I'll take a look at what the blob does see if I can advise on what is best.
18:58 fdobridge: <g​fxstrand> Oh, joy... nouveau.ko does all sorts of kind remapping from the look of things
19:00 fdobridge: <d​jdeath3483> Yeah wtf
19:01 fdobridge: <g​fxstrand> I *think* the remapping is only there to let nouveau.ko force-disable compression. That's the way it appears from a skim.
19:02 fdobridge: <g​fxstrand> Why the KMD is doing that and whether or not it's safe to do that behind my back without me doing a resolve or something, I don't know.
19:02 fdobridge: <g​fxstrand> Maybe it's disabling compression when it evicts to system ram? That would make sense.
19:06 fdobridge: <g​fxstrand> Whether or not those tables are correct, though... That I'm much less sure about. 😅
19:06 fdobridge: <g​fxstrand> Like, this Maxwell table I'm looking at is missing a LOT of entries
19:06 fdobridge: <a​huillet> if you evict to system RAM you're doing some DMA transfer to sysmem
19:06 fdobridge: <a​huillet> writes to sysmem can't be compressed so this will be decompressed at that time I think (in my mental model anyway)
19:07 fdobridge: <g​fxstrand> Yeah
19:07 fdobridge: <a​huillet> some with MSAA resolves if that's what you're talking about - there's nothing to resolve, the storage is there compression or not, it's just what travels on the bus vs. what's in L2 that changes
19:07 fdobridge: <g​fxstrand> So I think that part's fine and the remap table exists to ensure the PTEs we fill out referencing system RAM don't have any compression kinds set.
19:08 fdobridge: <a​huillet> though I wonder if you can disable compression on pages after the fact.
19:08 fdobridge: <g​fxstrand> I doubt you can without a resolve. But I have seen resolve things in the method headers
19:08 fdobridge: <g​fxstrand> IDK what you call them at Nvidia. We called them resolves at Intel.
19:08 fdobridge: <a​huillet> what do you call resolves at Intel then?
19:09 fdobridge: <g​fxstrand> Oh, those are also resolves. 😂
19:10 fdobridge: <g​fxstrand> The 3 hardest problems in computer science are naming things and counting things.
19:10 fdobridge: <a​huillet> resolve for us is MSAA resolves/downsampling, I don't think it's used for anything else
19:10 fdobridge: <a​huillet> resolve for us is MSAA/VCAA resolves/downsampling, I don't think it's used for anything else (edited)
19:11 fdobridge: <g​fxstrand> But yeah, I think I saw some sort of method for in-place decompression
19:11 fdobridge: <g​fxstrand> `NVC579_DECOMPRESS_SURFACE`
19:11 fdobridge: <a​huillet> let me switch vim over to a non-secret method file before I answer :D
19:12 fdobridge: <g​fxstrand> hehe
19:12 fdobridge: <a​huillet> yeah, you can use this for color or depth (separate method)
19:13 fdobridge: <g​fxstrand> I'm not sure why we would want to decompress but having the option is nice.
19:21 fdobridge: <r​hed0x> @gfxstrand do you have 5 minutes? I'd like to talk about the subgroup rotate MR
19:22 fdobridge: <r​edsheep> VCAA? How is there yet another antialiasing scheme I've never heard of?
19:25 fdobridge: <a​huillet> that may not be a public name actually. oops. old stuff anyway
19:27 fdobridge: <a​huillet> https://developer.download.nvidia.com/SDK/9.5/Samples/DEMOS/Direct3D9/src/CSAATutorial/docs/CSAATutorial.pdf CSAA I think
19:28 fdobridge: <r​edsheep> Ah that makes sense. Not surprised the names get warped, the marketing around AA methods has often been kind of annoying
19:32 fdobridge: <r​edsheep> I don't imagine any engineer came up with dlss, it's not in any real sense a super sampling scheme. If anything it's the opposite.
19:33 fdobridge: <r​edsheep> *came up with the name dlss
19:35 fdobridge: <m​ohamexiety> vcaa is among the NV profile inspector settings iirc so it's public/old but I haven't heard much about it outside of that
19:35 fdobridge: <r​edsheep> Google turns up nothing, though that doesn't mean much anymore.
19:39 RSpliet: Wait... do I understand CSAA correctly in that if one of the non-shaded sample points happens to sample (only) a primitive that's not covered by any of the shaded sample points, you... just kind of make up which of the two primitives covered by the shaded points it puts its weight behind?
19:40 RSpliet: (sorry, I said two primitives because I was thinking about the 2+2 mode in my head)
19:42 RSpliet: or I guess you can make that non-shaded sample point just kind of not count, which is easy with 2+2, and not so easy with 8+8
20:13 fdobridge: <g​fxstrand> Sure. Sorry, was doing dishes for a bit.
20:16 fdobridge: <g​fxstrand> I'm backnow
20:16 fdobridge: <g​fxstrand> I'm back now (edited)
20:21 fdobridge: <r​hed0x> basically I was looking into doing it in nak like you proposed in your review comment
20:21 fdobridge: <r​hed0x> but i dont see how
20:23 fdobridge: <r​hed0x> basically the mask is only used to compute the maxLane and thats just used to reject it if it goes oob
20:23 fdobridge: <r​hed0x> i have an example in the MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27863#note_2380815
20:46 fdobridge: <g​fxstrand> Yeah, you're right. It's only taken into account the way I though in `.idx` mode.
20:46 fdobridge: <g​fxstrand> Bummer
20:47 fdobridge: <g​fxstrand> That opcode is so dang complicated...
20:48 fdobridge: <m​oonykay> im curious, are there docs (RE'd or otherwise) lying around for the architecture
20:48 fdobridge: <m​oonykay> im curious, are there docs (RE'd or otherwise) lying around for the architecture in question (edited)
20:48 fdobridge: <m​oonykay> (I collect instruction sets)
20:51 fdobridge: <r​hed0x> i dont see how it would handle wraparound in idx mode for us either (except for doing what the lowering pass does)
20:51 fdobridge: <r​hed0x> https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#ptx-instructions
20:52 fdobridge: <g​fxstrand> We typically go off the PTX docs for most of this stuff.
20:52 fdobridge: <m​oonykay> ah- the native ISA is typically pretty close to PTX?
20:52 fdobridge: <g​fxstrand> PTX and the hardware are typically pretty close
20:52 fdobridge: <m​oonykay> neat
20:53 fdobridge: <g​fxstrand> There's some difference but when it comes to the fiddly bits like we were just discussing, the PTX behavior is usually exactly the HW behavior.
20:53 fdobridge: <m​tijanic> It's about as close to the hardware as the amd64 ISA is close to the actual microops on an intel CPU.
20:54 fdobridge: <m​oonykay> okay but *that* is a rather massive gap
20:54 fdobridge: <m​oonykay> the impression i get here is PTX's gap isnt quite *that* big,
20:54 fdobridge: <m​oonykay> the impression i get here is PTX's gap isnt quite *that* big. (edited)
20:55 fdobridge: <g​fxstrand> I mean there is a decent gap but the mapping is typically fairly direct. It's designed for the hardware after all. It'd be pretty silly to design a huge PTX/HW mismatch.
20:55 fdobridge: <m​oonykay> yeh
20:55 fdobridge: <m​ohamexiety> there are research papers that try to poke at things btw @moonykay
20:55 fdobridge: <m​ohamexiety> e.g., https://arxiv.org/pdf/1804.06826.pdf
20:55 fdobridge: <m​oonykay> (im basically saying AMD64 has a pretty massive ISA/HW mismatch)
20:56 fdobridge: <r​hed0x> does CUDA/PTX do frequent breaking changes or has Nvidias ISA just been mostly stable for ages?
20:56 fdobridge: <g​fxstrand> The over-all theory of operation hasn't changed massively in a while.
20:57 fdobridge: <g​fxstrand> The details shift from generation to generation.
20:58 fdobridge: <g​fxstrand> Put another way, the delta between NV ISA and AMD GCN for instance is 10 or 100x bigger than the delta between NV ISA and PTX.
21:00 fdobridge: <g​fxstrand> Nothing between Fermi and Ada requires a fundamentally different compiler. Some instructions are added or removed. Semantics change a bit here and there. Later HW has a "smarter" encoding scheme. But nothing super fundamental.
21:02 fdobridge: <m​ohamexiety> yeah. the only exception/potential breakage I heard of is some weirdness with Hopper where there's a `sm_90` target and a `sm_90a` target and future `sm_9x` HW isn't guaranteed to support `sm_90a` features (Hopper satisfies both). the functionality in question is `wgmma` iirc. but this may not matter much for normal gfx cards
21:05 fdobridge: <m​ohamexiety> > Target architectures with suffix “a”, such as sm_90a, include architecture-accelerated features that are supported on the specified architecture only, hence such targets do not follow the onion layer model. Therefore, PTX code generated for such targets cannot be run on later generation devices. Architecture-accelerated features can only be used with targets that support these features.
21:08 fdobridge: <r​hed0x> any more beginner issues? :)
21:11 fdobridge: <v​alentineburley> This has the easy tag: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10981
21:12 fdobridge: <v​alentineburley> And this can be closed now for real @gfxstrand https://gitlab.freedesktop.org/mesa/mesa/-/issues/10686
21:30 fdobridge: <p​avlo_kozlenko> +
21:34 fdobridge: <r​edsheep> Appears that's probably also true of https://gitlab.freedesktop.org/mesa/mesa/-/issues/9659 and https://gitlab.freedesktop.org/mesa/mesa/-/issues/9658
21:36 fdobridge: <r​edsheep> Are the missing features for zink real? I can't imagine they are if it passes cts now
21:36 fdobridge: <r​edsheep> https://gitlab.freedesktop.org/mesa/mesa/-/issues/9477
21:46 fdobridge: <g​fxstrand> Fragment shader interlock still needs to be done if we want the relevant GL extension
21:46 fdobridge: <g​fxstrand> Everything else looks fine
21:46 fdobridge: <r​edsheep> So zink doesn't need descriptor buffer?
21:47 fdobridge: <t​riang3l> The 🐷 test for sample interlock assumes guarantees the API doesn't provide btw, be careful
21:47 fdobridge: <t​riang3l> But maybe on Nvidia it'd work
21:48 fdobridge: <t​riang3l> no, not sample interlock, but pixel interlock with sample shading https://gitlab.freedesktop.org/mesa/piglit/-/issues/93
21:50 fdobridge: <g​fxstrand> It doesn't need it, no.
21:50 fdobridge: <z​mike.> not correct
21:51 fdobridge: <z​mike.> your feature support level will be crippled if you don't have DB
21:51 fdobridge: <z​mike.> a lot of the precompile handling requires it
21:51 fdobridge: <g​fxstrand> What do you mean by "feature support level"?
21:52 fdobridge: <z​mike.> full feature support means you support all versions of GL and you have great perf and you don't get constant shader compile stuttering
21:52 fdobridge: <z​mike.> right now you don't get the last part
21:52 fdobridge: <g​fxstrand> Okay, fair.
21:52 fdobridge: <g​fxstrand> What's different with descriptor buffer, though?
21:53 fdobridge: <z​mike.> non-db handling is far more complex and I wasn't about to add another layer of complexity to the already-incomprehensible layering of precompilation
21:54 fdobridge: <z​mike.> I mean, have you looked at the non-db descriptor code in zink? it's nightmarish
21:55 fdobridge: <S​id> I mean, have you looked at ~~the non-db descriptor~~ code ~~in zink~~? it's nightmarish
21:55 fdobridge: <S​id> :P
21:55 fdobridge: <z​mike.> computers were a mistake
21:55 fdobridge: <g​fxstrand> Yes
21:56 fdobridge: <r​edsheep> Somebody was saying there's hope for implementing descriptor buffer, right?
21:57 fdobridge: <g​fxstrand> I think @georgeouzou has been hacking on it
21:57 fdobridge: <g​fxstrand> Unfortunately, typed buffers are pretty much a disaster with DB on NVIDIA
21:58 fdobridge: <z​mike.> what is "typed buffers" in this contemxt
21:58 fdobridge: <z​mike.> what is "typed buffers" in this context (edited)
21:58 fdobridge: <g​fxstrand> `VkBufferView`
21:59 fdobridge:<g​fxstrand> has too much terminology in her head
21:59 fdobridge: <z​mike.> ah you mean like texel buffers
22:00 fdobridge: <g​fxstrand> Yes and storage image buffers or whatever you want to call those things
22:00 fdobridge: <g​fxstrand> storage texel buffers. That's the term.
22:01 fdobridge: <z​mike.> nobody likes these anyway
22:02 fdobridge: <g​fxstrand> And then AMD has to be all weird and implement them as something that isn't an image.
22:02 fdobridge: <n​anokatze> we just need hw for nir_format_convert
22:03 fdobridge: <z​mike.> if it makes you feel better I wasted an hour today examining how to do shader variants for texel buffer swizzles on A/L/I formats
22:03 fdobridge: <z​mike.> and got nowhere
22:04 fdobridge: <g​fxstrand> Wait, A/L/I formats are allowed in texel buffers?!?
22:05 fdobridge: <z​mike.> compat contexts~~~~~
22:05 fdobridge: <z​mike.> there are even piglit tests
22:06 fdobridge: <z​mike.> I may go back to saying fuckit because this is excruciating to figure out without killing cpu perf
22:06 fdobridge: <r​edsheep> So apple wasn't just being lazy when they split gl to put compat in a corner?
22:06 fdobridge: <g​fxstrand> VK_EXT_buffer_view_swizzle?
22:06 fdobridge: <g​fxstrand> (Just say no...)
22:06 fdobridge: <z​mike.> that's the other option, but iirc some hardware can't do it anyway
22:06 fdobridge: <z​mike.> I think it was even discussed at some point
22:07 fdobridge: <g​fxstrand> Intel, NV, and AMD should be able to
22:07 fdobridge: <z​mike.> and given how vanishingly rare this is (I've literally never seen it), the value proposition is...
22:07 fdobridge: <g​fxstrand> IDK about IMG
22:07 fdobridge: <g​fxstrand> Yeah
22:07 fdobridge: <z​mike.> outside of A8_UNORM anyway, which is native
22:07 fdobridge: <g​fxstrand> Yeah
22:07 fdobridge: <z​mike.> but having so many piglit fails from one missing feature sucks
22:07 fdobridge: <z​mike.> even if the feature sucks
22:07 fdobridge: <g​fxstrand> This doesn't seem worth having a Vulkan extension
22:08 fdobridge: <z​mike.> not unless I find some high performance game (ab)using it probably not
22:16 fdobridge: <m​oonykay> what even is A/L/I
22:17 fdobridge: <g​fxstrand> Alpha, Luminance, and Intensity. They're grayscale formats.
22:17 fdobridge: <g​fxstrand> Luminance, for instance, is a single channel that samples as `(x, x, x, 1)`
22:18 fdobridge: <m​oonykay> I mean, I've seen A8_UNORM get used
22:18 fdobridge: <m​oonykay> but thats it
22:19 fdobridge: <g​fxstrand> Yeah, luminance and intensity formats are pretty uncommon
22:19 fdobridge: <m​oonykay> (and only as a source buffer for text)
22:19 fdobridge: <m​oonykay> (and only as a source buffer for text glyphs) (edited)
22:19 fdobridge: <m​oonykay> (and only as a source texture for text glyphs) (edited)