00:04fdobridge: <airlied> I'd guess primary but ont sure
00:11skeggsb: Privileged Register Interface
00:11skeggsb: (i think)
00:13airlied: ah makes more sense :-)
00:13fdobridge: <marysaka> oh that would make ton of sense yeah
18:20rmckeever: Is anyone familiar with the NV9097_TEXHEAD0_*_SOURCE_IN_* nvidia headers? I'm trying to add VK_FORMAT_B4G4R4A4_UNORM_PACK16 to the nil_format_info table, and there's something wrong with my entry.
18:24rmckeever: My entry is:
18:24rmckeever: C4(A, A4R4G4B4_UNORM, NONE, A, R, G, B, UNORM, A4B4G4R4, T),
18:25rmckeever: It's making all the dEQP-VK.pipeline.monolithic.sampler.view_type.2d_unnormalized.format.b4g4r4a4_unorm_pack16.* tests fail.
18:27karolherbst: rmckeever: soo weird idea: you might have to reverse the channels
18:27karolherbst: like you see it done in "C4(A, B5G5R5A1_UNORM, A1R5G5B5, B, G, R, A, UNORM, A1B5G5R5, TD),"
18:28rmckeever: So B, G, R, A?
18:28karolherbst: nvidia seems to declare in big endian order for normal formats, but if it's packed, it's little endian or something
18:28rmckeever: Okay, I'll try that.
18:28karolherbst: "C4(A, B4G4R4A4_UNORM, NONE, B, G, R, A, UNORM, A4B4G4R4, T),"
18:28karolherbst: there you also see it being reverse
18:44rmckeever: Actually, that makes it identical to an existing entry for a different format.
18:52karolherbst: rmckeever: which one?
19:00rmckeever: I believe it's VK_FORMAT_A4R4G4B4_UNORM_PACK16
19:01fdobridge: <jekstrand> Watch out for channel orders
19:01fdobridge: <jekstrand> `VK_FORMAT` and nvidia are the same but they're backwards from `PIPE_FORMAT`
19:01fdobridge: <jekstrand> The one on the left in the format table is a `PIPE_FORMAT_*` and the one on the right is nvidia
19:03fdobridge: <karolherbst🐧🦀> but for packed ones it's reversed, no?
19:04fdobridge: <jekstrand> I'm talking about packed
19:04fdobridge: <karolherbst🐧🦀> ahh
19:04fdobridge: <jekstrand> They're all the same for array formats
19:04fdobridge: <karolherbst🐧🦀> I see
19:06fdobridge: <jekstrand> But `VK_FORMAT_B4G4R4A4` is `PIPE_FORMAT_A4R4G4B4` and the nvidia hardware format would be `B4G4R4A4` if that format existed. Except it doesn't. Theo only one that exists is `A4B4G4R4` so it needs a GBAR swizzle.
19:06fdobridge: <jekstrand> Yeah, that's a weird swizzle
19:07fdobridge: <jekstrand> rmckeever ^^
19:11fdobridge: <jekstrand> That format ending up in the Vulkan spec as required was a mistake. 😕
19:11fdobridge: <karolherbst🐧🦀> I think some games use it though 🙃
19:22fdobridge: <jekstrand> Only because the right format isn't required
19:22fdobridge: <jekstrand> The format NV has in hardware is also the one Intel has in hardware which is also the one that's in DX. We totally just got it wrong in Vulkan 1.0.
19:23fdobridge: <karolherbst🐧🦀> annoying :/
19:23fdobridge: <jekstrand> Very
20:36rmckeever: GBAR works:
20:36rmckeever: C4(A, A4R4G4B4_UNORM, NONE, G, B, A, R, UNORM, A4B4G4R4, T),
21:00hdzki[m]: Speaking of texture formats, i have some weird texture format that i need some IDing for
21:00hdzki[m]: Have y'all seen a planar ycbcr 4:2:0 like texture format in the wild?
21:01fdobridge: <jekstrand> Yeah, Intel has one
21:02hdzki[m]: hdzki[m]: luma (sometimes with alpha) is on its own plane. meanwhile cb and cr are interlaced in a different plane that's half the res of the first (hence the 4:2:0 ilke part)
21:05hdzki[m]: i found it in a game before but the FourCC was just ATI2 (that's BC5) which isn't useful
21:17fdobridge: <jekstrand> PSA: Just rebased nvk/main on mesa/main
21:18fdobridge: <jekstrand> rmckeever: Feel free to rebase your VK_KHR_device_groups MR and we can probably merge it this afternoon.
21:20airlied:wonders if we will ever do device groups properly for anyone
21:20fdobridge: <jekstrand> I doubt it
21:20fdobridge: <jekstrand> I'm unaware of any apps that use it
21:20fdobridge: <jekstrand> NVIDIA supports it and AMD might.
21:22airlied: AMDVLK does
21:22airlied: lots of loops
21:36fdobridge: <jekstrand> heh
21:56fdobridge: <nanokatze> q2rtx uses device groups
21:56fdobridge: <nanokatze> but eh who cares about device groups
22:03pendingchaos: strange brigade too
22:03pendingchaos: and maybe some other game that I don't really remember
22:35fdobridge: <karolherbst🐧🦀> @jekstrand your lut stuff is fun 😄
22:38fdobridge: <karolherbst🐧🦀> but why aren't you just doing what we do in codgen?
23:07fdobridge: <jekstrand> IDK what you do in codegen
23:07fdobridge: <jekstrand> I'm not doing all that much copy+paste