19:21Lyude: karolherbst: just approved the MR btw
19:21Lyude: are there still patches on patchwork you'd like me to go through?
19:22karolherbst: uhm. I guess there are still some. So if you find some time you could try to look into some of the potential fixes there
19:22Lyude: alright - I'll use the list you linked last time
19:22karolherbst: but there are some display relates ones
19:23karolherbst: Lyude: e.g. https://patchwork.freedesktop.org/patch/415221/ , but I think we fixed that bug already, no?
19:23Lyude: karolherbst: no idea, lemme see
19:23Lyude: I remember this patch but I might as well double check
19:24karolherbst: yeah... I kind of skipped those patches who required some form of investigation for now
19:24karolherbst: Lyude: btw.. do you have admin rights on pw or well.. can modify the state of the patches at least?
19:24Lyude: yeah it's fixed
19:25Lyude: and actually I think I might, let me see
19:25Lyude: karolherbst: ah - apparently not
19:25karolherbst: I use "under review" for patches pushed to staging/nouveau-next|fixes btw
19:25karolherbst: Lyude: okay.. you might want to poke daniels for this
19:25karolherbst: or... wait
19:25karolherbst: let me see
19:26karolherbst: I am actually maintainer of like all projects :D
19:26karolherbst: so maybe I can add you
19:28karolherbst: I think patchwork is broken
19:28karolherbst: I am not logged in on the "about the project pages".... for whatever reasons
19:28Lyude: It's been like that for a long time iirc
19:28Lyude: you log back in if you go to any of the other pages for some reason
19:29Lyude: btw karolherbst - if I'm reviewing someone's patch from a mailing list, should I be opening up an MR for it once I've reviewed it and think it's good to go?
19:29karolherbst: probably some php bug
19:29Lyude: (in this case, a patch that just came in a day or two ago)
19:30karolherbst: Lyude: I am actually still wondering about batching up patches or just do it one on one..., but I think it's also not helpful to just do MR for everything, because it's quite some pita atm
19:31karolherbst: so I usually just use "pwclient get $patch_id" + "dim apply" to collect patches and just submit them all in one go for CI testing and stuff
19:31karolherbst: but for single patches I'd just review them on the list and push to drm-misc directly...
19:31karolherbst: well... if we would have hw CI the reason to use gitlab would be much stronger
19:35Lyude: makes sense, will push this trivial acr fix in a bit then
19:55karolherbst: Lyude: I already pushed that :D
19:55karolherbst: sorry for not updating the status on that patch
19:56karolherbst: (I still plan to add this to CI for auto updates)
20:09Lyude: ah lol