00:00karolherbst: imirkin: ehh.. I get the feeling it's something dumb...
00:02karolherbst: upsi...
00:02karolherbst: imirkin: I think I found it...
00:02karolherbst: boah
00:02karolherbst: is this embarassing
00:02karolherbst: I hope it's not that
00:02karolherbst: NPOOOOOOOOOOOOOOOOOOOOOOOOOOOO
00:02karolherbst: fucking noooo
00:02karolherbst: :(
00:02karolherbst: it's so embarrasing
00:03karolherbst: imirkin: https://gist.githubusercontent.com/karolherbst/9ef19687a95e1047288faf6a308a306c/raw/bc8473ed812494ba6eb89b294a324c1ea8e1aff3/nooooo.patch
00:03karolherbst: ...........................................
00:03karolherbst: ...........................................
00:03karolherbst: we apply the offset twice...
00:03karolherbst: once when mapping
00:03karolherbst: and once in the inline funcs....
00:04karolherbst: I bet this fixes gnome as well....
00:06karolherbst: mhh
00:06karolherbst: okay.. it doesn't fix gnome completely but those silly vertex issues are gone and we are left with random memory issues
00:06karolherbst: ....
00:06karolherbst: oh well
00:06karolherbst: success I guess
00:07karolherbst: I'll submit an MR...
00:09ccr: heh
00:11karolherbst: oh wow...
00:11karolherbst: it wasn't always broken like this..
00:12imirkin: karolherbst: uhm ... why should the offset not be applied?
00:12imirkin: we apply it to the user address...
00:12karolherbst: because those inline functions do the same as well :)
00:12imirkin: o
00:12imirkin: um
00:13karolherbst: map += start; :)
00:13imirkin: so should remove from user as well
00:13imirkin: or really
00:13imirkin: should just remove it from those stupid functions
00:13imirkin: i probably broke it 100 years ago
00:13karolherbst: yeah... kind of
00:13karolherbst: on 18.0 just one path was broken :)
00:14imirkin: that's embarassing
00:14karolherbst: yep
00:14karolherbst: ewll
00:14karolherbst: _we_ didn't break it
00:14imirkin: god broke it
00:14karolherbst: :D ahh no
00:14karolherbst: it got broken by one of those infamous gallium reworks
00:14imirkin: not surprising
00:15imirkin: those things always break something
00:15karolherbst: atm figuring out if we can just cC stable or if we have to limit it
00:15karolherbst: soo
00:15karolherbst: 0cf5d1f22620 broke the has_user_indices path
00:15karolherbst: Sat Nov 28 00:44:19 2020 -0500
00:16imirkin: just do Fixes: that
00:16imirkin: technically not right
00:16imirkin: but ... right enough
00:16karolherbst: 330d0607ed60 is weird
00:16imirkin: user indices is the majority
00:16karolherbst: that broke the other path probably
00:16karolherbst: or the other path was always broken
00:17karolherbst: but that was in 2017
00:17karolherbst: so we don't care really
00:17imirkin: yeah, i semi-remember that transition
00:17karolherbst: I just remove it from the funcs
00:17karolherbst: and do a CC: stable
00:17imirkin: sounds good.
00:18imirkin: thanks for tracking that down
00:18imirkin: now you can look at the minecraft thing :)
00:18karolherbst: :D
00:19imirkin: i _doubt_ it's related
00:21karolherbst: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12054
00:22karolherbst: but mhh
00:24karolherbst: so yeah..
00:24karolherbst: reverted my nv40 class hack and gnome still runs better now :)
00:26karolherbst: reverted my fix and it got worse again ... okay
00:26karolherbst: cool
00:26karolherbst: now just random memory corruptions or whatever is going on
00:37karolherbst: imirkin: do you know where the minecraft issue is?
00:37karolherbst: or was that on IRC?
00:50imirkin: no, there's a bug
00:50imirkin: but there's not much info
00:50imirkin: just like ... "minecraft renders funny"
00:50imirkin: some sort of perspective correction issue
00:50imirkin: but that could be driven by 100 diff things
00:51imirkin: hrmph can't seem to find it
00:52imirkin: oh yeah, it was filed in the wrong place
00:52imirkin: still can't find it =/
00:53imirkin: maybe it got closed?
00:53imirkin: karolherbst: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4884
00:53imirkin: it got auto-fixed it seems
09:10karolherbst: weird
09:20snail: i haven't tested minecraft in a while
09:20snail: i did just now and 1.16.5 seems to work fine (aside from being slow but that's expected)
09:20snail: but older versions now have different corruptions