00:00 karolherbst: imirkin: ehh.. I get the feeling it's something dumb...
00:02 karolherbst: upsi...
00:02 karolherbst: imirkin: I think I found it...
00:02 karolherbst: boah
00:02 karolherbst: is this embarassing
00:02 karolherbst: I hope it's not that
00:02 karolherbst: NPOOOOOOOOOOOOOOOOOOOOOOOOOOOO
00:02 karolherbst: fucking noooo
00:02 karolherbst: :(
00:02 karolherbst: it's so embarrasing
00:03 karolherbst: imirkin: https://gist.githubusercontent.com/karolherbst/9ef19687a95e1047288faf6a308a306c/raw/bc8473ed812494ba6eb89b294a324c1ea8e1aff3/nooooo.patch
00:03 karolherbst: ...........................................
00:03 karolherbst: ...........................................
00:03 karolherbst: we apply the offset twice...
00:03 karolherbst: once when mapping
00:03 karolherbst: and once in the inline funcs....
00:04 karolherbst: I bet this fixes gnome as well....
00:06 karolherbst: mhh
00:06 karolherbst: okay.. it doesn't fix gnome completely but those silly vertex issues are gone and we are left with random memory issues
00:06 karolherbst: ....
00:06 karolherbst: oh well
00:06 karolherbst: success I guess
00:07 karolherbst: I'll submit an MR...
00:09 ccr: heh
00:11 karolherbst: oh wow...
00:11 karolherbst: it wasn't always broken like this..
00:12 imirkin: karolherbst: uhm ... why should the offset not be applied?
00:12 imirkin: we apply it to the user address...
00:12 karolherbst: because those inline functions do the same as well :)
00:12 imirkin: o
00:12 imirkin: um
00:13 karolherbst: map += start; :)
00:13 imirkin: so should remove from user as well
00:13 imirkin: or really
00:13 imirkin: should just remove it from those stupid functions
00:13 imirkin: i probably broke it 100 years ago
00:13 karolherbst: yeah... kind of
00:13 karolherbst: on 18.0 just one path was broken :)
00:14 imirkin: that's embarassing
00:14 karolherbst: yep
00:14 karolherbst: ewll
00:14 karolherbst: _we_ didn't break it
00:14 imirkin: god broke it
00:14 karolherbst: :D ahh no
00:14 karolherbst: it got broken by one of those infamous gallium reworks
00:14 imirkin: not surprising
00:15 imirkin: those things always break something
00:15 karolherbst: atm figuring out if we can just cC stable or if we have to limit it
00:15 karolherbst: soo
00:15 karolherbst: 0cf5d1f22620 broke the has_user_indices path
00:15 karolherbst: Sat Nov 28 00:44:19 2020 -0500
00:16 imirkin: just do Fixes: that
00:16 imirkin: technically not right
00:16 imirkin: but ... right enough
00:16 karolherbst: 330d0607ed60 is weird
00:16 imirkin: user indices is the majority
00:16 karolherbst: that broke the other path probably
00:16 karolherbst: or the other path was always broken
00:17 karolherbst: but that was in 2017
00:17 karolherbst: so we don't care really
00:17 imirkin: yeah, i semi-remember that transition
00:17 karolherbst: I just remove it from the funcs
00:17 karolherbst: and do a CC: stable
00:17 imirkin: sounds good.
00:18 imirkin: thanks for tracking that down
00:18 imirkin: now you can look at the minecraft thing :)
00:18 karolherbst: :D
00:19 imirkin: i _doubt_ it's related
00:21 karolherbst: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12054
00:22 karolherbst: but mhh
00:24 karolherbst: so yeah..
00:24 karolherbst: reverted my nv40 class hack and gnome still runs better now :)
00:26 karolherbst: reverted my fix and it got worse again ... okay
00:26 karolherbst: cool
00:26 karolherbst: now just random memory corruptions or whatever is going on
00:37 karolherbst: imirkin: do you know where the minecraft issue is?
00:37 karolherbst: or was that on IRC?
00:50 imirkin: no, there's a bug
00:50 imirkin: but there's not much info
00:50 imirkin: just like ... "minecraft renders funny"
00:50 imirkin: some sort of perspective correction issue
00:50 imirkin: but that could be driven by 100 diff things
00:51 imirkin: hrmph can't seem to find it
00:52 imirkin: oh yeah, it was filed in the wrong place
00:52 imirkin: still can't find it =/
00:53 imirkin: maybe it got closed?
00:53 imirkin: karolherbst: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4884
00:53 imirkin: it got auto-fixed it seems
09:10 karolherbst: weird
09:20 snail: i haven't tested minecraft in a while
09:20 snail: i did just now and 1.16.5 seems to work fine (aside from being slow but that's expected)
09:20 snail: but older versions now have different corruptions