17:03 Lyude: RSpliet: updating the ddx slipped my mind, so I'm going to try to do it sometime today
19:09 RSpliet: Lyude: no worries, it slipped my mind too :-P But thanks for taking care of it!
23:11 tavvva: Good morning/afternoon/evening
23:12 tavvva: Guys ... may I ask for help with NVS140 suspend/hibernation problems?
23:13 tavvva: the card often fails to wake up correctly .... I get binary garbage on the screen or black screen and frozen X
23:14 tavvva: I've tried the latest 5.12 kernel available in Fedora devel
23:16 tavvva: I'm able to switch to the text console with Ctrl+Alt+F2, but when I return to X, the garbage is still there ..... just the mouse cursor works .... probably because of the fact it's HW accelerated
23:33 Lyude: imirkin: https://paste.centos.org/view/980c9842 any idea what might be causing this build issue? trying to update the rpm we package for xorg-x11-drv-nouveau to 1.0.17
23:34 imirkin: gimme a few
23:35 imirkin: someone else was complaining about this
23:35 imirkin: so ... we don't use sarea since <long time ago>
23:35 imirkin: seems like fedora stopped shipping it
23:35 imirkin: or it's not in some package anymore
23:35 imirkin: i expect you'd have the same problem building any verison of nouveau
23:36 imirkin: if you mail a patch removing the #include, happy to push it / make a new release
23:36 imirkin: or if you want you can make a local patch
23:36 imirkin: src/nv_include.h:#include "sarea.h"
23:36 imirkin: just removing this guy
23:36 imirkin: or i can do it, easy enough i suppose
23:36 imirkin: not too contentious to remove an unused header
23:36 imirkin: (i hope)
23:37 imirkin: yea, let me just do that...
23:39 imirkin: Lyude: can you pm me what you want for reported-by?
23:40 imirkin: (i'm blanking on your full name / email, apologies)
23:44 Lyude: imirkin: Lyude Paul <lyude@redhat.com>
23:44 Lyude: and np
23:44 Lyude: thank you for fixing this btw!
23:44 imirkin: Lyude: will you be able to test with a git checkout?
23:44 imirkin: i.e. if i push the change, can you check if it works
23:44 imirkin: before i go to the trouble of remembering how to make a release
23:45 Lyude: oh yeah sure thing, a patch might be even easier (but I can do git checkout as well) since I'm just going to try applying it to the rpm spec file we've got
23:46 imirkin: Lyude: https://cgit.freedesktop.org/nouveau/xf86-video-nouveau/commit/?id=3ee7cbca8f9144a3bb5be7f71ce70558f548d268
23:46 imirkin: feel free to grab it in patch form, whatever's convenient
23:46 imirkin: and lmk if it's all good, and then i'll do another release
23:50 Lyude: imirkin INFO: Done(/home/lyudess/Projects/homebrew/xorg-x11-drv-nouveau/xorg-x11-drv-nouveau-1.0.17-1.fc35.src.rpm) Config(fedora-rawhide-x86_64) 1 minutes 18 seconds
23:50 imirkin: is that good?
23:50 Lyude: yes it built :P, I'll go ahead and make an update tomorrow morning
23:50 RSpliet: Lyude: sarea.h is still provided by xorg-x11-server-source-1.20.11-1.fc34.noarch. Although I prefer this resolution :-P might the rpm spec be missing this dependency?
23:51 imirkin: ok cool
23:51 imirkin: if it built, it must work
23:51 imirkin: i think that's how C works
23:51 RSpliet: it compiles, ship it!
23:51 Lyude: RSpliet: eh-it's fixed now :P
23:51 imirkin: the compiler proves that the code matches the programmer's shifting intent
23:51 Lyude: plus that probably wouldn't have fixed it, the source packages are really just for debuginfo
23:51 imirkin: ;)
23:51 RSpliet: Lyude: from the package description, they ripped out some legacy stuff just for building Xvnc
23:52 imirkin: well, whatever. we don't use sarea
23:52 RSpliet: Exactly
23:52 imirkin: it used to be used a long while ago
23:52 imirkin: and it was relied on for even longer, without actually being used
23:52 imirkin: but then when that got dropped, this header include probably got left behind
23:55 imirkin: probably this guy: https://cgit.freedesktop.org/nouveau/xf86-video-nouveau/commit/?id=b1a630b48210d6a3c44994fce1b73273000ace5c