00:15 skeggsb: imirkin: i'm actually not 100% sure why it should matter which you use there actually
00:15 skeggsb: i think they should be equal at that point
00:16 skeggsb: obviously they're not, but i don't know why
00:28 imirkin: skeggsb: hm ok. well the person was also testing on an older kernel
00:28 imirkin: pre dispnv50 split
00:28 imirkin: although afaik you didn't actually restructure anything, just moved things around
00:29 imirkin: skeggsb: the bug filer is pretty responsive, so if you want him to try some stuff, i suspect he'd oblige
00:31 skeggsb: i think it's probably ok to just use mode
00:31 skeggsb: though mode_fixup() in drm_atomic_helper.c should probably have copied mode->adjusted_mode in the cases we'd need this already, from my reading
00:33 endrift: turns out now that I'm using uniforms for palettes my palette-pathological case wasn't actually palette-pathological. I fixed the thing that was making it pathological without realizing it and now it's fast :x
00:34 imirkin: =/
00:34 imirkin: make it slow again!
00:34 endrift: haha
00:34 endrift: well this actually tells me that frame-splitting isn't as slow anymore
00:34 imirkin: i was using the GPU as a space heater. it is no longer heating up. bug!
00:34 endrift: since I'm still frame-splitting on palette changes
00:34 endrift: imirkin: I've legitimately done that before
00:34 endrift: when I was in college
00:34 endrift: I would use BOINC as my space heater
00:35 endrift: probably only because I didn't have to pay for electricity though *shrug*
00:35 imirkin: leaky dorm windows?
00:36 endrift: nah, I just didn't turn on my radiator until it actually got to be snowy out
00:36 endrift: it was hard to control how hot it got my room
00:36 imirkin: that's why you put the heater full-blast and then open your windows :)
00:36 endrift: heh
00:36 endrift: anyway this means that the reason frame-splitting was slow was due to texture uploads which I've now eliminated all of
00:37 HdkR: woo
00:37 endrift: during scanline splits at least
00:37 endrift: VRAM texture uploads are still a thing
00:37 endrift: and they are still annoying
00:38 endrift: HdkR: you should hack your switch and use my emulator on it to play those GBA games you haven't been dying to play :P
00:38 imirkin: INTEL_map_texture to the rescue
00:38 HdkR: hah
00:38 endrift: I'm morbidly curious to see how badly this'll break on your average Mali GPU
00:38 endrift: in Android
00:38 endrift: i.e. not using Panfrost
00:39 endrift: I'm looking forward to the future of Panfrost, but right now I hear it's not generally usable
00:39 imirkin: HdkR: time for an updated "graphics drivers on android" follow-up article?
00:40 endrift: also I want a Pinebook Pro already gosh dang
00:41 HdkR: imirkin: I think most of the results would end up the same. Nvidia Blob and Mesa being highest rated
00:41 imirkin: HdkR: they haven't cleaned up their act? =/
00:41 imirkin: hopefully mesa does better than it did before.
00:41 imirkin: hey - freedreno has UBO's now
00:41 imirkin: and dual-source blend on a3xx =]
00:42 imirkin: (i'm still disproportionately happy that i managed to get that working... and equally unhappy i couldn't work it out on a4xx)
00:42 HdkR: Dolphin implements framebuffer_fetch now for those chips that can use it anyway
00:44 HdkR: endrift: For Midgard it is almost usable for regular desktop use :P
14:52 imirkin_: skeggsb: should this go the other way and null out ilut unconditionally for fp16? https://github.com/skeggsb/nouveau/commit/28dd125e669bcf61c5414b95fc403b476167d6af
14:52 imirkin_: i.e. even if ilut is set explicitly, it should be blanked out?
14:53 imirkin_: and/or a return -EINVAL in that case?
14:53 imirkin_: (erm, there's no return value there. but probably should be?)
23:28 skeggsb: imirkin_: that can't happen at this point anyway
23:28 imirkin_: no, but in the future, when the luts are configurable
23:29 imirkin_: (which is something i'd like to work on)
23:29 imirkin_: i can fix it then, i suppose. just a bit of a landmine :)
23:29 skeggsb: you'd just reject that configuration instead, earlier in atomic_check
23:30 imirkin_: right
23:30 imirkin_: fair enough
23:31 imirkin_: presumably that was the bit required to make fp16 work on turing? or it's still broken?
23:32 skeggsb: no, everything i tested works now, i tested/fixed the issues on earlier and later gpus than you have available, so, when you're happy with the rest of it, should be good to go i expect
23:32 imirkin_: i'm happy...
23:33 skeggsb: alright, well, i'll merge your patch as-is in that case :)
23:39 imirkin_: thanks =]
23:39 imirkin_: btw, ksm/gv100 -> kms/gv100...
23:43 imirkin_: skeggsb: fyi, my hope is to try to bang out most of the HDR stuff over the next month or two -- basically keeping up with intel / amdgpu.
23:44 imirkin_: my next thing is going to be supporting higher-bpc modes, esp on hdmi
23:45 imirkin_: let me know if you plan on working on related items, since i don't want to collide with your work