00:43imirkin: hakzsam: fyi your vbo_push_hint trick does nothing for the talos trace i have around
00:43imirkin: hakzsam: i flipped it to always be 0, still no go
07:14hakzsam: imirkin, it does, the vbo_push_hint removes the flickering
10:43karolherbst: okay, we can get overlord 1 and 2 keys :3
11:17mupuf: karolherbst: nice :)
14:18imirkin: hakzsam: no, it doesn't :) at least not the flickering i'm seeing.
14:19hakzsam: imirkin, the green wall thing?
14:19imirkin: like every other frame
14:19imirkin: the brightness of the scene changes
14:19hakzsam: which trace?
14:20imirkin: "talos-karolherbst.trace" - must have been one i got from him a while ago. recorded in 640x480
14:20imirkin: fwiw i did not see such flickering on the GF108
14:20hakzsam: I played talos a while with my patch applied and it looked quite fine
14:20mupuf: hakzsam: depending on the settings, the sahders are different
14:20imirkin: different settings? or GK20x is more affected?
14:21karolherbst: hakzsam: did you check the water reflection issue?
14:21hakzsam: default settings
14:21mupuf: hakzsam: default settings do not exist in games :D
14:21mupuf: they change depending on your hw and driver
14:21karolherbst: in talos there are like 40+ settings anyway for graphics alone
14:22mupuf: yeah, talos is insane :D
14:22karolherbst: it's good to track issues down though
14:22karolherbst: because you can disable like everything
14:22mupuf: well, actually, it is only good to work around them
14:22karolherbst: ss3 is the same
14:22karolherbst: mupuf: well
14:22karolherbst: mupuf: you can trace both
14:22karolherbst: and diff it
14:22karolherbst: kind of
14:23mupuf: if you are *really* lucky and you get a repeatable benchmark
14:23mupuf: and there are no threads involved
14:23hakzsam: imirkin, this one Talos_wall_flicker.trace ?
14:23karolherbst: hakzsam: no, he got old ones
14:23karolherbst: really old ones
14:23karolherbst: like over half a year
14:23imirkin: hakzsam: could be. it's an old trace, from 6-12 months ago
14:24hakzsam: imirkin, okay, please share then
14:24hakzsam: I will check
14:25mupuf: maybe the game was buggy and got fixed since then
14:26mupuf: like shadow of mordor ;)
14:26imirkin: there _was_ some kind of bugfix there
14:26Calinou: <mupuf> hakzsam: default settings do not exist in games :D
14:26Calinou: talk about old games
14:26imirkin: relating to derivatives
14:26Calinou: "hey, you have 1920x1080 screen, i'll use 800x600 because i can!"
14:26mupuf: Calinou: hehe
14:26Calinou: thankfully modern games at least respect that :P
14:27hakzsam: imirkin, did you replay the trace on blob?
14:27mupuf: for better or worse, games are updatable nowadays
14:27imirkin: but i'm pretty sure karol did
14:28imirkin: the TS on the file is July 9, 2015 btw
14:28mupuf: hakzsam: that's no proof
14:28mupuf: the game got ported with nvidia as a target, most likely
14:28hakzsam: if rendering is same between blob and nouveau, it is
14:28mupuf: it is thus easy to rely on bugs in the driver
14:29imirkin: or features :)
14:29mupuf: yeah, that would be a good proof :)
14:30hakzsam: anyways, we have multiple issues with that game and they are hard to track down and I'll probably stop looking at them because I'm frustrating :)
14:30imirkin: hakzsam: https://people.freedesktop.org/~imirkin/traces/talos-karolherbst.trace.xz
14:30mupuf: hakzsam: are you?
14:30mupuf: frustrated is more likely :p
14:30hakzsam: imirkin, "forbidden"
14:30imirkin: stupid permissions.
14:30hakzsam: mupuf, yeah, much better ;)
14:30imirkin: hakzsam: try again
14:31mupuf: hakzsam: anyway, I would say that if it does not manifest on a newer version, it may be a bug in the app or a bug in the driver ... but then it is a matter of priorities :)
14:32mupuf: fixing issues you can reproduce should have a highger priority than the ones you can't reproduce
14:40hakzsam: imirkin, ah, I know that trace, already tried and my workaround fixes the flickering on gk106 (except the green wall thing which seems to be totally unrelated)
14:47imirkin: not the GK208. also i don't see how your change could have any effect... they never use client buffers
14:49hakzsam: imirkin, you should try on your gf108 :)
14:50imirkin: hakzsam: it never flickered on the GF108 in the first place
14:50imirkin: only the wall turned green
14:50imirkin: and there was flickering of the shadows, but not of the whole scene
14:50hakzsam: weird, because it does on my gf119
14:50hakzsam: same on gk106
14:51imirkin: so it's clearly a timing issue
14:54hakzsam: this was your first guess
14:54hakzsam: but fixing such an issue... is not easy :)
19:49orbea: I noticed this in valgrind when starting anything like glxgears or retroarch, could it be something nouveau could do better? http://dpaste.com/1NMEPG7
19:50imirkin_: orbea: those are normal
19:50orbea: okay, good to know :)
21:39glennk: imirkin_, presumably valgrind needs to be taught about those ioctls?
21:40imirkin_: glennk: nfc
21:40imirkin_: i think the issue is that we're passing uninitialized data to the kernel, but then the kernel fills in those structures