00:06 airlied: agd5f: drm/radeon: fix dp link rate selection (v2) I think it broke some stuff other than nutmge
00:06 airlied: why does the code no longer test for is_dp12_connector?
00:07 airlied: I'm narrowing down a bisect to that area, will investigate a bit further tomorrow
00:07 airlied: or Friday actually
00:23 airlied: agd5f: yeah it picks 2/540000 now instead of 4/540000 which breaks MST
00:24 airlied: though it could be I'm feeding it the wrong thing, I should probably just have MST always pick max lanes/spped
01:38 mupuf: karolherbst: nope, that is also where I got stuck
01:38 mupuf: changing little things here and there got me up to more than 3 millions reclocks
01:38 mupuf: but to be honest, 700k reclocks is stable enough for now!~
01:39 karolherbst: yeah
01:39 karolherbst: especially if you do them within a few minutes
01:39 karolherbst: RSpliet did some PLL locking for fermi+ which isn't in master yet
01:39 karolherbst: maybe with it it gets a bit more stable
01:41 karolherbst: mupuf: in fact I was also doing my cat current_load while reclocking, I wanted to stresstest PMU communication not reclocking ...
01:41 mupuf: :)
01:41 karolherbst: so in fact it was like 350k downclocks, 350k upclocks + 700k PMU requests with reply
01:42 karolherbst: mhh 700k * 7: PMU requests in total then?
01:42 karolherbst: each reclock sends 4 requests I think?
01:42 karolherbst: anyway
01:42 karolherbst: doesn't matter that much
01:43 karolherbst: mupuf: wanna review those both patches for the PMU so we can get that upstreamed? https://github.com/karolherbst/nouveau/commits/pmu_fixes2
01:43 karolherbst: I doubt they are _important_ now, but they will be if we use the PMU more
01:44 mupuf: will do tonight
01:44 karolherbst: thanks
01:45 karolherbst: but do you have any clue why reclocking + pmu + glxspheres64 might let the gpu disconnect from the bus?
01:54 karolherbst: mupuf: by the way, we have now a gm108 vbios and trace :)
01:55 karolherbst: ciupicri: intel gpus
01:56 karolherbst: ciupicri: if not, the 210 might be not a good choice
01:57 karolherbst: ciupicri: depends actually how much you want to spend, but I would go for a low end kepler/maxwell1
01:57 karolherbst: ciupicri: otherwise if you want to do 4k video decoding or something in that area the older gpus might be too slow
02:09 mupuf: karolherbst: it does not disconnect from the bus
02:10 mupuf: the "fell from the bus" means that it stops answering PCIe requests
02:10 karolherbst: ahh okay
02:10 mupuf: or actually, maybe it is just PFIFO being busted
02:10 karolherbst: therm: GPIO 16 unknown PWM: ffffffff
02:11 mupuf: cool for the gm108!
02:11 karolherbst: yep :)
02:11 karolherbst: though I also got therm: GPIO 16 unknown PWM: 0007b07f
02:12 karolherbst: mupuf: and if you find some time after the PMU stuff, could you check if that is fine with you? https://github.com/karolherbst/envytools/commit/e4586c7011f88cdb7541abe45379c3cafc3480b8
02:12 karolherbst: I decoupled the generated voltage entries from the entries in the voltage table basically except when we parse the entries
02:16 mupuf: karolherbst: please send your patches to the ML
02:16 karolherbst: this is for envytools and the pmu one was already sent by me
02:17 mupuf: ok! great!
02:17 mupuf: so, tonight is review night
02:17 mupuf: I also need to review changes for arduide
02:18 karolherbst: well I think I resend the pmu ones because the last time was in november :D
02:18 karolherbst: ohh I open a PR for the envytools one
02:19 karolherbst: I already did this month..: https://lists.freedesktop.org/archives/nouveau/2016-March/024217.html
02:35 karolherbst: hakzsam: how long will you need reator today?
02:38 hakzsam: karolherbst, I will need to run piglit
02:39 hakzsam: karolherbst, if you don't need it too long, please do now
02:39 karolherbst: I have to do stuff before
05:01 tsmish: df
06:56 karolherbst: RSpliet: it works as I expected :)
06:56 RSpliet: karolherbst: could you elaborate your definition of "it" please? :-)
06:57 karolherbst: RSpliet: I took the vbios or mupufs kepler
06:57 karolherbst: filled the entries with the generated voltages, because there were the useless garbage
06:57 karolherbst: removed the 02 bit from the header and nvidia volted the card the same
06:57 karolherbst: which means I am able to fill the entries and get nvidia to volt what I want
06:57 karolherbst: gpios were parsed according to original vbios
06:57 karolherbst: then
06:58 karolherbst: I could modify the GPIOs pins of an entry
06:58 karolherbst: which nvidia took and volted the gpu differently for the same VID
06:58 RSpliet: excellent news! :-)
06:58 karolherbst: which means nvidia parsed the entry for 1.175V, but I put in the GPIO combination of 1.15V => got 1.15V
06:58 karolherbst: then
06:58 karolherbst: I added the 02 bit in the header
06:58 karolherbst: and then I got 1.175V again
06:58 karolherbst: which means, nvidia generated the VID entries
06:59 karolherbst: allthough I left the modded 1.175V entry in the table
07:02 RSpliet: I'm about to give your updated tree a proper run
07:02 karolherbst: nice thanks :)
07:03 RSpliet: up to you whether you might want to send a few voltage-related fixes to the ML or rather wait for the whole boost work to be done first and do it in one go
07:04 karolherbst: I want to do it in pieces actually
07:04 karolherbst: but this can go as a small series
07:04 karolherbst: because it actually fixes setting the expected voltage
07:04 karolherbst: and currently nouveau sets a different voltage on those cards
07:05 karolherbst: which is clearly a bug and not boost related ;)
07:05 RSpliet: yep, if it passes the test you'll have my blessing
07:05 karolherbst: but please check if the GPIOs are set accordingly
07:05 karolherbst: there might be still an offset of 1 or 2
07:06 RSpliet: oh yes, unfortunate that your gist paste disappeared, I don't recall the exact registers to double-check
07:06 karolherbst: ohh yeah I tidied those up...
07:06 karolherbst: wait
07:06 RSpliet: I'll reproduce it from my VBIOS, no worries
07:06 karolherbst: https://gist.github.com/karolherbst/5ec04a900e8d42bef424
07:07 RSpliet: or you do it, excellent :-P
07:07 karolherbst: I hacked the stuff into nvbios already
07:07 karolherbst: so
07:07 karolherbst: nvidia volted to 1.087500V right?
07:07 RSpliet: yeah, I need the GPIO mapping table too :-D
07:07 karolherbst: ahh
07:08 karolherbst: reload
07:08 RSpliet: thanks!
07:48 karolherbst: ohh I could have looked into the 31st bit too...
07:53 karolherbst: RSpliet: okay, that one is no enable bit
08:39 karolherbst: yeah nice, nvidia segfaults when using GL_ARB_shading_language_include in a conformant way...
08:40 RSpliet: everyone knows nouveau is more stable, amirite? :-P
08:40 karolherbst: well mesa doesn't support it yet :p
08:40 karolherbst: but it is a really painfull extension ...
08:41 karolherbst: currently writing piglit tests for it
08:55 mupuf: karolherbst: didn't know you were also interested in adding gl features
08:55 mupuf: fun!
08:55 karolherbst: mupuf: well I game I have an I really like needs this ...
08:55 karolherbst: I already got it working, just need to do it the right way...
08:56 mupuf: wow, that was an impressively good english you used :D
08:56 karolherbst: what :D
08:56 mupuf: well, this is exactly how calim wrote most of the gallium driver
08:56 karolherbst: ohh
08:56 karolherbst: now I see
08:56 karolherbst: :D
08:56 mupuf: ;)
08:56 karolherbst: mhh
08:57 mupuf: a fellow german speaker ... from austria
08:57 RSpliet: ahhh, yes. Haven't heard of him for a while, how's he doing?
08:57 karolherbst: ahhh
08:58 karolherbst: mupuf: by the way, I checked the voltage table stuff and everything seems okay :)
08:58 karolherbst: there is indeed a bit flag to see if we should parse the entries or generate from the header
08:59 mupuf: ah, cool!
08:59 karolherbst: I found one gpu which would work either way
09:00 karolherbst: but each way would generate different voltages
09:00 karolherbst: and nouveau does the wrong thing currently on it
09:00 arizo: karolherbst: painkiller freezes in 5 mins if galium is enabled
09:00 arizo: otherwise in longer time but still freezes
09:01 karolherbst: arizo: context?
09:01 arizo: ?
09:01 karolherbst: ahh, oss and wine? or is this nouveau related?
09:02 arizo: yes i have nouveau and gt730 shit card
09:03 karolherbst: ahh the fermi one...
09:03 arizo: yes
09:04 karolherbst: mhh
09:04 karolherbst: does your entire destkop freezes?
09:04 karolherbst: or just the games?
09:04 arizo: almost entire X
09:04 arizo: i press alt -tab but game picture remains
09:05 arizo: then i press F1 to arouse terminal dropd-down and then i can ctrl + c to shut the game
09:05 karolherbst: okay, but the display still gets updated
09:05 arizo: if i just press alt-tab and select other apps game picture just remains
09:06 karolherbst: arizo: then you shoudl check the application output and dmesg
09:06 arizo: i can paste from the terminal
09:07 karolherbst: yeah, just use a pasting site for this
09:09 arizo: karolherbst: https://bpaste.net/show/f9243feeae73
09:10 karolherbst: arizo: I guess it happens randomly?
09:10 karolherbst: ohh yeah, the game just crashes
09:10 karolherbst: well yeah, I find it painful to debug wine applications, you should check on winehq
09:11 arizo: ok
09:11 arizo: karolherbst: yes randomely
09:11 arizo: especially after heavy battles
09:11 mupuf: karolherbst: well, ... congrats for finding the bit :)
09:12 karolherbst: though I think RSpliet actually pointed to that one
09:12 karolherbst: but more in a "they could mean something" way :)
09:12 arizo: bit for fermi?
09:12 RSpliet: mupuf: I've been chasing karolherbst with a bunsenburner for two days, but he did the work :-P
09:12 mupuf: we are getting close for voltage management
09:13 mupuf: RSpliet: sounds fun! Smells like roasted chicken now?
09:13 RSpliet: beats salmon
09:16 karolherbst: by the way, what is tegra 124 and what is 210?
09:17 karolherbst: ohh 210 is the maxwell one and the kepler one, good
09:18 karolherbst: *124 the kepler one
09:18 RSpliet: karolherbst: https://en.wikipedia.org/wiki/Tegra
09:19 karolherbst: tegra_fuse_read_early(FUSE_CPU_SPEEDO_2);
09:19 karolherbst: mhh
09:19 karolherbst: 0x30
09:23 karolherbst: 0x130 reg
09:23 karolherbst: but I doubt this means anything for nouveau
09:23 karolherbst: but it maybe in the FUSE range indeed
09:26 RSpliet: karolherbst: nouveau seems to have selected 1.1V now
09:26 RSpliet: one step above NVIDIA
09:26 karolherbst: k
09:26 karolherbst: good
09:26 RSpliet: but at least it's nice and functional
09:26 karolherbst: :)
09:26 karolherbst: very good
09:27 karolherbst: and sensors also says 1.1V?
09:27 RSpliet: yes sir
09:27 karolherbst: good :)
09:28 RSpliet: oh, and my little pll lock patch doesn't cause unexpected behaviour, so I'll send that out tonight too
09:28 karolherbst: :)
09:28 karolherbst: RSpliet: I will retest reclokcing with it then, maybe it is more stable
09:29 RSpliet: well, it's not expected to be, but it'll warn you when the PLL value is unstable
09:29 RSpliet: sounds like valuable debugging info
09:29 karolherbst: I thought the pll can take some time until it produces the value we want
09:29 mupuf: RSpliet: does nvidia poweroff the locking detection circuit after reclocking?
09:29 mupuf: karolherbst: it does
09:29 RSpliet: mupuf: yep
09:30 mupuf: you need to wait for it to be locked before moving on
09:30 karolherbst: then I would expect that this patch indeed increases reclocking stability
09:30 mupuf: but RSpliet probably meant that after a few ms, it would continue anyway
09:30 mupuf: but yeah, it should help
09:30 RSpliet: nouveau did wait for the test to pass, but didn't take the effort to enable the test prior to waiting
09:30 arizo: karolherbst: let's try to find bit for fermi?
09:31 karolherbst: well when I reclock nearly thousend times a second, a few ms matter :)
09:31 mupuf: RSpliet: so it just timed out?
09:31 mupuf: or by chance, it was already at the right value?
09:31 RSpliet: mupuf: in practice it was always enabled by default? idk, seems like it, but doesn't sound like you'd want to take the risk
09:31 mupuf: possible
09:31 karolherbst: well
09:31 karolherbst: I got timeouts while messing with the PLL
09:31 mupuf: I was only worried about the power usage
09:32 RSpliet: it's probably not the most power-hungry piece of logic, but any picojoule counts right?
09:32 karolherbst: arizo: that already affects fermi as well
09:32 karolherbst: arizo: or, well a few fermis
09:32 karolherbst: but it isn't that important
09:32 arizo: what effects?
09:32 mupuf: RSpliet: yop!
09:32 arizo: tell me how to overclock it
09:32 karolherbst: nouveau already does actually
09:33 karolherbst: but more by accident
09:33 mupuf: but i would expect it to be more power hungry
09:33 RSpliet: arizo: currently changing the clock speeds of fermi GPUs is not supported
09:33 mupuf: well, no idea how it is implemented
09:33 arizo: that;s why i propose to find that bit to reclock
09:33 karolherbst: mupuf: funny though, the same has to be done for 0x40 voltage tables ...
09:33 karolherbst: but this is fermi, so I care less
09:33 RSpliet: arizo: it's not "a bit", it's a mountain of work and I'm up to my elbows in it
09:33 karolherbst: but most likely the same
09:34 karolherbst: just maybe different bits
09:34 karolherbst: but if we are good, we could get kepler/maxwell reclocking stable this year and maybe even fermi :)
09:35 mupuf: karolherbst: that would be an amazing feat, yes!
09:36 karolherbst: well jayhost` is testing reclocking on maxwell for a few days now
09:36 karolherbst: and it looks really good
09:36 karolherbst: he said he had his card on max clock for a few days without issues
09:36 mupuf: oh, right, forgot to test on the GM750
09:37 mupuf: what the heck
09:37 mupuf: GTX 750
09:37 karolherbst: somebody just need to find some time to figure out any differences
09:37 mupuf: well, it will start with checking the clock tree :p
09:37 mupuf: did you figure out the clocking issue RSpliet had?
09:37 mupuf: or still has
09:38 karolherbst: which clocking issues?
09:38 karolherbst: it was the voltage to begin with
09:38 karolherbst: you know nouveau parsed the VIDs wrong
09:38 karolherbst: so low voltages were actually high and high ones actually low...
09:38 karolherbst: or do you mean the wrong clock reading?
09:39 mupuf: the HUB6 clock was wrong IIRC
09:40 karolherbst: yeah that was my mistake
09:40 karolherbst: the NvBoost config option messed the cstate creation up
09:40 mupuf: when you do all the work, it is always your mistake :p
09:40 karolherbst: he has no boost clock
09:40 karolherbst: so base_clock = 0MHz
09:40 karolherbst: and cstate with freq > base_clock => fail
09:41 karolherbst: then he ended up with the pstate.base as his clocks and the domains aren't adjusted in that case
09:41 karolherbst: or maybe even adjusted in a wrong way
09:41 karolherbst: but somehow I really like the gpuboost of nvidia
09:42 RSpliet: it grows on you, doesn't it?
09:42 karolherbst: usually if you hear something like enabled pm by default and dynamic reclocking you expect more perf
09:42 karolherbst: but on nvidia hardware with nouveau you won't get more perf
09:42 ciupicri: karolherbst: regarding the Geforce 210: I don't care about 4K videos. As long as LibreOffice, web browsing and 1080p work fine, I'm all good. Though I'm a bit worried about future support i.e. if in 3 or 4 years the card won't be supported anymore.
09:42 karolherbst: ciupicri: that's why I said you should rather get a kepler or maxwell1
09:43 karolherbst: ohh wait
09:43 karolherbst: video decoding ...
09:43 karolherbst: mhh
09:43 karolherbst: we have VP5 right?
09:43 RSpliet: karolherbst: kepler video decoding should be as good as gt21x?
09:43 mupuf: for 4K, video decoding actually matters
09:43 ciupicri: yes, not decoding. Heck, we don't even have 1080p monitors yet, just 1024x768 or something like that.
09:44 karolherbst: RSpliet: nope, kepler has better one
09:44 RSpliet: karolherbst: in terms of nouveau support I mean, silly
09:44 karolherbst: yeah, still better :p
09:44 mupuf: karolherbst: I added video tests to ezbench, to test the performance of the windowing system and compare the output modules
09:45 karolherbst: mupuf: nice :)
09:45 mupuf: and saying there are differences is an understatement
09:45 karolherbst: well
09:45 karolherbst: did you check with 4kx4k videos?
09:46 mupuf: nope, the biggest ones I have are 4k vids
09:46 karolherbst: ohh by the way
09:46 karolherbst: there is VP7
09:47 karolherbst: with dedicated HEVC decoding
09:47 mupuf: ...
09:47 karolherbst: gm206
09:48 karolherbst: VP6 needs a shader to decode HEVC
09:49 karolherbst: ciupicri: well you are best off with a VP5 gpu with nouveau I would say
09:50 ciupicri: what does that mean? From G610 on?
09:50 karolherbst: late fermis and all keplers
09:50 karolherbst: GF117 and GF119
09:50 karolherbst: and all GKs
09:51 ciupicri: ok, thank you
09:51 karolherbst: but the only difference to VP4 is really 4k support, but having a more modern gpu is usually the better choice and kepler is in a good shape with nouveau
09:51 karolherbst: so I would choose a kepler one
10:36 karolherbst: RSpliet: most likely you won't be able to test just the VID fixes because everything else isn't in place, but maybe it still works: https://github.com/karolherbst/nouveau/commits/vid
10:36 karolherbst: ohh I will send those out anyway now
10:45 dcomp: saw
11:01 karolherbst: uhh I did something wrong
11:16 rmu: hi there. I have a somewhat curious issue with a recently purchased ViewSonic 4k display connected via display port to a Thinkpad 410 with nvidia gt218m (nvs 3100m)
11:16 rmu: every time the mouse pointer touches the left edge of the screen, the display becomes a block of solid color
11:17 rmu: sleeping/resuming the laptop reactivates the screen
11:17 rmu: option "HWcursor" "false" leads to black screen, not usable even without external display
11:17 rmu: no messages in dmesg or x-log
11:18 rmu: any ideas how to debug this?
11:18 karolherbst: RSpliet: by the way, the 0x40 entries are looking more funny
11:18 karolherbst: and the same on all cards
11:19 karolherbst: 1 byte, 8 entries: 0x00, 0x11, 0x22, 0x33, 0x44, 0x58, 0x68, 0x78
11:21 rmu: versions: X server 1.17.2, linux kernel 4.5.0, nouveau 1.0.12
11:22 mupuf: rmu: wow, that's annoying
11:23 mupuf: not sure if any nouveau dev has access to a 4K screen
11:23 mupuf: red hat has, though!
11:23 mupuf: airlied, skeggsb: have you tried nouveau with a 4K monitor?
11:40 rmu: dual screens active, does not matter if external screen is on the left or on the right
12:22 karolherbst: dammit nvidia. Only one implementing an extension on the deskopt and then they do it wrong...
12:23 mupuf: karolherbst: or do they?
12:23 mupuf: I pestered at nvidia a few times when writing tests
12:24 mupuf: and a carreful reading + angry email from nvidia convinced me otherwise :D
12:24 karolherbst: "An INVALID_VALUE error will be generated under any of the following conditions: Either <name> or <string> is NULL."
12:24 karolherbst: this sounds pretty clear, doesn't it?
12:24 mupuf: yep :D
12:24 karolherbst: glNamedStringARB(SHADER_INCLUDE_ARB, strlen(name), name, 0, NULL); no INVALID_VALUE in glGetError()
12:24 mupuf: nvidia is not really good at this game
12:25 karolherbst: the last param is string
12:27 karolherbst: but they check name == NULL
12:27 karolherbst: and return INVALID_VALUE
12:27 karolherbst: but if the lenght is != 0, it segfaults....
12:28 hakzsam: fun :)
12:28 karolherbst: yeah..
12:29 karolherbst: so I should just bother them with this and get some angry response
12:38 karolherbst: is the git stuff from freedesktop down?
12:39 karolherbst: ohh
12:40 karolherbst: annonymous git is down
12:51 karolherbst: mupuf: by the way I still can't access the wiki repository/edit page
12:52 mupuf: hmm
12:52 karolherbst: maybe I do something wrong though
12:52 karolherbst: should I be able to use git or the edit page?
12:53 mupuf: the edit page
12:54 karolherbst: maybe I just typed in the wrong password
12:54 karolherbst: how can I validate the htaccess hash locally?
12:56 karolherbst: ahh
12:56 karolherbst: htpasswd -c
12:56 karolherbst: "Password for user karolherbst correct."
12:56 karolherbst: k
13:01 karolherbst: mupuf: what algorithm does fdo use?
13:02 karolherbst: ohh md5
13:02 karolherbst: k
13:02 karolherbst: then I have no idea
13:13 mupuf: karolherbst: send an email to request an account
13:55 karolherbst: mupuf: k thanks
13:55 karolherbst: ohhh newest rumors :D
13:55 karolherbst: nvidia working on own distribution for games, ...
13:56 karolherbst: oh man, I should also just fake such screenshots :p
14:00 Digit: + copy layer, darken about 50%, blur, set to dodge. :3
14:01 karolherbst: I actually feel guilty for talking about this
14:05 maxpas: http://forum.doom9.org/showthread.php?p=1759920#post1759920
14:05 maxpas: " Late last year Microsoft published a specification on VP9 DXVA2 hardware acceleration. Shortly after, both Intel and NVIDIA started to support this in their hardware. This version of LAV Video enables using the hardware acceleration in the latest NVIDIA GPUs (GTX950/960), and recent Intel GPUs (Braswell and Skylake)"
14:05 maxpas: GM206 can do full hardware decoding of VP9 video streams also
14:06 karolherbst: maxpas: and?
14:07 maxpas: waiting for Nvidia to enable HEVC Main10 10bit and VP9 hardware decoding on UNIX based OS
14:07 maxpas: https://devtalk.nvidia.com/default/topic/918822/linux/hevc-main-10-profile-decoding-using-vdpau-unsupported-on-gtx-950-361-28-/
14:08 maxpas: "Today, the driver doesn't support MAIN 10, although the hardware does (hence why MAIN 10 works on windows). It will require major vdpau changes to fully support as vdpau assumes 8bit surfaces throughout its pipeline and that will need to change."
14:08 karolherbst: ohh so you want to RE that and hack it together for nouveau?
14:09 maxpas: no, just wanted to pass on the info, GM206 decoder is awesome and Pascal will probably get an even better hardware decoder that will be faster than VP7
14:10 maxpas: http://www.gputechconf.com/ Tues, April 5 09:00 AM PT Nvidia's big keynote for GTC, probably will get to see Pascal in action finally
14:10 karolherbst: yeah well
14:10 karolherbst: we still have to RE VP6 and VP7
14:11 karolherbst: so there is no hardware decoding on maxwell in any case
14:12 maxpas: VP6 doesn't support HEVC & VP9, not very interesting
14:13 karolherbst: well, we can't just skip it
14:16 karolherbst: anyway, because there are only a handful gpus out there with VP7, nobody will look at that before VP6 is done (most likely)
14:17 maxpas: VP6 only has H.264 hardware decoding, very different from VP5 design?
14:18 karolherbst: no idea
14:18 karolherbst: but seems more different
14:18 karolherbst: because there is actually HEVC support on VP6
14:18 karolherbst: but shader based
14:19 karolherbst: and some VP6 cards should even have hardware HEVC support
14:20 maxpas: VP6 HEVC partial hardware decoding has been tested on Windows, it sucks compared to VP7
14:20 karolherbst: right
14:20 maxpas: VP7 does 4K 10bit videos at 120FPS easily, even at very high bitrates
14:20 karolherbst: mupuf: which product do I have to choose?
14:21 maxpas: the hybrid/partial decoder can't handle 10bit and barely can handle 24FPS decoding
14:30 mupuf: karolherbst: you are doing it wrong
14:30 karolherbst: mupuf: huh?
14:30 mupuf: https://wiki.freedesktop.org/sitewranglers/wiki/401/
14:30 maxpas: also I wonder why VP6 wasn't figured out already, since GTX 750 Ti/750 GM107 doesn't have Falcon like GM20x does
14:31 karolherbst: maxpas: falcons are always there
14:31 karolherbst: and if wonder, why don't you give it a shoot ;)
14:32 karolherbst: mupuf: I thought we did this htpasswd stuff already?
14:32 karolherbst: ahhh
14:32 karolherbst: now I get it
15:11 mupuf: karolherbst: review done on envytools
15:11 karolherbst: :)
15:11 mupuf: for the voltage table
15:12 mupuf: pretty good stuff!
15:12 mupuf: it is just nitpicking
15:16 karolherbst: mupuf: one thing, the read out entries are only there for the entry based parsing and are removed from the other ones. there will be still prints for the lines, because there is something in the entries, but it is all unknown
15:16 karolherbst: this is regarding the unrelated fix comment
15:17 karolherbst: mupuf: now it looks like this: https://gist.github.com/karolherbst/cfee3501d4f6ff383876 (header based)
15:18 mupuf: ack :)
15:19 mupuf: Now, for whatever you feel like changing after my comments, fix, and then push :)
15:22 karolherbst: k
15:48 karolherbst: mupuf: thanks for the review
15:51 mupuf: you're welcome
15:51 mupuf: still some more to make!