02:49 anarsoul: I have 2 more optimizations implemented. 1st is duplicate fneg and fabs if source is intrinsic, it allows duplicating loads when mods are folded
02:49 anarsoul: another is "compactification". If we have an instruction that only uses combiner but previous instruction doesn't use combiner they can be merged
02:52 anarsoul: lima-dup-mods and ppir-compact2 branches in my fdo mesa repo, I'll create MRs once my opened MRs are merged
02:54 anarsoul: now even without atan lowering the shader from #9323 is now compiled into 47 instructions vs 68 without ffma and new optimizations
03:11 anarsoul: down to 30 with atan instruction
07:00 anarsoul: and to 29 now :)
07:22 anarsoul: and from what I understand, combiner unit likely runs together with branch unit
07:23 anarsoul: branch unit cannot consume output of combiner (at least it doesn't work for me)
07:32 anarsoul: ugh, it's not only combiner. If branch is not in a separate instruction, it doesn't seem to work properly
13:59 enunes: anarsoul: a couple more days to go back
14:00 enunes: anarsoul: this https://www.origin.xilinx.com/support/documents/user_guides/ug1085-zynq-ultrascale-trm.pdf page 93 suggests that indeed the combine unit runs together with branch
17:23 sarbes: I've rebased my genxml MR, and improved some minor things.
17:26 sarbes: I guess I'll remove the "Draft" from the title.
17:26 sarbes: Is there some thing you'd like me to do?
18:08 anarsoul: can you share a link?
18:10 anarsoul: found it
18:11 anarsoul: let's see if it passes CI
18:35 anarsoul: LGTM. I'll take a closer look tonight, but from the first glance it seems to be pretty much complete
19:32 anarsoul: sarbes: don't forget to add either your or "lima project" copyright to the new files
19:34 sarbes: Ah, yes. I've wanted to ask about that, but forgot. I wasn't really comfortable updating the copyright of files I more or less copied.
19:52 anarsoul: you didn't copy them verbatim and you preserved original copyrights, it is OK to add yours (or "lima project" as we traditionally do for lima sources)
20:42 sarbes: Alright, I'll update the copyright of the newly added files.