14:36 MrCooper: mareko: FYI, bisected piglit cl failures (e.g. .../piglit/tests/cl/program/execute/builtin/atomic/atomic_add-local.cl) with rusticl on radeonsi on Bonaire to e4784104665d ("radeonsi: inline shader_info in si_shader_info, keep only what's used")
14:53 mareko: MrCooper_: I wonder is selector->stage is COMPUTE instead of KERNEL
14:54 mareko: *if
14:56 MrCooper: bingo
14:57 MrCooper: need anything else from the backtrace?
15:08 MrCooper: mareko: ^
16:05 mareko: or maybe it's the other way around: it's KERNEL and should be COMPUTE
16:14 MrCooper: mareko: it's COMPUTE when the assertion fails: cl-program-tester: ../src/gallium/drivers/radeonsi/si_compute.c:341: si_switch_compute_shader: Assertion `variable_shared_size == 0 || stage == MESA_SHADER_KERNEL' failed.
16:28 mareko: MrCooper: does it work if you change stage to MESA_SHADER_KERNEL in si_switch_compute_shader?
16:32 MrCooper: if (variable_shared_size > 0 && stage == MESA_SHADER_COMPUTE)
16:32 MrCooper: shader->selector->stage = stage = MESA_SHADER_KERNEL;
16:32 MrCooper: before the assert seems to do the trick
17:07 mareko: ok
17:10 mareko: the MR that should fix it is up