00:36 fdobridge: <a​irlied> don't they just work?
00:36 fdobridge: <a​irlied> (if you don't unplug them 😛
01:56 fdobridge: <a​irlied> oh it explodes on probe bleh
02:20 fdobridge: <a​irlied> @gfxstrand what compositor are you testing with?
02:20 fdobridge: <a​irlied> is it using nouveau GL or zink?
02:20 fdobridge: <g​fxstrand> Gnome shell. Nouveau GL. Standard F40 setup except for the kernel
03:12 fdobridge: <a​irlied> okay think I have it reproduced at least
03:15 fdobridge: <g​fxstrand> There's probably an easier way to repro than two GPUs but it would probably require something targeted.
05:50 fdobridge: <a​irlied> @gfxstrand https://paste.centos.org/view/raw/b7704acb helps avoid crashing, but gives me garbage tiled rendering
05:51 fdobridge: <a​irlied> it aligns with what radv does, since it assume VRAM will probably get pulled into GART so tells the kernel that in advance
06:28 fdobridge: <!​DodoNVK (she) 🇱🇹> https://gitlab.freedesktop.org/mesa/mesa/-/commit/8a0afd127602023ee74c0d901303f3366b62ae06 💸
08:37 fdobridge: <S​id> I'm so smart
08:37 fdobridge: <S​id> I built the kernel without the nouveau kernel module
08:42 fdobridge: <S​id> thankfully my pkgbuild does dirty builds too 😌
09:06 fdobridge: <!​DodoNVK (she) 🇱🇹> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29080 :triangle_nvk:
12:58 fdobridge: <g​fxstrand> Right... I'm a bit surprised the kernel didn't protect us a bit there. Still... Makes sense, I guess.
13:36 fdobridge: <k​arolherbst🐧🦀> anybody here still doing nouveau GL vs zink benchmarking?
13:37 fdobridge: <S​id> I was not, but I can if you want me to
13:38 fdobridge: <k​arolherbst🐧🦀> I'd be interested how much this MR closes the gap in games: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28641
13:38 fdobridge: <k​arolherbst🐧🦀> this MR is needed for silly gl driver internal reasons (command submissions is a mess)
13:38 fdobridge: <k​arolherbst🐧🦀> but it should improve performance in most games
13:41 fdobridge: <S​id> hm, mind if I test it out later? I'll have to re-build the entirety of my mesa package since it's a nouveau gallium patch
13:42 fdobridge: <k​arolherbst🐧🦀> yeah, it's not urgent
13:42 fdobridge: <k​arolherbst🐧🦀> *no
15:54 fdobridge: <g​fxstrand> Okay, I've got a better (IMO) version of that patch in my tree now and I'm CTSing it to see if I blew anything up too badly. Then I'll look into the tiling stuff.
15:58 fdobridge: <g​fxstrand> @karolherbst What's the difference between `NOUVEAU_GEM_DOMAIN_CPU` and `NOUVEAU_GEM_DOMAIN_GART`.
15:59 fdobridge: <g​fxstrand> @karolherbst What's the difference between `NOUVEAU_GEM_DOMAIN_CPU` and `NOUVEAU_GEM_DOMAIN_GART`? (edited)
16:07 fdobridge: <g​fxstrand> Oh, maybe that's used for ancient cache tracking. That would make sense.
16:08 fdobridge: <k​arolherbst🐧🦀> yeah, honestly no idea 🙂
16:08 fdobridge: <k​arolherbst🐧🦀> but yeah.. sounds like old GPU stuff
16:08 fdobridge: <k​arolherbst🐧🦀> we don't use `NOUVEAU_GEM_DOMAIN_CPU` at all in mesa though
16:25 fdobridge: <k​arolherbst🐧🦀> @gfxstrand maybe we should remove `NOUVEAU_GEM_DOMAIN_CPU` and see who complains?
16:25 fdobridge: <k​arolherbst🐧🦀> because I'm sure _nothing_ uses it
16:26 fdobridge: <k​arolherbst🐧🦀> mhhh
16:26 fdobridge: <k​arolherbst🐧🦀> though the kernel sets NOUVEAU_GEM_DOMAIN_CPU if neither VRAM nor GART are set
16:27 fdobridge: <k​arolherbst🐧🦀> anyway.. seems to be `TTM_PL_SYSTEM` vs `TTM_PL_TT`
16:31 fdobridge: <g​fxstrand> Ugh... This is all deeply cursed.
16:39 fdobridge: <g​fxstrand> The kernel query for BO info tells me what domain it's currently in, not what domains it was created to support.
16:39 fdobridge: <g​fxstrand> Useless.
16:46 fdobridge: <r​edsheep> I'm curious on the motivation for work like this, do you think there's actual hope for the nouveau GL driver getting improved to the point of being the driver of choice?
16:49 fdobridge: <k​arolherbst🐧🦀> well.. the author cared enough
16:50 fdobridge: <k​arolherbst🐧🦀> but maybe it's significant enough also with toolkits
16:50 fdobridge: <k​arolherbst🐧🦀> also
16:50 fdobridge: <k​arolherbst🐧🦀> not all GPUs will support vulkan
16:50 fdobridge: <r​edsheep> Yeah fair, I was just curious about your perspective
16:50 fdobridge: <k​arolherbst🐧🦀> and it's just moving code around
16:51 fdobridge: <k​arolherbst🐧🦀> however, if one would like start to refactor big chunks of the driver I'd simply suggest to start a new one as that's probably less time consuming to get proper performance
16:51 fdobridge: <m​ohamexiety> from an earlier MR from the author:
16:51 fdobridge: <m​ohamexiety> > I have been working on a new gallium driver on the side for nouveau [...]
16:51 fdobridge: <m​ohamexiety> so he's working on something new entirely for later
16:53 fdobridge: <r​edsheep> Oh I missed that line, that's exciting. It does seem more ideal in the long run than having good GL be limited to vulkan capable cards, and always going through more abstraction
18:36 fdobridge: <a​irlied> Yeah it's likely the bo pin on the import side should explode, but not sure taking out the compositor is a win
18:36 fdobridge: <a​irlied> The export side has no real idea
18:46 fdobridge: <!​DodoNVK (she) 🇱🇹> I'm not sure if the gallium driver even works with GSP (2D engine stuff had to be removed from NVK to fix the weird GR class errors)
18:54 fdobridge: <m​henning> The gallium driver is intended to work with gsp, and does work on my machine for at least basic stuff
19:09 fdobridge: <g​fxstrand> Yeah... I didn't think having the import fail if the BO doesn't support GART is actually that bad. That shouldn't cause the compositor to die. It'll probably pass the failure to the client.
19:15 fdobridge: <a​irlied> Actually I expect the pin works, but the client isn't prepared to render to system ram properly
19:15 fdobridge: <a​irlied> Hence faults
19:16 fdobridge: <a​irlied> Though I've no idea about kinds and sysmem, and there might be bugs in the bo migration
19:38 fdobridge: <!​DodoNVK (she) 🇱🇹> I definitely know some relatively old modifier changes basically broke it on my PRIME setup (I discovered those errors with only the NVIDIA GPU enabled in the compositor)
22:28 fdobridge: <g​fxstrand> I don't think it's the fault of the HW that tiling isn't working. I've got a theory I'm going to test quick...
22:35 fdobridge: <g​fxstrand> Yeah, so the tiling issues have nothing to do with this, actually.
22:36 fdobridge: <g​fxstrand> The tiling issues are because the old GL driver ignores modifiers and tries to pull bits out of the BO. If the BO is shared across GPUs, it appears to be a non-nouveau BO and therefore doesn't have a PTE kind or tile mode. If NVK renders and passes to NVK, it's fine.
22:38 fdobridge: <g​fxstrand> If, on the other hand, I use weston with NVK+Zink on one GPU (running with the X11 back-end on top of nouveau GL + GNOME) and gears on the other GPU, I get one correct frame and then a timeout.
22:38 fdobridge: <g​fxstrand> Which is cool because it gives us a reproducer for the timeout issue. 😄
22:38 fdobridge: <g​fxstrand> We've got a crucible test I can probably modify to make a nicer reproducer
23:02 fdobridge: <a​irlied> @gfxstrand I'm surprised shared across GPUs gives a non-nouveau bo
23:02 fdobridge: <a​irlied> I thought we just checked some function pointer whch I was pretty sure would be always the same
23:03 fdobridge: <g​fxstrand> hrm... Maybe?
23:04 fdobridge: <g​fxstrand> My conjecture there may be wrong
23:04 fdobridge: <g​fxstrand> It looks very much like nouveau GL treating it as linear, though. Not just a misc tiling problem.
23:14 fdobridge: <a​irlied> my thoughts were tiling/kind not being used after sysmem migration in some place, but need to add a bit of debug printfs to work that out
23:16 fdobridge: <g​fxstrand> But Turing+ ignores kind for color surfaces AFAIK
23:19 fdobridge: <g​fxstrand> IDK why running the experiment on Weston+Zink+NVK causes timeouts
23:22 fdobridge: <g​fxstrand> Weston+OGL causes timeouts, too.
23:22 fdobridge: <g​fxstrand> The timeout is in gears
23:29 fdobridge: <a​irlied> not device lost but timeouts?
23:37 fdobridge: <g​fxstrand> Well, the device gets lost because of a timeout
23:37 fdobridge: <g​fxstrand> But there's no other message in dmesg
23:37 fdobridge: <g​fxstrand> It smells very much like the EGL timeouts I've been seeing