04:25 fdobridge: <t​heevilskeleton> https://social.treehouse.systems/@TheEvilSkeleton/111401331877473698
04:25 fdobridge: <t​heevilskeleton> > Update 2: 24 hours later, I'm happy with where this is going. Here's an update:
04:25 fdobridge: <t​heevilskeleton> >
04:25 fdobridge: <t​heevilskeleton> > - Tables have clearer borders
04:25 fdobridge: <t​heevilskeleton> > - High contrast options for light and dark styles (painful)
04:25 fdobridge: <t​heevilskeleton> > - Drop shadow under the navigation bar
04:25 fdobridge: <t​heevilskeleton> > - Dark style is slightly lighter
04:25 fdobridge: <t​heevilskeleton> >
04:25 fdobridge: <t​heevilskeleton> > (Please forgive me for using Chrome. Firefox has a bug that gets stuck in high contrast after enabling it, which makes it really difficult and annoying to test)
04:25 fdobridge: <t​heevilskeleton> https://social.treehouse.systems/@TheEvilSkeleton/111401331877473698 (edited)
04:27 fdobridge: <c​langcat> Table looks a lot nicer
04:29 fdobridge: <t​heevilskeleton> Indeed
06:43 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> What could `[ 893.792720] nouveau 0000:59:00.0: fifo:PBDMA0: CTXNOTVALID chid:2` mean? :nouveau:
07:56 fdobridge: <k​arolherbst🐧🦀> userspace tries to submit to a context which doesn't exist (anymore)
08:03 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> https://gitlab.freedesktop.org/nouveau/mesa/-/issues/84
10:45 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> How easy would it be for nouveau to support dynamic MUX switching/Advanced Optimus? :nouveau:
10:49 fdobridge: <k​arolherbst🐧🦀> easy
10:49 fdobridge: <k​arolherbst🐧🦀> the pain is on the userspace side
10:50 fdobridge: <k​arolherbst🐧🦀> from the kernel perspective it's simple: you disable `eDP1` and enable `eDP2` and tell the kernel to flip the mux, done
10:50 fdobridge: <k​arolherbst🐧🦀> it's just userspace being broken
10:50 fdobridge: <k​arolherbst🐧🦀> like
10:50 fdobridge: <k​arolherbst🐧🦀> completely
10:50 fdobridge: <k​arolherbst🐧🦀> every major compositor needs a rewrite
10:50 fdobridge: <k​arolherbst🐧🦀> soooooo....
12:30 fdobridge: <m​ohamexiety> wait it doesn't work even with prop driver? 😮
12:31 fdobridge: <k​arolherbst🐧🦀> how could it?
12:31 fdobridge: <k​arolherbst🐧🦀> nvidia wrote a proposal though to add more KMS properties for it
12:32 fdobridge: <k​arolherbst🐧🦀> but the issue is really how compositors are handling their compositing contexts
12:32 fdobridge: <k​arolherbst🐧🦀> by default they start do the compositing on the iGPU
12:32 fdobridge: <k​arolherbst🐧🦀> and if you disable all displays on your iGPU and have some on the dGPU, they still compose on the iGPU
12:32 fdobridge: <k​arolherbst🐧🦀> making it all very pointless to switch
12:33 fdobridge: <k​arolherbst🐧🦀> compositors really have to use one rendering context per display/gpu
12:33 fdobridge: <k​arolherbst🐧🦀> and move things between them
12:33 fdobridge: <k​arolherbst🐧🦀> so that if you move your desktop from an iGPU to a dGPU display, that you also move the compositing from the iGPU to the dGPU
12:34 fdobridge: <k​arolherbst🐧🦀> and then you also need working PSR in order to deal with flickering while migrating
12:34 fdobridge: <k​arolherbst🐧🦀> but that's part of the KMS proposal nvidia made
12:34 fdobridge: <k​arolherbst🐧🦀> but for now, moving to the other eDP display would decrease performance
12:35 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Is it possible to make them compose on both iGPU and dGPU (across different outputs)?
12:35 fdobridge: <m​ohamexiety> I see. I didn't know how it worked here. thanks!
12:35 fdobridge: <k​arolherbst🐧🦀> well.. yes
12:35 fdobridge: <k​arolherbst🐧🦀> they just have to rework their code
12:35 fdobridge: <k​arolherbst🐧🦀> could lead to a big rework
12:35 fdobridge: <k​arolherbst🐧🦀> could be small
12:35 fdobridge: <k​arolherbst🐧🦀> don't know
12:35 bencoh: I think I remember reading about some compositors starting to implement some kind of gpu hotplug support to tackle that issue
12:35 fdobridge: <k​arolherbst🐧🦀> hotplugging is unrelated
12:35 bencoh: (wayland compositors)
12:36 fdobridge: <k​arolherbst🐧🦀> it has to account for the fact that the GPU _might_ go away, sure
12:36 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I wonder what Windows does when you connect a display that's wired to the dGPU while iGPU is being used for the internal display
12:36 fdobridge: <k​arolherbst🐧🦀> but hotplugging isn't the reason it's needed
12:36 fdobridge: <k​arolherbst🐧🦀> it just makes it harder to get right
12:36 fdobridge: <p​ac85> They only have to export and import the dmabufs for surfaces right?
12:36 fdobridge: <k​arolherbst🐧🦀> well
12:36 fdobridge: <p​ac85> What else would they share among contexts
12:37 fdobridge: <k​arolherbst🐧🦀> from an API pov it's really just a robustness context and that context gets killed
12:37 fdobridge: <k​arolherbst🐧🦀> applications could move from one to the other GPU
12:37 fdobridge: <k​arolherbst🐧🦀> apple did/does this via rendering context resets
12:37 fdobridge: <k​arolherbst🐧🦀> similar to robustness
12:38 fdobridge: <k​arolherbst🐧🦀> so if they want to migrate an app, they kill the context and the new one gets allocated on the other GPU
12:38 fdobridge: <p​ac85> How do most apps not die
12:38 fdobridge: <k​arolherbst🐧🦀> they have to opt in
12:38 fdobridge: <p​ac85> Uh makes sense
12:38 fdobridge: <k​arolherbst🐧🦀> otherwise they always run on the dGPU
12:38 fdobridge: <k​arolherbst🐧🦀> soooo
12:38 fdobridge: <k​arolherbst🐧🦀> apps are kinda forced to support it
12:38 fdobridge: <k​arolherbst🐧🦀> and toolkits handle it anyway
12:38 fdobridge: <k​arolherbst🐧🦀> well.. apples at least
12:39 fdobridge: <k​arolherbst🐧🦀> but yeah.. they've implemented it like 8? years ago
12:39 fdobridge: <p​ac85> ~~ having more than one process accessing the gpu and displaying stuff fullscreen like in the voodoo was a mistake ~~
12:39 fdobridge: <k​arolherbst🐧🦀> and apps started on a dGPU display were rendered on the dGPU
12:40 fdobridge: <k​arolherbst🐧🦀> and migrated to the iGPU once you move the window over
12:40 fdobridge: <k​arolherbst🐧🦀> or disconnected the display
12:40 fdobridge: <k​arolherbst🐧🦀> or something
12:40 fdobridge: <k​arolherbst🐧🦀> appls could prevent the dGPU from shutting down (e.g. games)
12:40 fdobridge: <p​ac85> Uhm
12:40 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I think they had advanced Optimus since 2010
12:40 fdobridge: <k​arolherbst🐧🦀> there was even this menubar widget to configure it 😄
12:41 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> https://youtu.be/8L77ARC4ENI?t=28
12:41 fdobridge: <k​arolherbst🐧🦀> https://gfx.io/switching.html
12:42 fdobridge: <k​arolherbst🐧🦀> guess it's older
12:42 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Here's it going wrong because of a broken dGPU
12:42 fdobridge: <k​arolherbst🐧🦀> but on older macbooks you had to reboot or restart your session
12:42 fdobridge: <k​arolherbst🐧🦀> so they gradually moved to a dynamic mux thing
12:42 fdobridge: <k​arolherbst🐧🦀> but yeah....
12:43 fdobridge: <k​arolherbst🐧🦀> we kinda have to fix this :ferrisUpsideDown:
12:43 fdobridge: <k​arolherbst🐧🦀> and it's going to be a lot of work
12:43 fdobridge: <k​arolherbst🐧🦀> I think gamescope is doing it properly
12:43 fdobridge: <k​arolherbst🐧🦀> at least the compositing part
12:43 fdobridge: <p​ac85> Uh
12:44 fdobridge: <k​arolherbst🐧🦀> Well.. that's at least how I understood Joshie on that matter
12:45 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Gamescope's Wayscope support is poor though
12:46 fdobridge: <k​arolherbst🐧🦀> yeah... might be, dunno 🙂
12:48 fdobridge: <p​ac85> Wayscope?
12:50 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Wayland support in gamescope
13:41 fdobridge: <t​heevilskeleton> One of my friends made the fd.o logo adapt to dark style 👌
13:41 fdobridge: <t​heevilskeleton> https://cdn.discordapp.com/attachments/1034184951790305330/1173618753792135188/2023-11-13_08-41-07.mp4?ex=65649ca3&is=655227a3&hm=075ed3afda94cb7039aa15621e5d8343e24d3c99245a1e741159fd4eb447a3b0&
13:52 fdobridge: <k​arolherbst🐧🦀> ohh, the test :ferrisUpsideDown:
13:52 fdobridge: <k​arolherbst🐧🦀> for 10 seconds I was like "what's the difference?"
13:52 fdobridge: <t​heevilskeleton> lmao
13:53 fdobridge: <p​ac85> The text?
13:53 fdobridge: <t​heevilskeleton> Yeah, that's what he means
13:54 fdobridge: <k​arolherbst🐧🦀> ohh, the text :ferrisUpsideDown: (edited)
14:44 fdobridge: <d​adschoorse> ffmaz/fmulz in NAK when?
14:48 fdobridge: <g​fxstrand> Those are the ones with 0*inf=0 behavior?
14:49 fdobridge: <g​fxstrand> I think that's just a bit on the instruction so shouldn't be too hard to wire up. Are there tests somewhere?
14:50 fdobridge: <d​adschoorse> 0*anything (including inf and NaN)
14:50 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I remember DXVK enabling those instructions just for NVK (so I guess it's codegen-exclusive)
14:51 fdobridge: <d​adschoorse> I don't think there are tests given that it's produced by an algebraic opt and not an extension
14:55 fdobridge: <g​fxstrand> Even if it's just an amber file that has a bit of SPIR-V and tests a handful of cases so I know it's working properly, I think that's enough.
14:58 fdobridge: <p​endingchaos> vkrunner fmulz test: https://pastebin.com/raw/2QzTzX5g
15:11 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Does Vulkan CTS have any tests for storage on 3D images (which is what triggers an assert in NVK)? :triangle_nvk:
15:14 fdobridge: <g​fxstrand> Possibly but we may not have enabled the feature.
15:14 fdobridge: <g​fxstrand> Though I thought I did....
15:15 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> You're still doing the `1 << 11` assert in the NAK branch
15:16 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Which trips on the Overwatch 2 menu screen for some reason (if I remove it the characters have weird lighting issues on both codegen and NAK)
15:17 fdobridge: <g​fxstrand> RIght, yeah. That has nothing to do with 3d
15:17 fdobridge: <g​fxstrand> I'll be getting rid of that today, I think.
15:18 fdobridge: <g​fxstrand> That's one of my planned post-merge activities.
15:18 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> The comment mentions storage on 3D images (so maybe there was another assert that was removed?)
15:18 fdobridge: <g​fxstrand> Quite possibly. I wired up a couple more extensions in that area during XDC.
15:19 fdobridge: <g​fxstrand> Oh, right... I see what you mean now.
15:19 fdobridge: <g​fxstrand> No, the assertion is there because of codegen's batshit handling of 3D storage images. NAK doesn't do that nonsense so we can just use the image handles as-is.
15:19 fdobridge: <g​fxstrand> It's not because 3D is unimplemented it's just crazy
15:21 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I wonder what could explain this glitchy rendering on NAK then: https://discord.com/channels/1033216351990456371/1034184951790305330/1169302273000755371
15:22 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I'll retest OW2 with the latest NAK code to see if that issue is still there
15:29 fdobridge: <g​fxstrand> So, I'm not actually sure which bits I want to set to get fmulz...
15:29 fdobridge: <g​fxstrand> I don't think we want it to flush denorms
15:29 fdobridge: <k​arolherbst🐧🦀> I think that's implicit
15:29 fdobridge: <k​arolherbst🐧🦀> ehh wait
15:29 fdobridge: <k​arolherbst🐧🦀> might not be
15:29 fdobridge: <k​arolherbst🐧🦀> yeah, seems like maxwell has two bits here
15:29 fdobridge: <k​arolherbst🐧🦀> nvm me
15:30 fdobridge: <k​arolherbst🐧🦀> mhhh
15:30 fdobridge: <k​arolherbst🐧🦀> though.. `.FMZ` does imply `.FTZ`
15:31 fdobridge: <g​fxstrand> Wait, FMZ implies FTZ?
15:31 fdobridge: <g​fxstrand> Ugh.
15:31 fdobridge: <k​arolherbst🐧🦀> at least in the assembler 🙂
15:31 fdobridge: <k​arolherbst🐧🦀> not sure if the hardware thinks the same
15:32 fdobridge: <k​arolherbst🐧🦀> but it probably does
15:32 fdobridge: <g​fxstrand> I guess I can add more cases to the vkrunner test
15:39 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> It still is
15:39 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> https://cdn.discordapp.com/attachments/1034184951790305330/1173648370775117934/Screenshot_20231113_173825.png?ex=6564b838&is=65524338&hm=96ad944326f1190221b344c5e1706aabe65221810269fd857a16185716a54413&
15:40 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> But the performance is quite something 🚀
15:40 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> https://cdn.discordapp.com/attachments/1034184951790305330/1173648626736705617/Screenshot_20231113_173411.png?ex=6564b875&is=65524375&hm=8b0b1394d3668729781bfd8ae6f42d025ceed166dbfd16820953085e9e23729f&
15:41 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> This is the only error that appears: `[154260.407508] nouveau 0000:01:00.0: gr: DATA_ERROR 00000004 [INVALID_VALUE] ch 4 [00ffa3f000 Overwatch.exe[158385]] subc 3 class 902d mthd 0224 data eaf70f40`
15:41 fdobridge: <k​arolherbst🐧🦀> mhhh
15:42 fdobridge: <k​arolherbst🐧🦀> let's see
15:42 fdobridge: <g​fxstrand> Yup, it flushes... Ugh. 😩
15:42 fdobridge: <k​arolherbst🐧🦀> so.. offset is `eaf70f40`
15:42 fdobridge: <k​arolherbst🐧🦀> it might be that the offset is signed 🙃
15:42 fdobridge: <g​fxstrand> So, yeah, we can't flip on the optimization unless we set FTZ on everything.
15:42 fdobridge: <k​arolherbst🐧🦀> ehh wait
15:43 fdobridge: <k​arolherbst🐧🦀> it's a 64 bit address
15:43 fdobridge: <k​arolherbst🐧🦀> the heck...
15:43 fdobridge: <k​arolherbst🐧🦀> ohh
15:43 fdobridge: <k​arolherbst🐧🦀> alignment
15:43 fdobridge: <k​arolherbst🐧🦀> yeah.. so something is up with the alignment I guess because it can't really be anything else here
15:47 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Is there a way to figure out where the alignment is wrong? Could push_dump logs help?
15:48 fdobridge: <k​arolherbst🐧🦀> mhhhh
15:48 fdobridge: <k​arolherbst🐧🦀> I think we need something new
15:49 fdobridge: <k​arolherbst🐧🦀> @gfxstrand dakr: I think we need a small addition to the UAPI: add a flag so that a synced command submission also returns an error to userspace if a non fatal error is hit, like `INVALID_VALUE` ones, so we can easier identify and debug submissions with slightly faulty stuff
15:49 fdobridge: <g​fxstrand> Yeah, that's not a bad idea.
15:55 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I'm just looking at tinier details because incorrect rendering in Overwatch 2 is kind of annoying me :triangle_nvk:
15:57 fdobridge: <d​adschoorse> that is strange, I don't see how it makes the hw simpler 🐸
15:57 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> That Overwatch 2 issue and weird GR class errors when running SuperTuxKart OpenGL or DXVK v1.10+ games with GSP are probably my top 2 nouveau annoyances right now :nouveau:
16:00 fdobridge: <d​adschoorse> flushing by default is what amd does. d3d11/12 flushes 32bit denorms by default too.
16:01 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> But NAK suddenly became performant thanks to one MR that mhennning made so that's very good NVK progress (and it definitely should be merged 💪)
16:04 fdobridge: <g​fxstrand> Does DXVK enforce that via float controls?
16:04 fdobridge: <d​adschoorse> d3d11 dxvk does
16:06 fdobridge: <d​adschoorse> just to be clear: radv's default is preserve 16bit/64bit denorms, 32bit ftz. d3d is the same
16:07 fdobridge: <g​fxstrand> Right. If the CUDA docs are to be believed, FTZ only works on 32-bit anyway
16:07 dakr: karolherbst: Makes sense. Need to find a way to properly propagate those errors up and connect them to the corresponding job though.
16:07 fdobridge: <g​fxstrand> So I think we can get the optimization and behavior we want, we might just need to make it float-controls-aware somehow.
16:07 fdobridge: <k​arolherbst🐧🦀> I think it's fair to not use `.FTZ` when 32 bit denorms are to be preserved explicitly
16:08 fdobridge: <k​arolherbst🐧🦀> ehh
16:08 fdobridge: <k​arolherbst🐧🦀> `.FMZ`
16:08 fdobridge: <k​arolherbst🐧🦀> if neither is specified, does it have to be consistent within a shader invocation?
16:09 karolherbst: dakr: yeah.. not quite sure how easy that is. I think there are some global error masks for it. Worst case it's a context global config.
16:09 fdobridge: <g​fxstrand> Without float controls, things are loosy-goosey enough that we can probably do that but I'd rather not.
16:09 karolherbst: and uhhh.. we kinda have to pipe that through
16:09 karolherbst: or just set it on the first submission
16:11 fdobridge: <d​adschoorse> fwiw, d3d9 dxvk does not use any float control settings, and that's the use case for fmulz
16:13 dakr: karolherbst: I think it could be quite tricky. The only thing I can think of at a first glance is trying to fetch the sequence number of the fence context, but that might be racy..
16:13 karolherbst: yeah.....
16:14 karolherbst: sooo
16:14 karolherbst: maybe we can whack it from userspace
16:14 karolherbst: _if_ we can set the error mask of the faults I think..
16:14 karolherbst: but I never really understood what bit does what and it kinda depends on the GPU arch
16:15 karolherbst: but "make all errors fatal" is just enabling/disabling all bits, so should be fine
16:15 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> You've already whacked MMIO registers from userspace so that isn't new to you
16:15 karolherbst: that's why I had the idea :D
16:15 karolherbst: but not sure which MMIO reg to poke...
16:16 karolherbst: I know that nvgpu added some related regs to their list of allowed ones
16:39 fdobridge: <g​fxstrand> I guess if we make FTZ the default for 32-bit, we could still do it.
16:44 fdobridge: <g​fxstrand> Annoying that nvidia unnecessarily tied the two flags, though.
16:45 fdobridge: <m​henning> fwiw, codegen has FTZ as the default for non-compute shaders. although I'm not entirely sure why - I'm not aware of us having a perf penalty for handling denorms
16:46 fdobridge: <g​fxstrand> Probably because that's what nvidia does. 🤷🏻‍♀️
16:46 fdobridge: <g​fxstrand> I mean, I haven't actually verified that that's what they do but they probably do
16:47 fdobridge: <k​arolherbst🐧🦀> just ignore the float controls for `fmulz` :ferrisCluelesser:
16:47 fdobridge: <k​arolherbst🐧🦀> nobody is ever going to file a bug for it anyway
16:48 fdobridge: <g​fxstrand> Nope. I'm not going to make a buggy compiler and hope no one notices.
16:48 fdobridge: <k​arolherbst🐧🦀> is it buggy if it's working as expected?
16:48 fdobridge: <k​arolherbst🐧🦀> 😛
16:49 fdobridge: <m​henning> yeah, randomly changing denorm behavior is pretty terrible
16:49 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Or a slow one 🐢
16:51 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Hopefully MR !53 will be merged soon (if it doesn't cause CTS regressions) :ferris:
17:03 fdobridge: <g​fxstrand> So if d3d9 is the only thing that cares about fmulz and if it wants denorm flushing anyway... Maybe we can make `nir_op_fmulz` flush as its canonical behavior?
17:12 fdobridge: <m​henning> The thing is, we currently generate fmulz from pattern matching in opt_algebraic, and I don't know that we can tell that we're running under d3d9 and want flushing
17:15 fdobridge: <g​fxstrand> We can with enough hackery
17:15 fdobridge: <g​fxstrand> It already checks that SignedZeroPreserve isn't set
17:15 fdobridge: <g​fxstrand> We can make the check a bit smarter
18:42 fdobridge: <d​adschoorse> that would be painful for amd because fmulz uses the global mode there
18:54 fdobridge: <g​fxstrand> Merged. Thanks!
18:54 fdobridge: <g​fxstrand> Oh, well that's annoying.
18:55 fdobridge: <g​fxstrand> I mean, our "global mode" is going to be "add a flag to all the instructions" it's just that FMZ implies FTZ so we can't do it when the global mode isn't the right thing.
18:55 fdobridge: <g​fxstrand> I'll think some more about it.
18:56 fdobridge: <g​fxstrand> We can finagle the flags somehow. I just have to figure out how. 🙃
19:08 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Typo moment: `nouveau: Add initial headers and meson for the new compoiler`
19:11 fdobridge: <e​sdrastarsis> Codegen runs the Vulkan Scene example (Sasha Willems) at 75 fps and NAK runs at 1100 fps 😱
19:11 fdobridge: <e​sdrastarsis> Before it ran at around 20 fps
19:11 fdobridge: <e​sdrastarsis> Before it ran at around 20 fps iirc (edited)
19:13 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> This is what I observed too (so it isn't new for me)
19:14 fdobridge: <k​arolherbst🐧🦀> weird 😄
20:18 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Same method as Overwatch 2: `[171236.420478] nouveau 0000:01:00.0: gr: DATA_ERROR 00000004 [INVALID_VALUE] ch 2 [00ffe41000 gta3.exe[205065]] subc 3 class 902d mthd 0224 data ed537540`
20:18 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I'm not sure that's how the game is supposed to look 🐸
20:18 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> https://cdn.discordapp.com/attachments/1034184951790305330/1173718635169206332/Screenshot_20231113_221549.png?ex=6564f9a9&is=655284a9&hm=7527dcdd04d320802890d6e548641ca8484ba0149ec1c9939eef6a159a40536d&
20:25 fdobridge: <c​langcat> I haven't played gta3 sine I was a kid but I think it looks about normal I don't remember so much fog but that might just be cause of the mission.
20:28 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> This definitely isn't normal though (I played this save file a lot while testing WineD3D and various other stuff)
20:28 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> https://cdn.discordapp.com/attachments/1034184951790305330/1173721031123402883/Screenshot_20231113_222624.png?ex=6564fbe4&is=655286e4&hm=35c55a38b2efc0554c6ffbbe8702e682dfbaff88640c173b2a2f83418ca45ec6&
20:29 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I wonder if it's related to the fmulz thing 🤔
20:30 fdobridge: <m​henning> The ability to use fmulz is just an optimization - we should still produce correct output without it
20:35 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> NFS Most Wanted 2012 has big gains with NAK (previously it was a massive slideshow with skipping audio at 1080p highest settings without SSAA and AO)
20:35 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> https://cdn.discordapp.com/attachments/1034184951790305330/1173722899438383215/Screenshot_20231113_223240.png?ex=6564fda1&is=655288a1&hm=c5ece1bcbd7b81cab19a37733638dd8e50d6d9842b3ca5b9071e3e0b0bfd8749&
20:46 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Here's codegen for reference
20:46 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> https://cdn.discordapp.com/attachments/1034184951790305330/1173725703989117059/Screenshot_20231113_224617.png?ex=6565003e&is=65528b3e&hm=ac937f164dcf5ef3597ab7cb8843c12e1589dbcd4221e0a1a51aeb840529d6da&
20:48 fdobridge: <k​arolherbst🐧🦀> I wonder if scheduling is trashed or something...
20:48 fdobridge: <k​arolherbst🐧🦀> ohh
20:48 fdobridge: <k​arolherbst🐧🦀> codegen is faster
20:48 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I mean there's a weird fog issue on NAK
20:50 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> NAK is now always faster than codegen BTW
20:50 fdobridge: <k​arolherbst🐧🦀> ahh
20:56 fdobridge: <g​fxstrand> It's the UBO caching settings.
20:57 fdobridge: <g​fxstrand> It'll get even faster once we get bindless UBOs hooked up and maybe a little cbuf lowering for older gens.
20:59 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> This fog issue definitely happens inside a pixel shader because it only happens with `NVK_USE_NAK=fs`
21:08 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Should I send the SPIR-V shaders dumped by DXVK? 🤔
21:18 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Here's `NAK_DEBUG=print NVK_USE_NAK=fs` :ferris:
21:18 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> https://cdn.discordapp.com/attachments/1034184951790305330/1173733772051628062/gta3_nak.log?ex=656507c2&is=655292c2&hm=f13d1250a55cc91f95583504c196175bec7ea27d9d063070eb68a5d18653d299&
21:24 fdobridge: <e​sdrastarsis> what about zcull?
21:36 fdobridge: <m​henning> Do you think you could get a renderdoc vulkan trace? I might have time to hack at this later
21:36 fdobridge: <m​henning> @asdqueerfromeu ^
21:38 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I haven't tried RenderDoc before (but I might try to make a trace with it later)
22:13 fdobridge: <g​fxstrand> https://tenor.com/view/mario-movie-peach-here-we-go-mario-kart-lets-go-gif-4834955107827977209
22:23 fdobridge: <e​sdrastarsis> In Rust we trust
22:56 fdobridge: <e​sdrastarsis> I think NVK has improved a little...
22:56 fdobridge: <e​sdrastarsis> https://cdn.discordapp.com/attachments/1034184951790305330/1173758280082923571/13-11-23-195405-SCREEN.jpg?ex=65651e95&is=6552a995&hm=cf2cd99a1d9bcc53b8c874ef996f81ff4d5703d9aa4dc067e5bbcba818aab677&
22:57 fdobridge: <k​arolherbst🐧🦀> :ferrisBongo:
23:05 fdobridge: <m​ohamexiety> wow, 67 FPS
23:05 fdobridge: <m​ohamexiety> that's actually very playable 😮
23:05 fdobridge:<m​ohamexiety> nice!
23:12 fdobridge: <e​sdrastarsis> lol
23:12 fdobridge: <e​sdrastarsis> https://cdn.discordapp.com/attachments/1034184951790305330/1173762250306228284/13-11-23-201154-SCREEN.jpg?ex=65652247&is=6552ad47&hm=e59e6383a7c47d8ad17fa1d0fd6ed2c3defbd92df29efd5501be78f027ca5334&
23:27 fdobridge: <g​fxstrand> Ooh, alpha blending bug from the looks of it
23:27 fdobridge: <g​fxstrand> Could be the same issue as the other game, TBH.
23:28 fdobridge: <g​fxstrand> Go ahead and file a bug. As long as you're on Turing+, I don't mind seeing app bugs now. RenderDoc traces exhibiting the bug would be preferred.
23:28 fdobridge: <g​fxstrand> Hrm... I have an idea, actually.
23:29 fdobridge: <g​fxstrand> Does it do that with codegen?
23:33 fdobridge: <e​sdrastarsis> yes
23:33 fdobridge: <e​sdrastarsis> https://cdn.discordapp.com/attachments/1034184951790305330/1173767645582065704/13-11-23-203258-SCREEN.jpg?ex=6565274e&is=6552b24e&hm=3b95e84f5b9978683ab437da681f597e49a673125d222b4897bed203bbb4e8be&
23:35 fdobridge: <k​arolherbst🐧🦀> I kinda wonder why codegen is _that_ slow, or maybe NAK just have the better pipeline.. does NAK use actual UBOs yet?
23:36 fdobridge: <k​arolherbst🐧🦀> looks like something isn't transparent even though it should be
23:38 fdobridge: <g​fxstrand> Nope but NAK does now use the Constant caching mode for UBOs
23:42 fdobridge: <g​fxstrand> Really, like 70% of our perf delta is just UBOs.
23:42 fdobridge: <k​arolherbst🐧🦀> ahh
23:42 fdobridge: <g​fxstrand> I know what needs to be done but it requires even more compiler work. We'll get there.
23:42 fdobridge: <k​arolherbst🐧🦀> so just the `.CONSTANT` thing?
23:42 fdobridge: <g​fxstrand> Yup
23:42 fdobridge: <k​arolherbst🐧🦀> impressive
23:42 fdobridge: <k​arolherbst🐧🦀> but well.. caches are there for a reason 😄
23:43 fdobridge: <k​arolherbst🐧🦀> I'll guess you'll start with bindless UBOs first?
23:45 fdobridge: <g​fxstrand> Yeah
23:45 fdobridge: <g​fxstrand> That's the plan.
23:46 fdobridge: <g​fxstrand> Though using `.CONSTANT` massively improves things in the mean time.
23:46 fdobridge: <g​fxstrand> And we'll eventually want something better than `.CONSTANT` for pre-Turing but I want to get UBOs working first so I know how it'll fit in better.
23:47 fdobridge: <k​arolherbst🐧🦀> I'm surprised it's that much of a difference already
23:48 fdobridge: <k​arolherbst🐧🦀> but I think HdkR also said, that on newer hardware .CONSTANT is entirely special
23:51 HdkR: It's good stuff
23:51 fdobridge: <g​fxstrand> Yeah, I wouldn't be surprised if .CONSTANT on Turing+ isn't pretty similar to a bindless UBO. The difference being that a bindless UBO can be referenced from an ALU op directly whereas .CONSTANT is a separate load op.
23:52 fdobridge: <k​arolherbst🐧🦀> the caching will also work differently
23:52 fdobridge: <k​arolherbst🐧🦀> the bindless ubo address contains the size
23:52 HdkR: yea, encoding directly in the instruction is a small win still
23:52 fdobridge: <k​arolherbst🐧🦀> so the hardware could actually pull more into the cache already
23:52 fdobridge: <k​arolherbst🐧🦀> or less...
23:52 fdobridge: <k​arolherbst🐧🦀> depending on things I guess
23:54 fdobridge: <g​fxstrand> The hardware is probably going to be pulling either 4K pages or 64B lines.
23:54 fdobridge: <g​fxstrand> Or maybe a different line size. IDK. I wouldn't be surprised if NV GPUs don't have like a 384B line or something odd like that.
23:55 fdobridge: <g​fxstrand> In any case, as long as it's no more than a page, it won't fault regardless of bounds checking.
23:55 fdobridge: <k​arolherbst🐧🦀> yeah... something something
23:55 fdobridge: <g​fxstrand> for bound UBOs, I think they DMA into the cache up-front or something crazy like that.
23:56 fdobridge: <k​arolherbst🐧🦀> yeah, they should
23:56 fdobridge: <k​arolherbst🐧🦀> otherwise it would be kinda pointless