00:31 fdobridge: <m​henning> Oh, I compile with `-D_GLIBCXX_ASSERTIONS=1 -D_FORTIFY_SOURCE=2` . without that you might read out of bounds instead of asserting
03:01 fdobridge: <a​irlied> https://gitlab.freedesktop.org/nouveau/mesa/-/merge_requests/245 this fixes a bunch of gpu crashes I'm seeting in a cts run
03:36 fdobridge: <g​fxstrand> Sure. Looks good.
03:39 fdobridge: <g​fxstrand> Which hardware?
03:41 fdobridge: <a​irlied> ampere, but I seen the same crashes on turing
03:41 fdobridge: <a​irlied> actually maybe I didn't test turing
03:42 fdobridge: <a​irlied> also might be on newer CTS
03:43 fdobridge: <a​irlied> @gfxstrand have you written down anywhere what is needed for 3d depth/stencil?
03:44 fdobridge: <g​fxstrand> No
03:44 fdobridge: <g​fxstrand> It's not just 3D depth/stencil, it's 3D rendering in general.
03:45 fdobridge: <g​fxstrand> Hrm... maybe it is just 3D depth/stencil.
03:45 fdobridge: <g​fxstrand> Yeah, I'm not sure quite what the problem is there. Worst case, we can just force `tiling.z_log2 = 0` for 3D depth/stencil and treat them as 2D arrays.
03:46 fdobridge: <g​fxstrand> Let me play with that quick.
03:51 fdobridge: <a​irlied> oh is it just clears might need a loop or something?
04:02 fdobridge: <a​irlied> nvidia use yet another mme macros for ds clears
04:02 fdobridge: <a​irlied> oh no it's using a compute shader
04:03 fdobridge: <a​irlied> okay it seems like they clear an array texture then dma it over each layer of the depth image
04:07 fdobridge: <g​fxstrand> Okay, I've got a patch
04:07 fdobridge: <g​fxstrand> If we find an app that REALLY cares about 3D depth/stencil perf, we can deal with that when the time comes.
04:08 fdobridge: <g​fxstrand> But, like, it's depth/stencil. If you're not binding it as a depth/stencil attachment what are you doing?
04:10 fdobridge: <g​fxstrand> I pushed it. If it introduces regressions, I'll fix them in the morning.
04:10 fdobridge: <a​irlied> yeah nvidia really don't seem to care, it looks like a complete second surface is allocated
04:10 fdobridge: <g​fxstrand> Yeah, I just set the array-compatible flag
04:10 fdobridge: <g​fxstrand> Because meh
04:11 fdobridge: <g​fxstrand> NIL makes this shit soooo easy. 😄
04:11 fdobridge: <g​fxstrand> NIL makes this shit soooo easy. 😍 (edited)
04:12 fdobridge: <g​fxstrand> Crazy. It's been running for almost 5m and nothing has crashed. 🤯
04:14 fdobridge: <g​fxstrand> IDK why that took me so long to fix. 🙃
04:14 fdobridge: <g​fxstrand> Okay, I'm going to bed. I'll fix any regressions from my patch in the morning.
05:25 fdobridge: <g​fxstrand> `Pass: 368653, Fail: 1970, Crash: 14, Skip: 1616585, Flake: 153, Duration: 37:03`
09:29 fdobridge: <k​arolherbst🐧🦀> @gfxstrand your MS patch doesn't seem to change a thing on 2nd gen Kepler at least 🙃 But it's all busted anyway and it smells like something is really broken with indirect handles and MS in general there
09:30 fdobridge: <k​arolherbst🐧🦀> running all tests with `multisample` in the name though
09:31 fdobridge: <k​arolherbst🐧🦀> maybe I should add `resolve` as well
09:58 fdobridge: <k​arolherbst🐧🦀> ahh yeah, that's what I actually wanted to look at before getting distracted by everything else 🙃
09:59 fdobridge: <k​arolherbst🐧🦀> anyway, we can't emit a 0 there
09:59 fdobridge: <k​arolherbst🐧🦀> I think
10:00 fdobridge: <k​arolherbst🐧🦀> anyway yeah.. that was mostly the main source of crashes also on pre turing
15:37 fdobridge: <g​fxstrand> Updated my CTS branch and there are more fails. 😿
15:37 fdobridge: <g​fxstrand> ```
15:37 fdobridge: <g​fxstrand> Pass: 376335, Fail: 4205, Crash: 12, Skip: 1752648, Flake: 170, Duration: 45:22
15:37 fdobridge: <g​fxstrand> ```
15:37 fdobridge: <g​fxstrand> Also, 8 more minutes. 😭
18:36 fdobridge:<g​fxstrand> wonders if there's something wrong with the VS in this test
19:13 fdobridge: <g​fxstrand> Woo! Dirty tracking bug. That should fix most of the new fails. \o/
19:50 fdobridge: <a​irlied> You might want to pull the clip fix out if my clip enable MR. It fixes a few fails
19:53 fdobridge: <g​fxstrand> kk
19:54 fdobridge: <g​fxstrand> `Pass: 378590, Fail: 1990, Crash: 12, Skip: 1752648, Flake: 130, Duration: 38:13`
19:54 fdobridge: <g​fxstrand> Much better. 😁
20:00 fdobridge: <k​arolherbst🐧🦀> I wonder how well pre Turing now is with that ts stuff fixed
20:03 fdobridge: <g​fxstrand> I'm doing another Turing run now with the latest MSAA TXQ patch and @airlied's point clip fix.
20:03 fdobridge: <g​fxstrand> I can attempt a maxwell run once that's done
20:04 fdobridge: <k​arolherbst🐧🦀> is there anything in vulkan which allows a shader to get the sample position? Mostly curious
20:06 fdobridge: <g​fxstrand> `gl_SamplePos`
20:07 fdobridge: <k​arolherbst🐧🦀> ohh
20:07 fdobridge: <k​arolherbst🐧🦀> mhhh
20:07 fdobridge: <k​arolherbst🐧🦀> sample shading, right...
20:07 fdobridge: <g​fxstrand> which we lower to `fract(gl_FragCoord)`
20:09 fdobridge: <k​arolherbst🐧🦀> the hardware returns the position in 4.12 format
20:09 fdobridge: <k​arolherbst🐧🦀> packed
20:12 fdobridge: <g​fxstrand> ?
20:12 fdobridge: <k​arolherbst🐧🦀> two fixed point 4.12 values packed inside a 32 bit register
20:13 fdobridge: <g​fxstrand> @airlied Is !242 passing everything?
20:13 fdobridge: <a​irlied> Yeah it didn't make things worse, though there is some outstanding failure in the area
20:14 fdobridge: <g​fxstrand> Oh, sure. We could probably use that instead but codegen was doing something really funky with pushing the whole sample position table as a cbuf and I just gave up and said "screw it" and did something easy.
20:14 fdobridge: <k​arolherbst🐧🦀> fair 😄
20:15 fdobridge: <k​arolherbst🐧🦀> mhhhhhh
20:15 fdobridge: <k​arolherbst🐧🦀> I'm actually wondering why nobody started to use TXQ_SAMPLE_POSITION for this...
20:15 fdobridge: <g​fxstrand> That's the thing with codegen... Like, I'm sure someone at some time thought they had a good reason for that. Maybe some older hardware requires it? But no one realized it could be done better on recent GPUs and fixed it. So even Turing was still pushing the whole damn table.
20:16 fdobridge: <k​arolherbst🐧🦀> I think it's not a thing pre fermi...
20:16 fdobridge: <g​fxstrand> That's believable. Seems odd that it'd be in the texture unit but IDK where else you'd put it.
20:17 fdobridge: <k​arolherbst🐧🦀> the fun part is.. the code emitter supports it since fermi for years
20:17 fdobridge: <k​arolherbst🐧🦀> it's all there
20:17 fdobridge: <k​arolherbst🐧🦀> but yeah...
20:17 fdobridge: <k​arolherbst🐧🦀> my motivation on working on codegen more than the bare minimum is kinda low 🙃
20:17 fdobridge: <k​arolherbst🐧🦀> I'd rather just wait for NAK and do things properly there
20:17 fdobridge: <g​fxstrand> Oh, for sure. No shame.
20:18 fdobridge: <k​arolherbst🐧🦀> though I wouldn't be surprised if NAK stays Volta+ and before that we either do something similar or try to make it work
20:18 fdobridge: <g​fxstrand> That's just why, apart from instruction encodings, I'm not really pulling much insparation from codegen at all.
20:18 fdobridge: <k​arolherbst🐧🦀> I'll definetly experiment with that
20:20 fdobridge: <k​arolherbst🐧🦀> quite sad that using external crates didn't really make it in meson 1.2 though 😢
20:59 fdobridge: <g​fxstrand> 😭
21:01 fdobridge: <a​irlied> one other codegen low hanging fruiut might be the clamp stuff that would fix a bunch of tests
21:04 fdobridge: <g​fxstrand> @karolherbst NVK doesn't like the new MS patch. 😭
21:06 fdobridge: <g​fxstrand> It's dying in RA of all places. 🙄
21:08 fdobridge: <g​fxstrand> I'll comment
21:09 fdobridge: <k​arolherbst🐧🦀> uhhhhh
21:09 fdobridge: <k​arolherbst🐧🦀> 🥲
21:12 fdobridge: <k​arolherbst🐧🦀> could be a worse fix, like actually fixing RA
21:18 fdobridge: <g​fxstrand> 😂
21:31 fdobridge: <g​fxstrand> @airlied if the new UAPI lands soonish, what kernel version will it hit?
21:34 fdobridge: <g​fxstrand> If I'm reading things right, it looks like the 6.5 window just closed so we'd be targeting 6.6, right?
21:35 fdobridge: <a​irlied> yes new uapi would be 6.6
21:35 fdobridge: <a​irlied> did you give an official rb for the mesa side MR?
21:39 fdobridge: <g​fxstrand> No, I was planning to do that the next round of patches. RB both at the same time.
21:40 fdobridge: <g​fxstrand> Mostly because of the BO flag.
21:41 fdobridge: <g​fxstrand> But unless something is madly different, it'll be basically automatic.
21:43 fdobridge: <g​fxstrand> Okay, I've now added a docs page: https://mesa.pages.freedesktop.org/-/mesa/-/jobs/46263246/artifacts/public/drivers/nvk.html
22:02 fdobridge: <m​ohamexiety> I love that `NVK_I_WANT_A_BROKEN_VULKAN_DRIVER` flag. it's just brilliant haha
22:13 fdobridge: <g​fxstrand> Okay, let's run Maxwell and see if it survives. 😅
22:57 fdobridge: <k​arolherbst🐧🦀> I'm sure it's gotten a lot better now
22:58 fdobridge: <k​arolherbst🐧🦀> I think most of the instability simply comes from channel recovery. If you point me towards another common problem with NVK after your run I can take a look tomorrow
23:10 fdobridge: <g​fxstrand> Yeah, this run has survived to the halfway point.
23:10 fdobridge: <g​fxstrand> I'm not gonna place any bets just yet, though. 😂
23:11 fdobridge: <k​arolherbst🐧🦀> 😄
23:11 fdobridge: <k​arolherbst🐧🦀> but is dmesg way more clean with your current run? I think most of the dead channels were caused by that ts thing
23:12 fdobridge: <k​arolherbst🐧🦀> but maybe there is more
23:12 fdobridge: <k​arolherbst🐧🦀> ehh wait
23:12 fdobridge: <k​arolherbst🐧🦀> there was this image thing...
23:12 fdobridge: <k​arolherbst🐧🦀> right...
23:12 fdobridge: <k​arolherbst🐧🦀> uhhh
23:12 fdobridge: <k​arolherbst🐧🦀> the null handle
23:14 fdobridge: <k​arolherbst🐧🦀> and then also that SUQ lowering...
23:15 fdobridge: <g​fxstrand> Yeah, I just updated !24327
23:15 fdobridge: <k​arolherbst🐧🦀> I think I'd rather make that vulkan only than messing with the nvc0 driver.... but uploading those 8 image views _might_ be simple enough
23:15 fdobridge: <g​fxstrand> What's the deal with SUQ?
23:15 fdobridge: <k​arolherbst🐧🦀> so the thing is, that in opengl for 1st gen maxwell we upload 8 special image views inside the tic table
23:15 fdobridge: <k​arolherbst🐧🦀> we don't for kepler
23:16 fdobridge: <k​arolherbst🐧🦀> for vulkan it's all fine, because the driver isn't in such a weird hackish state
23:16 fdobridge: <k​arolherbst🐧🦀> but what the SUQ -> TXQ lowering does on maxwell is to use one of those 8 image views on maxwell
23:16 fdobridge: <k​arolherbst🐧🦀> on kepler that lowering code just pulls some data from the driver const buffer instead
23:19 fdobridge: <k​arolherbst🐧🦀> https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c#L1284
23:19 fdobridge: <k​arolherbst🐧🦀> I could do this stuff on kepler as well and call it a day
23:19 fdobridge: <k​arolherbst🐧🦀> but the lowering would need to be disabled for fermi anyway
23:20 fdobridge: <k​arolherbst🐧🦀> maybe...
23:20 fdobridge: <k​arolherbst🐧🦀> fermi is weird
23:22 fdobridge: <k​arolherbst🐧🦀> I wouldn't mind adding a flag to `nv50_ir_prog_info` to flip that behavior...