00:00 fdobridge: <g​fxstrand> Why "domain always valid VM"? What are you thinking are the exact semantics of the bit?
00:01 fdobridge: <a​irlied> I just took amd's name, but we should probably come up with a better one
00:01 fdobridge: <a​irlied> domain is was the nicest place to put a flag
00:01 fdobridge: <a​irlied> I don't have a spare flags fields to stick things into here
00:02 fdobridge: <g​fxstrand> Yeah, domain seems reasonable. Doesn't seem any more crazy to go in there than mappable. 🤷🏻‍♀️
00:02 fdobridge: <a​irlied> yeah the tile flags seemed a worse place
00:03 fdobridge: <a​irlied> we could just call it USE_VM_RESV
00:04 fdobridge: <g​fxstrand> `NON_SHAREABLE`? I kinda hate that, though.
00:04 fdobridge: <a​irlied> it's do we name it after what it does, or what it implies
00:05 fdobridge: <g​fxstrand> All the words I'm coming up with like "local" seem like they could mean "stays on device" which isn't what we want.
00:05 fdobridge: <g​fxstrand> I kinda don't want the name to imply implementation.
00:06 fdobridge: <g​fxstrand> But IDK. 🤷🏻‍♀️
00:07 fdobridge: <g​fxstrand> Naming things is hard
00:07 fdobridge: <a​irlied> that leads to NON_SHAREABLE, radv uses NO_INTERPROCESS_SHARING internally
00:08 fdobridge: <g​fxstrand> I don't like "interprocess". What if the same process opens the file twice?
00:08 fdobridge: <a​irlied> yeah NO_SHARE is the simplest one I have
00:08 fdobridge: <g​fxstrand> No share or no export
00:08 fdobridge: <g​fxstrand> IDK which is better
00:09 fdobridge: <a​irlied> NO_EXPORT seems like someone might thing it's okay for import, though if you can't export then you can't import 😛
00:10 fdobridge: <g​fxstrand> Yeah
00:10 fdobridge: <g​fxstrand> And since you can't set new flags on import, you can't import either
00:10 fdobridge: <a​irlied> pushed out NO_SHARE
00:10 fdobridge: <g​fxstrand> Okay
00:24 fdobridge: <a​irlied> pushed out renames, and fixed up a few more kernel side bits, seeing some regressions with memory types, will chase those down
00:26 fdobridge: <a​irlied> ah that was some other local crap
00:56 fdobridge: <g​fxstrand> 👍
01:00 fdobridge: <a​irlied> okay fixed one regression in mesa side, kicking cts off
01:00 fdobridge: <g​fxstrand> 🥳
01:38 fdobridge: <e​sdrastarsis> on gsp reclocking
01:38 fdobridge: <e​sdrastarsis> https://cdn.discordapp.com/attachments/1034184951790305330/1132849264909877339/20230723_22h34m13s_grim.jpeg
02:09 fdobridge: <a​irlied> hmm screwed up something, cts doesn't make it out alive, will have to dig in a bit more
04:12 fdobridge: <a​irlied> might have to get dakr to figure out what I've done bad here, things seem to blowup randomly
05:32 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> At what settings?
05:39 fdobridge: <a​irlied> okay got a complete cts run to pass with the other fix on that branch
05:54 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Also fix the wide Putin car :evil_gears:
05:58 fdobridge: <g​fxstrand> Do I need all the fixes in that branch?
06:06 fdobridge: <a​irlied> the last 3 patches are the only ones for mesa interactions
06:12 fdobridge: <g​fxstrand> CTSing now
06:12 fdobridge: <g​fxstrand> It looks like it's still going to take 1.5 hours.
06:12 fdobridge: <g​fxstrand> I've got other theories about why things are taking forever.
06:12 fdobridge: <g​fxstrand> Fixing the submit scaling was still important though so I'm glad that's done.
06:14 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> I wonder if NVK can survive an overnight run of Unigine Heaven with GSP and new UAPI 🤔
06:15 fdobridge: <g​fxstrand> @airlied Congratulations on doing something in an hour that the i915 team hasn't been able to do in 5 years and counting. 🙃
06:16 fdobridge: <g​fxstrand> @airlied Congratulations on doing something in a few hours that the i915 team hasn't been able to do in 5 years and counting. 🙃 (edited)
06:22 fdobridge: <a​irlied> @phomes so the reason I don't think mme macros work on dispatch is we don't upload mme macros for the compute class
06:23 fdobridge: <a​irlied> might need to create a set of compute mme macros separate for those ones
06:24 fdobridge: <a​irlied> though I'm not sure if the two classes have separate mme storage
06:26 fdobridge: <g​fxstrand> According to the headers, there's no way to upload MMEs for compute on Turing+
06:27 fdobridge: <g​fxstrand> Maybe it exists but not in the headers but I kinda doubt it
06:30 fdobridge: <a​irlied> it's wierd it's in the ampere B headers I think
06:32 fdobridge: <g​fxstrand> Maybe they added it back?
06:32 fdobridge: <g​fxstrand> Maybe they wanted it on the lovelace cards because they tossed 3D but still needed MME?
06:32 fdobridge: <g​fxstrand> 🤷🏻‍♀️
06:33 fdobridge: <g​fxstrand> Or maybe it exists on Turing and they're just lying in the headers?
06:40 fdobridge: <a​irlied> dang just got another strange gpu crash taking out the world with the resv change
07:43 fdobridge: <g​fxstrand> @airlied So, the crucible test is definitely 2x as fast with the new patches but it's still doing something per-BO per-EXEC.
07:44 fdobridge: <g​fxstrand> 1000 BOs doubles EXEC time from 66 to 122 us/exec
07:45 fdobridge: <g​fxstrand> Still better than the 212 us/exec without NO_SHARE
07:50 fdobridge: <a​irlied> yeah I did some perf record traces earlier and I think we need to do something different for bo validation
07:52 fdobridge: <a​irlied> @phomes I did some cond render hacks https://gitlab.freedesktop.org/airlied/mesa/-/commits/nvk-cond-render-hacks
07:52 fdobridge: <a​irlied> it's pretty horrid though
07:52 fdobridge: <a​irlied> fails all the local memory tests
07:55 fdobridge: <g​fxstrand> Oh, that's ughly...
07:56 fdobridge: <g​fxstrand> All because it randomly requires 16B alignment?
07:56 airlied: not sure if it's 16B yet, it definitely doesn't like 4 bytes
07:57 fdobridge: <g​fxstrand> gross
07:57 fdobridge: <a​irlied> also not all local memory tests are failing, but a bunch are
08:08 fdobridge: <a​irlied> okay it's grosser than that, updated the branch, all 542 cond render tests pass now
08:08 fdobridge: <a​irlied> I think the local bo fix is probably some sort of missing stall
08:08 fdobridge: <a​irlied> but at least this gives us a working baseline
08:09 fdobridge: <a​irlied> nvc0 has some gross stalling code, that might need leveraging
08:10 fdobridge: <a​irlied> nvc0_hw_query_fifo_wait
08:10 fdobridge: <g​fxstrand> Ugh
08:11 fdobridge: <a​irlied> I expect we need to get some nvidia cmd buffer dumping going here
09:24 fdobridge: <k​arolherbst🐧🦀> kinda depends. The way nvc0 uses semaphores is super weird, but the CPU has to wait on the semaphore somehow if the CPU needs the result, if not, then just wait on the semaphore
09:24 fdobridge: <e​sdrastarsis> Ultra 800x600
09:24 fdobridge: <k​arolherbst🐧🦀> (in the push buffer that is)
09:24 fdobridge: <e​sdrastarsis> I'm using an ultrawide monitor :frog_gears:
09:25 fdobridge: <e​sdrastarsis> I can write a tutorial for you if you want (on arch linux)
09:27 fdobridge: <a​irlied> For cond render it's just GPU waits I think, but it's weird esp with vram and bo alignnents
09:27 fdobridge: <k​arolherbst🐧🦀> ahh yeah..
09:28 fdobridge: <k​arolherbst🐧🦀> I think all those semaphorse need to be 16 bytes alligned at least
09:29 fdobridge: <k​arolherbst🐧🦀> let's see...
09:30 fdobridge: <k​arolherbst🐧🦀> mhh
09:32 fdobridge: <k​arolherbst🐧🦀> @airlied huh? why this weird indirection in the mme?
09:33 fdobridge: <k​arolherbst🐧🦀> why not just register the buffer instead passing null and emulating it in mme
09:38 fdobridge: <a​irlied> My patch removes all the mme usage
09:38 fdobridge: <a​irlied> Mme didnt work for compute
09:39 fdobridge: <k​arolherbst🐧🦀> yeah... I don't know if we even have mme for compute on turing
09:40 fdobridge: <k​arolherbst🐧🦀> and other gens
09:40 fdobridge: <k​arolherbst🐧🦀> okay, so the remaining issue is just the alignment of htat buffer?
09:40 fdobridge: <k​arolherbst🐧🦀> or something else?
09:41 fdobridge: <a​irlied> Both the alignment and it has to be in gart
09:41 fdobridge: <k​arolherbst🐧🦀> why in gart?
09:41 fdobridge: <a​irlied> Direct reading from local gets wrong answers
09:42 fdobridge: <k​arolherbst🐧🦀> ohhh right, if the CPU wants to read from it it has to be gart right..
09:43 fdobridge: <k​arolherbst🐧🦀> mhh? that's a bit weird though, but yeah, maybe some caching issue if the CPU side messes with the buffers content or something, though if only the GPU writes to it it should be fine, no?
09:46 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> That performance is too low
09:47 fdobridge: <!​[NVK Whacker] Echo (she) 🇱🇹> Just get the widescreen fix 🐸
09:57 fdobridge: <e​sdrastarsis> Yes, I noticed that OpenGL has higher performance than Vulkan
10:07 fdobridge: <a​irlied> Yeah VK cond render is a bit different to GL, in GL the driver controls the query buffer output used for cond render, but in VK they are app controlled
10:20 fdobridge: <k​arolherbst🐧🦀> cursed
10:23 fdobridge: <p​homes> I have my lunch break now so I can take a quick look
10:25 fdobridge: <p​homes> the mme was just a leftover from when I tried to implement it all in mme. What @airlied did is better
10:51 fdobridge: <e​sdrastarsis> So your cond render hack can improve performance?
10:54 fdobridge: <r​hed0x> pretty much nothing uses Vulkan conditional rendering
10:56 fdobridge: <t​riang3l> Does something like VKD3D?
10:56 fdobridge: <r​hed0x> DXVK doesn't, dunno about VKD3D-Proton
10:56 fdobridge: <t​riang3l> D3D11 has SetPredication too
10:57 fdobridge: <r​hed0x> yeah but dxvk just ignores it because the implementation broke watch dogs
10:59 fdobridge: <e​sdrastarsis> It's used by zink at least
11:00 fdobridge: <p​homes> In my tests cts and Sascha Willems conditionalrender works well (on the uapi)
11:01 fdobridge: <p​homes> with my current skill level I am not sure I can help with much for the issues that remain
11:07 fdobridge: <p​homes> I was unsure if we should set it for 902d as well?
12:47 fdobridge: <k​arolherbst🐧🦀> let's see if I can figure out this `INVALID_VALUE` bug...
13:28 fdobridge: <k​arolherbst🐧🦀> now to figure out what test actually hits this...
15:36 fdobridge: <k​arolherbst🐧🦀> @gfxstrand I'm currently debugging a shader throwing `ILLEGAL_INSTR_ENCODING` and I think it's happening when a pipeline is launched with just a vertex shader, but not fragment one
15:38 fdobridge: <k​arolherbst🐧🦀> but also not entirely sure... I've replaced all instructions of the VP with `NOP`s, but it's still giving me the error, so it's just my assumption that the hw might execute a non existing FP here anyway
15:38 fdobridge: <k​arolherbst🐧🦀> `dEQP-VK.robustness.image_robustness.push.notemplate.rgba32f.dontunroll.volatile.storage_image.no_fmt_qual.img.samples_1.1d.vert`
15:39 fdobridge: <g​fxstrand> Interesting..
15:39 fdobridge: <g​fxstrand> It's possible we need a dummy VS
15:39 fdobridge: <k​arolherbst🐧🦀> you mean dummy FS
15:39 fdobridge: <g​fxstrand> It's possible we need a dummy FS (edited)
15:39 fdobridge: <k​arolherbst🐧🦀> ahh
15:39 fdobridge: <k​arolherbst🐧🦀> 😄
15:39 fdobridge: <k​arolherbst🐧🦀> yeah.. probably
15:39 fdobridge: <k​arolherbst🐧🦀> I'm checking on Ada as well as this was on Pascal
15:39 fdobridge: <g​fxstrand> A dummy FS is easy enough to add.
15:40 fdobridge: <k​arolherbst🐧🦀> yeah....
15:40 fdobridge: <k​arolherbst🐧🦀> it seems like that Ada doesn't care
15:40 fdobridge: <k​arolherbst🐧🦀> and if Turing doesn't care it's probably a pre Volta thing
15:40 fdobridge: <k​arolherbst🐧🦀> ohhhh....
15:40 fdobridge: <k​arolherbst🐧🦀> of course it is...
15:41 fdobridge: <k​arolherbst🐧🦀> it probably simply executes at offset 0 of the shader bo
15:41 fdobridge: <k​arolherbst🐧🦀> or something silly
15:41 fdobridge: <k​arolherbst🐧🦀> let me check if the FS stage is enabled/disabled
15:42 fdobridge: <g​fxstrand> https://cdn.discordapp.com/attachments/1034184951790305330/1133061622169096222/0001-DUMMY-FS.patch
15:43 fdobridge: <g​fxstrand> Insert HW version checks as appropriate
15:43 fdobridge: <k​arolherbst🐧🦀> mhhh.. it's disabled
15:43 fdobridge: <k​arolherbst🐧🦀> yeah.. let me try that patch to verify
15:44 fdobridge: <g​fxstrand> This could explain a lot of the Maxwell instability
15:44 fdobridge: <k​arolherbst🐧🦀> needs a `MESA_SHADER_FRAGMENT`
15:44 fdobridge: <k​arolherbst🐧🦀> ehhh
15:44 fdobridge: <k​arolherbst🐧🦀> `nir_options`
15:45 fdobridge: <g​fxstrand> Right. Look a couple lines up and you can find where to get that
15:45 fdobridge: <k​arolherbst🐧🦀> yeah
15:46 fdobridge: <k​arolherbst🐧🦀> mhh.. that crashes a little later one
15:46 fdobridge: <k​arolherbst🐧🦀> *on
15:47 fdobridge: <k​arolherbst🐧🦀> `nv_nir_move_stores_to_end` crashes as it can't find a block
15:47 fdobridge: <k​arolherbst🐧🦀> no impl
15:47 fdobridge: <g​fxstrand> Okay, maybe do a `nir_builder_new()` instead then. 😅
15:48 fdobridge: <k​arolherbst🐧🦀> 😄
15:48 fdobridge: <g​fxstrand> Or init_simple_shader, rather
15:48 fdobridge: <k​arolherbst🐧🦀> ahh yeah, that was the thing
15:49 fdobridge: <g​fxstrand> Yeah,
15:49 fdobridge: <g​fxstrand> ```c++
15:49 fdobridge: <g​fxstrand> nir_builder b =
15:49 fdobridge: <g​fxstrand> nir_builder_init_simple_shaer(MESA_SHADER_FRAGMENT,
15:49 fdobridge: <g​fxstrand> nir_options, "Trivial FS");
15:49 fdobridge: <g​fxstrand> nir[MESA_SHADER_FRAGMENT] = b.shader;
15:49 fdobridge: <g​fxstrand> ```
15:49 fdobridge: <g​fxstrand> When in doubt, use the builder. 🙃
15:51 fdobridge: <k​arolherbst🐧🦀> mhhhhh....
15:52 fdobridge: <k​arolherbst🐧🦀> apparently it still happens
15:52 fdobridge: <k​arolherbst🐧🦀> odd
15:54 fdobridge: <g​fxstrand> Could be something else
15:57 fdobridge: <k​arolherbst🐧🦀> we have that `nvc0_program_init_tcp_empty` function in gl
15:58 fdobridge: <k​arolherbst🐧🦀> yep...
16:00 fdobridge: <k​arolherbst🐧🦀> @gfxstrand error is gone when I do it for `MESA_SHADER_TESS_EVAL` 😄
16:00 fdobridge: <k​arolherbst🐧🦀> mhhh
16:01 fdobridge: <k​arolherbst🐧🦀> that's weird though
16:01 fdobridge: <k​arolherbst🐧🦀> I got other errors with `MESA_SHADER_TESS_CTRL` and that's what gl is doing... let me try that isntead
16:03 fdobridge: <g​fxstrand> Uh... what?
16:04 fdobridge: <k​arolherbst🐧🦀> https://gist.github.com/karolherbst/e9048f2bd7559c02ab9ac2419fdb5073
16:05 fdobridge: <k​arolherbst🐧🦀> that's what GL is doing and it seems to resolve the problem
16:05 fdobridge: <k​arolherbst🐧🦀> test is still failing though, but it's also a fuzzing one so maybe I ignore the failure there
16:06 fdobridge: <g​fxstrand> Wait, it always wants a tessellation shader?
16:06 fdobridge: <k​arolherbst🐧🦀> yes
16:06 fdobridge: <k​arolherbst🐧🦀> I'm sure we do this in gl for a reason
16:06 fdobridge: <k​arolherbst🐧🦀> see `nvc0_tctlprog_validate`
16:07 fdobridge: <k​arolherbst🐧🦀> though we set a different value
16:07 fdobridge: <k​arolherbst🐧🦀> `0x20` vs `0x21`
16:07 fdobridge: <k​arolherbst🐧🦀> kinda weird
16:08 fdobridge: <k​arolherbst🐧🦀> so yeah.. we disable the shader, but still put a program there and bind it 😄
16:09 fdobridge: <k​arolherbst🐧🦀> they probably fixed whatever the hardware expected here for volta+ I think
16:09 fdobridge: <g​fxstrand> Heh. Could be, yeah.
16:10 fdobridge: <k​arolherbst🐧🦀> yeah.. the diff in itself causes more issue mhh...
16:10 fdobridge: <g​fxstrand> 😓
16:43 fdobridge: <k​arolherbst🐧🦀> yeah mhhh... no idea
16:45 fdobridge: <k​arolherbst🐧🦀> maybe it's something with prefetching again
16:46 fdobridge: <k​arolherbst🐧🦀> I'll... deal with other errors first 🙃
16:55 fdobridge: <g​fxstrand> I could believe we have prefetching bugs
18:05 anholt: mme_builder_test.while_ine seems to consistently time out in ci now.
18:28 fdobridge: <g​fxstrand> Is that new? I didn't we'd really changed any of that code in a while.
18:30 anholt: wasn't timing out for me last week, now I'm at 3/3.
18:36 fdobridge: <g​fxstrand> weird...
18:37 fdobridge: <g​fxstrand> Last change to src/nouveau/mme was in March.
18:37 fdobridge: <g​fxstrand> Maybe one of the winsys changes affected it?
18:38 fdobridge: <g​fxstrand> Yeah, blowing up for me too
18:39 fdobridge: <g​fxstrand> sanity is failing.... That's not good
18:39 fdobridge: <g​fxstrand> Oh, wait, new UAPI broke it
18:41 fdobridge:<g​fxstrand> bisects
18:43 fdobridge: <g​fxstrand> Okay, now they're all working for me. What the hell?
18:45 fdobridge: <g​fxstrand> There must be something uninitialized somewhere
18:56 fdobridge: <g​fxstrand> Oh, no. My one fail was because I typed in the wrong terminal and ran it on my intel box. 🤦🏻‍♀️
19:26 fdobridge: <g​fxstrand> Okay, updated to the new UAPI and they all still pass
19:26 fdobridge: <g​fxstrand> @eanholt what hardware are you seeing fails on?
19:42 fdobridge: <k​arolherbst🐧🦀> ......
19:42 fdobridge: <k​arolherbst🐧🦀> ..................................
19:42 fdobridge: <k​arolherbst🐧🦀> `emitNOP` generates a `NOP` the hardware doesn't like 🙃
19:44 fdobridge: <g​fxstrand> Lovely
19:44 fdobridge: <k​arolherbst🐧🦀> anyway, I figured out what's broken with the test and it's `sustp`
19:47 fdobridge: <k​arolherbst🐧🦀> I blame `nvdisasm` for not shouting at me
19:49 fdobridge: <k​arolherbst🐧🦀> ` /*0018*/ @!PT NOP.TRIG CC.RGT, 0xfff; /* 0x50b00000ffffffff */` ?!?
19:49 fdobridge: <k​arolherbst🐧🦀> apparently the NOP instruction has some weirdo stuff on it
20:02 fdobridge: <g​fxstrand> funky
20:40 fdobridge: <k​arolherbst🐧🦀> ohhh
20:40 fdobridge: <k​arolherbst🐧🦀> right...
20:40 fdobridge: <k​arolherbst🐧🦀> that's the unformatted image thing..
20:42 fdobridge: <k​arolherbst🐧🦀> @gfxstrand coordinates of unformatted image loads in nir are they based on bytes or dest type?
20:43 fdobridge: <k​arolherbst🐧🦀> noice...
20:43 fdobridge: <k​arolherbst🐧🦀> enable unformatted loads on the ISA level gets rid of the error
20:48 fdobridge: <k​arolherbst🐧🦀> well.. that throws an misalligned address error 🙃
20:48 fdobridge: <k​arolherbst🐧🦀> (assuming byte addressing that is)
20:50 fdobridge: <g​fxstrand> should be pixels
20:50 fdobridge: <k​arolherbst🐧🦀> okay..
20:50 fdobridge: <k​arolherbst🐧🦀> so we have to emit `OP_SUSTB` and `OP_SULDB` for images without formats
20:51 fdobridge: <k​arolherbst🐧🦀> let's see if that fixes the test
20:52 fdobridge: <k​arolherbst🐧🦀> mhhh... something up with stores
20:53 fdobridge: <k​arolherbst🐧🦀> okay.. at least I know how to fix it..
20:53 fdobridge: <k​arolherbst🐧🦀> @gfxstrand mind checking real quick if `dEQP-VK.robustness.image_robustness.push.notemplate.rgba32f.dontunroll.volatile.storage_image.no_fmt_qual.img.samples_1.1d.vert` passes on turing?
20:54 airlied: passes for me here
20:55 fdobridge: <k​arolherbst🐧🦀> mhh..
20:55 fdobridge: <k​arolherbst🐧🦀> I wonder if I break turing/ampere then
21:03 fdobridge: <k​arolherbst🐧🦀> mhhh
21:03 fdobridge: <k​arolherbst🐧🦀> I wonder if SULDB is broken, because the test fails, but at least the gpu stops throwing an error
21:04 fdobridge: <k​arolherbst🐧🦀> the `SULDB` code was always unused, but was kept in case CL ever emerged
21:11 fdobridge: <k​arolherbst🐧🦀> ohhh... I see