04:06 dviola: skeggsb: I tested your patch and the timeout is gone when booting my system, but it's back after a suspend/resume
04:07 imirkin: pmoreau: ok. rebased and split up: https://gitlab.freedesktop.org/imirkin/mesa/-/commits/nv50_compute
04:07 imirkin: pmoreau: still a few things to address
04:07 imirkin: pmoreau: i left out all the nir / opencl stuff
04:11 skeggsb: dviola: what's the backtrace from that?
04:12 dviola: one sec, I'll get it
04:13 dviola: ugh, I reverted it to the stock arch kernel, it will take me a few minutes to get it to you, I have to recompile the kernel
04:14 dviola: shouldn't take that long
04:14 skeggsb: cool, because i don't believe it's possible to hit that timeout now, so i'm curious :P
04:28 imirkin: mwk: are the "postincr" op variants basically where on top of doing whatever the op was doing, the $a reg's value is increased too?
04:30 imirkin: (and if so, by how much exactly?)
04:34 dviola: skeggsb: this is after a suspend/resume: http://ix.io/2QLS
04:37 skeggsb: hrmmm, i'm gunna need to think about that for a bit
04:38 dviola: sure
04:39 skeggsb: those are different timeouts you're hitting now, yes?
04:40 dviola: looks like it: http://ix.io/2OTM
04:40 dviola: the other was related to: drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c:107 nvkm_pmu_reset
04:40 skeggsb: yeah, good, that sorta makes sense now then
04:43 skeggsb: i'm apparently attempting to come up with an additional patch now
04:43 dviola: thanks
04:57 skeggsb: dviola: alright, there's another patch in the same branch
04:59 dviola: cool, testing now
05:08 dviola: skeggsb: sweet, no timeouts anymore :)
05:08 dviola: tried suspend/resume as well
05:09 dviola: let me try a few more reboots, etc
05:09 skeggsb: sure :) let me know how you go
05:10 dviola: yep, it's perfect now
05:11 dviola: skeggsb: thanks a lot
05:11 skeggsb: thanks for the pokes and testing :) i won't send them anywhere yet, i need to look carefully to make sure nothing unexpected is going to happen
05:11 dviola: alright, sure
05:12 skeggsb: there's a twisty maze between pre-ACR falcon use and post-ACR in the driver that's hard to follow
05:13 dviola: and yw :) I have to actually confess I installed arch on that machine just to see which issues I would run into :P that's the laptop I am supposed to use for work, I might actually use it now :P
05:16 dviola: skeggsb: feel free to ping me anytime if you want me to test more patches
05:19 skeggsb: dviola: sure, thanks!
05:34 damo22: thank you all for this driver! I've been reading the backlog for only a few days but i can tell there is a lot of work that went into the development and reverse engineering and appreciate how hard this stuff can be
05:40 damo22: fingers crossed the signature check has a bypass somewhere and one day we'll figure it out :D
06:20 salawat: Well, that was quite the rabbit hole.
06:24 salawat: Went from not having a bloody clue to diiscovering documentation that has priorr to now stayed firmly somewhere in the fog induced by search engine SEO, and discovered I've got a new ISA to look into, and fiddle with tooling for.
06:29 salawat: The asn1 parsing experiment was downright a shot in the dark that resulted in more amusement than anything... but I feel like it's at lleast gotten me deeper into actually learning the guts of the card thanks to the envytools docs. Also stumbled across the DRIVE docs, and while I still haven't seen much in terms of binary dumpable crypto stores accessible from the host machine, I'm at least awre of what algorithms their packing in their
06:31 salawat: got a lot of reading to do I think before I'll be any use, but eh... the journey of a million miles starts with a single step, right?
08:51 pmoreau: imirkin: Awesome, thanks a lot! Don’t we all love having one giant WIP patch that just keeps on accumulating even more stuff? :-D Should I go from the compute branch or the nv50_compute one?
08:52 pmoreau: As for the patches missing S-o-b, I most likely forgot to add the flag for it when committing so you can add them (or I will do it when I update my branch).
08:52 pmoreau: I should change my Git config for this repo so that it automatically adds the S-o-b.
10:49 zocker: is there a way to read the current core and memory clocks of a GT1030/gp108 card while running on nouveau?
11:03 zocker: or would pmu firmware be required for that?
11:14 kherbst: zocker: I think in theory we should be able to read it out, but it's a bit hard to re what registers to touch for that
11:17 RSpliet: kherbst: is it? Can't you set manual clocks with... ehh... what's that feature called
11:18 RSpliet: Coolbits I think
11:21 RSpliet: kherbst: https://forums.developer.nvidia.com/t/option-coolbits-is-not-used-optimus-enabled-laptop-running-an-rtx-2070-manjaro-linux/111771
11:21 RSpliet: Should still be a thing for RTX2070 at least
11:21 kherbst: RSpliet: it still goes through the PMU
11:21 kherbst: but anyway.. I don't think much of the regs changed in pascal
11:22 kherbst: and I think most is actually identical
11:22 RSpliet: kherbst: even the non-memory PLLs?
11:22 kherbst: yeah.. I think so
11:22 kherbst: I was looking at it briefly
11:22 kherbst: the thing which they locked down was the voltage controler
11:22 kherbst: but I wasn't looking in depth, because... quite pointless
11:22 RSpliet: Oh. Eh, I expect PLL registers to look exactly the same as they always do, PLLs themselves haven't fundamentally changed :-D
11:23 kherbst: but we don't even calculate the clocks correctly on kepler
11:23 RSpliet: Yeah, limited benefit. Nice to report speeds, but that's about it.
11:24 RSpliet: I expect REing those registers, if at all necessary, isn't the problem though. Just... rather have you focus on multithreading or OpenCL or other more useful bits :-D
11:24 kherbst: sure
11:24 kherbst: the bigger issue is just, that we can't really trace what the blob is doing
11:24 kherbst: and this sucks
11:25 RSpliet: Why not? You can't alter the VBIOS, which is a headache. But you can still intercept the PMU scripts no?
11:25 kherbst: we can't
11:26 kherbst: also, what scripts? :p
11:26 RSpliet: My knowledge is Kepler/Maxwell, do enlighten me about changes :-P
11:26 kherbst: yeah well.. the PMU is doing everything
11:26 kherbst: afaik
11:27 kherbst: dunno if this is the case with pascal though
11:27 RSpliet: Oh, so no more "calculate all the memory registers in the driver and upload a script of changes"
11:27 kherbst: yep
11:27 RSpliet: Does it read out the VBIOS directly?
11:27 kherbst: dunno
11:27 kherbst: but the tables changed massively
11:27 ccr: :(
11:27 kherbst: with kepler we had like .. 15 tables?
11:27 kherbst: we are now at 40
11:28 RSpliet: JFC
11:28 RSpliet: Are they running MySQL on those cores?
11:28 kherbst: highest P table offset was 0x138 or whatever
11:28 kherbst: it's massive
11:28 kherbst: maybe I am exegarating a little.. let me check on turing :D
11:29 RSpliet: There's a point of over-engineering :')
11:29 RSpliet: Anyway, yeah, clear. However, if all the logic ends up in the PMU, then we don't need to RE none of it. We just need the gosh darn firmwares :-P
11:29 kherbst: RSpliet: https://gist.github.com/karolherbst/be862bd529a8b4e31a6b35575f2adb22
11:30 kherbst: so.. I wasn't that off
11:30 kherbst: :D
11:30 RSpliet: Yeah that's 40 alright
11:30 kherbst: 40 existing tables ;)
11:31 kherbst: there are some missing ones
11:31 kherbst: but I assume those are mostly legacy ones
11:31 kherbst: but yeah.. I think what you do witht he PMU is, that you read out the tables and configure the PMU accordingly
11:32 kherbst: but... oh well
11:32 kherbst: we'll see
11:36 RSpliet: We've been seeing for a couple of years now. So far there's little to see on the perf management front :-P
11:36 kherbst: I know
11:36 RSpliet: Even I got an AMD APU the other day... my heart hurts, but the easy of having it just works does soothe a bit
12:01 zocker: these missing firmwares should be somewhere in the nvidia blob and the difficulty is to actually extract them somehow, correct?
12:01 zocker: (sorry for my noob questions, i just started researching this stuff yesterday :D)
12:04 kherbst: problem is redistributinh
12:05 kherbst: *redistributing
12:09 zocker: so if i managed to somehow obtain the pmu firmware, what else would be missing for reclocking?
12:10 kherbst: wiring it up inside the kernel
12:11 zocker: so the driver would talk to it in order so set voltages and clocks, and the card wouldn't manage that itself?
12:13 zocker: as in, it wouldn't be sufficient to just upload the pmu firmware to the gpu?
12:14 kherbst: correct
12:18 zocker: i see
12:21 zocker: is the procedure to extract the firmware documented somewhere? at least that knowledge should be legal to redistribute?
12:24 kherbst: there is code somewhere.. imirkin_ might know
12:30 zocker: alright, thanks!
12:33 zocker: i'm really impressed with nouveaus functionality, kde plasma works great with desktop effects and everything up to 1920x1080
12:34 zocker: tried it with a 4K display as well, then it starts to fall apart performance wise
12:51 zocker: i'm going to use it with a 1080p projector anyway, so for me its fine... i'm just curious about possible performance improvements :)
13:22 imirkin_: pmoreau: the nv50_compute one is the up-to-date rebased one. it's all nice and split up.
13:22 pmoreau: 👍️
13:23 imirkin_: (i think?)
13:23 imirkin_: let me know if you think something in there deserves further splitting
13:24 pmoreau: I will have a look at it later (most likely during the weekend).
13:28 pmoreau: I rebased my “rework_mem_ldst” branch to the latest master; I started reworking some of my patches to properly use a[], but it’s still a WIP (I don’t even remember what the current status is there). I’ll try to split patches out (like changes in nv50_ir_from_nir.cpp) to simplify things, and send MRs.
13:33 imirkin_: pmoreau: i'd recommend basing on mine. i'm going to start upstreaming lots of this stuff.
13:33 imirkin_: unless you see issues.
13:33 pmoreau: Sounds good!
13:33 imirkin_: what do you mean by "properly use a[]"?
13:34 imirkin_: i need to copy over the nvc0 lowering for shared memory atomics
13:34 pmoreau: Uh, not a[], but $a
13:34 imirkin_: but otherwise shared should be fine ... i think
13:34 imirkin_: i'll double-check
13:34 pmoreau: I was converting away from using the address registers and always using regular registers instead.
13:35 imirkin_: oops
13:35 imirkin_: yeah, the input ir needs to make sure they're FILE_ADDRESS
13:35 imirkin_: maybe nvir screws that up? dunno
13:35 imirkin_: er, nvir_from_nir
13:36 pmoreau: from_nir is doing it properly IIRC, but I had an explicit pass to replace $a with $r, cause something was not working/I did not understand how to use $a properly.
13:36 pmoreau: So in the new series I am trying to revert and fix that.
13:39 imirkin_: oh oops
13:39 imirkin_: rm -rf ;)
13:39 imirkin_: having split out patches helps with this stuff
13:42 mwk: imirkin_: the postincr for Tesla? it first uses the unchanged $a value, then increments it by the instruction field that would otherwise encode offset from $a
13:42 imirkin_: mwk: ah ok. so the offset isn't applied
13:42 imirkin_: (to the address)
13:42 pmoreau: Hahaha :-D
13:42 pmoreau: It does, and thankfully it isn’t part of a big huge WIP patch.
13:44 mwk: yes, the offset is only applied afterwards
13:47 imirkin_: mwk: cool thanks
15:08 imirkin_: pmoreau: i'll put another branch together with what i propose we merge since it's clearly "good"
15:48 pmoreau: 👍️
15:49 pmoreau: I might even have some time to look at it today, we will see.
15:54 imirkin_: basically i think many compiler changes are good to go, and some of the state tracking stuff
15:54 imirkin_: and probably leave off the enablement bits until later
15:54 imirkin_: as well as some of the more bogus WIP-marked changes
16:54 Lyude: -finally- think I figured out why the cursor transparency igt test has been failing and it's, silly (and I'm surprised I didn't think of this)
16:55 imirkin_: Lyude: speaking of cursors, did you see the discussion about the 256x256 cursor change on the ML?
16:56 imirkin_: by the sounds of it, at least GK10x's don't fully support 256x256 cursors. or there's more that we're supposed to do for them.
16:56 Lyude: we're not clearing fbs before we allocate them, which I didn't realize would actually matter until I realized that cairo (which igt uses for drawing) would be doing alpha blending using the data already in the fb. which, means drawing with alpha = 0 just leaves whatever color was previously on the fb
16:56 Lyude: imirkin_: hm.
16:57 imirkin_: 128x128 is fine though
16:57 Lyude: yeah I did see that I just hadn't really read too deeply into it. I actually got some of my other kepler cards back from the boston office the other day so I can probably try to reproduce this
16:57 imirkin_: Lyude: cool
16:57 imirkin_: would be good to have someone with (a) hardware (b) graphics experience have a looksy
16:57 Lyude: imirkin_: that's... also very weird, I'm not sure that actually matches up with some of the docs I have
16:57 Lyude: maybe I missed something though
16:57 imirkin_: i asked emersion to retest on his GK208, since that has a slightly later display controller
16:58 imirkin_: could be. it's been known to happen.
16:58 imirkin_: and yeah, the docs are pretty clear about 256x256 being a valid enum value. but nothing to say that there wasn't an errata that went with it that said "don't use 256x256, it's broken" :)
16:59 imirkin_: modetest + SMPTE pattern for the cursor should be able to flush it out though
17:01 Lyude: skeggsb: btw - I remember you mentioning that at some point with all of the mmu rework stuff for nouveau you were going to add something for auto-clearing surfaces we allocate, any idea what the timeline for that is (or if I could help speed it up?)
17:01 Lyude: imirkin_: eh-I've kinda just gotten in the habit of using igt, I need to hack modetest at some point so that you don't have to specify drm object IDs because it makes it kind of tedious to use in the commandline :v
17:02 imirkin_: yeah, connector names would be super
17:02 imirkin_: but i only ever light up 1 connector at a time
17:02 imirkin_: but anyways, you want to use igt for it, go for it
17:02 imirkin_: but it's important to verify it actually displays correctly ;)
17:04 Lyude: imirkin_: I mean you can see the output with igt :P, either way CRCs tend to be pretty accurate
17:04 imirkin_: but CRC's don't verify anything is displaying correctly...
17:05 imirkin_: just displaying differently ;)
17:05 Lyude: mhm, yeah I've already found some bugs like that with igt :P
17:05 imirkin_: ultimately a human sorta has to be the judge of "correct" vs "not"
17:06 imirkin_: or a full writeback scheme with frame-by-frame comparison to a set of goldens
17:08 Lyude: generally it's fine as long as you've verified at some point that displaying basic things work correctly, and also try actually generating different CRCs by changing the display output (it's technically possible for two different frames to have identical CRCs, but any decent CRC algorithm should give a different number for two frames that are only a tiny bit different from one another)
17:10 imirkin_: sure
17:10 imirkin_: but we don't have CRC goldens do we?
17:10 imirkin_: (for each hardware for each test)
17:11 Lyude: imirkin_: neither does intel, but they still catch bugs pretty well for the most part. i've only found like, I think one false positive in all the tests I've ran so far?
17:11 imirkin_: i'm not saying it's bad to do the crc thing
17:11 imirkin_: i'm saying it's not an indicator of accurate display
17:11 Lyude: yeah, gotcha
17:11 imirkin_: like you could have e.g. inverted colors, and the crc thing would be all good
17:13 Lyude: good point
17:13 imirkin_: or the stride of the image could be messed up, and crc would be all good
17:13 imirkin_: etc
17:14 imirkin_: but crc's catch other types of issues which are important too
17:14 imirkin_: (like "i tried to display a plane, and nothing changed. weird")
17:14 Lyude: yeah, that's kinda the reason I got intel into using chameliums for testing in the first place
17:15 imirkin_: having crc goldens would be a reasonable idea
17:15 Lyude: (I really need to use mine for like, actual igt tests more instead of just using it as my ultimate remote display)
17:15 imirkin_: but i wonder if it's too sensitive
17:15 imirkin_: lol
17:15 imirkin_: yes, the simplest way to have remote display: chamelium.
17:15 imirkin_: definitely not vnc.
17:16 Lyude: imirkin_: it is too sensitive unfortunately, on a lot of hw (and I think this is the case for some nv hardware in my experiements) I think even just things like different data pipe widths between each head can even cause crcs to come out differently
17:16 imirkin_: yeah, makes sense
17:16 Lyude: (volta+ actually has a mode for fixing this though! but, I haven't actually experimented enough to see how reliable that is)
17:18 Lyude: imirkin_: imho what would be quite nice (mainly because it'd let us actually use CRCs for non-active parts of the raster for verifying stuff like HDMI audio) is if we could actually get the algorithm for computing a CRC from an fb, or figure out if the hardware provides any way of doing it
17:19 imirkin_: yeah, that's next-level
17:19 imirkin_: verifying that we're sending the right infoframes/etc would be super
17:20 imirkin_: like ACTUALLY sending the right infoframes
17:20 imirkin_: as opposed to thinking we're sending the right infoframes :)
17:20 imirkin_: that said, esp audio is tricky
17:20 imirkin_: we use the "auto" setting for the audio stuff
17:20 Lyude: mhm, we can probably do that with the chamelium but i'd much rather us be able to just do it with crcs if possible (since it's faster, sometimes more reliable, and definitely cheaper for everyone involved)
17:20 imirkin_: rather than computing all that junk by hand
17:20 imirkin_: so we don't really know what the "right" thing is in the first place
17:21 imirkin_: the hw does allow explicit setting of hdmi audio parameters, but everything i've seen on-list about it with hw that requires that is endless pain and lack of audio sync
17:24 Lyude: i do wonder if we could at least implement a basic hdmi audio test, one that isn't robust but at least verifies that something changes the CRC in the non-active raster. would be better then nothing for when we finally get CI running
17:34 emersion: chamelium already should have audio tests
17:35 Lyude: emersion: I mentioned that btw
17:35 emersion: i worked on those during 6 full months :P
17:35 emersion: ah, sorry, haven't read the whole thing
17:36 Lyude: but it'd still be nice to have CRC tests for doing BAT-like runs (and for people who might just want to do basic sanity checks for regressions on their own machines with igt)
17:36 Lyude: emersion: also yeah I forgot I helped you with reviewing all of those lol
17:36 emersion: :P
17:38 emersion: hm, how is CRC related to audio?
17:39 Lyude: emersion: nvidia hardware provides the ability to specify which part of the scanout raster you want to generate CRCs from, including the non-active portions (which I -believe- contain audio for HDMI? I might completely be misremembering though)
17:39 emersion: ah. yeah i think audio is just stuffed after the frame data
17:39 emersion: interesting
17:40 emersion: i wonder if it'll work though -- that may be used for other things too, like completely unrelated infoframes
17:41 emersion: maybe it's just garbage when there's no audio playing
17:41 emersion: so, not sure a CRC on that would help, but worth trying stuff out
17:42 Lyude: yeah, I definitely have to dig into it a bit more
17:43 Lyude: but, that'll probably happen after I've at least got basic atomic working on both pascal and earlier + turing
17:43 Lyude: erm, s/turing/volta+
20:00 tertl3: good afternoon fam
20:00 tertl3: may I inquire regarding NetBSD and a 9500 with 6GB
20:16 imirkin: inquire away
20:23 imirkin: (except there were no GT 9500's with 6GB of vram. 512MB would be more like it)
20:26 RSpliet: do we even have *BSD devs here?
20:26 kherbst: dunno, but last time I had to do with *BSD they had drm based on 3.x
20:27 imirkin: riastradh used to be here for a time when trying to get netbsd up and running. but i don't think he's been around much lately
20:27 imirkin: yeah, it was a 3.15 or so port at the time (years ago)
20:27 imirkin: perhaps it's been updated since