06:00 sima: daniels, was wondering where that patchset was, then realized it's from last year
06:51 operatortrash: delta encoding is in the group of iterative algorithms, which is not as fun as what i provided , in other words in increased order filtering the one that i gave, the only other step is to add indexes for anything other than the selection, hence the selection queue jumps -- that is for data
06:52 operatortrash: and for instruction execution in the 528 format, there is no queue jumping needed, cause everything is combinatory, due to incoming operands and indexes and offsets.
06:54 dwfreed: .
08:36 sima: daniels, mvlad dropped a pile of comments mostly around lifetime fun and locking
08:36 mvlad: sima, yeah saw that, thanks!
08:37 sima: I think aside from the 2 big questions on the first patch it's just polish
08:37 sima: well and last patch needs to be redone because backpointers are no-go, but we can also do that later on
09:38 austriancoder: eric_engestrom: which image-tags.yml tags must I update if I touch arm64_build.sh?
10:31 austriancoder: karolherbst: any idea what could be wrong? https://gitlab.freedesktop.org/mesa/mesa/-/issues/11090
10:33 karolherbst: austriancoder: maybe a meson 1.4.0 regression?
10:36 karolherbst: austriancoder: or maybe some clang devel files missing?
10:37 karolherbst: the invocation works as is on my system
10:37 karolherbst: but maybe it's the "-isystem/usr/lib/llvm-16/include" part doing weird things
10:40 karolherbst: austriancoder: yeah.. maybe remove the isystem part and see if that works?
10:42 austriancoder: karolherbst: same with meson 1.3.1
10:52 austriancoder: karolherbst: llvm version should not matter - or?
10:53 karolherbst: it shouldn't, but like.. llvm is weird
10:53 karolherbst: so the thing is, meson tries to detect if it should add a isystem flag or not
10:53 karolherbst: and the llvm thing is just making it all terribly hard
10:53 karolherbst: so I'd check if removing the isystem flag and maybe turning it into a -I makes it work?
10:55 daniels: sima: heh right, so pretty big rework then. all makes sense tho
10:55 daniels: thanks a lot for going through it!
11:48 austriancoder: karolherbst: seems not to work
11:50 austriancoder:updates llvm to 17
11:53 karolherbst: mhhhh
11:53 karolherbst: maybe something is missing from the clang install then?
11:53 karolherbst: make sure whatever clang bindgen is using does have its headers installed and stuff
11:57 kisak: smells like bindgen needs to be rebuilt against llvm 17
12:00 kisak: nevermind, I don't know what's going on there.
12:02 austriancoder: DavidHeidelberg: which image-tags.yml tags must I update if I touch arm64_build.sh?
12:16 austriancoder: karolherbst: bah.. so it works with -isystem and when I add these two: -I/usr/include/c++/13 -I/usr/include/aarch64-linux-gnu/c++/13
12:17 austriancoder: karolherbst: looks there was a similar issue: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9383#note_2292318
12:28 karolherbst: austriancoder: yeah... I'm kinda curious on what's going on there as clang should just add those paths itself
12:28 karolherbst: but maybe it doesn't?
12:42 DavidHeidelberg: austriancoder: Heya, you'll need the "DEBIAN_BASE" tag
13:01 austriancoder: DavidHeidelberg: great.. so this commit should be good, but gitlab does not like it: https://gitlab.freedesktop.org/austriancoder/mesa/-/commit/ec230571c2d7a1a26682628305ded46e8a16d5ff
13:03 austriancoder: karolherbst: need to check where meson interacts with clang ..
13:31 colinmarc: looks like https://salsa.debian.org/xorg-team/lib/mesa/-/blob/debian-unstable/debian/rules is it?
13:33 daniels: austriancoder: it actually needs to be DEBIAN_BUILD_TAG
13:33 daniels: err, sorry, DEBIAN_BASE_TAG
13:33 daniels: but yours only sets DEBIAN_BUILD_TAG
13:58 MrCooper: hmm, looks like https://gitlab.freedesktop.org/drm/amd/-/issues/2186 & https://gitlab.freedesktop.org/drm/amd/-/issues/3171 were accidentally closed triggered by commits in a different project, similarly to what was reported for an intel DRM project before
15:36 austriancoder: daniels: thx
15:37 austriancoder: karolherbst: https://gitlab.freedesktop.org/austriancoder/mesa/-/jobs/58206947 it looks like you might have a real fix: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10830#note_2328718
15:57 austriancoder:not my day :/
15:58 austriancoder: https://www.irccloud.com/pastebin/GXE3LTPT/
15:58 austriancoder: karolherbst: ^ I promise.. the last time I ping you today
16:23 karolherbst: austriancoder: what is this cursed target triple?
16:24 karolherbst: austriancoder: yeah, please review my fix for that vl mess :D
16:24 karolherbst: austriancoder: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26680
16:26 karolherbst: but back to the triple, I don't see how that's even possible
16:26 karolherbst: or uhm.. mhhh
16:27 karolherbst: mhhhhhhh
16:27 karolherbst: does "spirv-unknown-unknown" even exist as a triple? not that it's like 64 bit only
16:27 karolherbst: ...
16:27 karolherbst: austriancoder: mind "fixing" clc_compile_to_llvm_module so that it always uses spir for 32 bit and not spirv?
16:28 karolherbst: I've added the spirv one as prep work for using the llvm spirv backend
18:07 derr: karolherbst: you alive ?
18:08 derr: you said something yesterday about there was a bug in the nv50 chipset for the mesa librarys ? performance loss after upgrading from version 21.x \ 22.x or such ?
18:09 karolherbst: yeah.. have you tried compiling mesa yet to verify that?
18:09 derr: i been compiling myself greeen since yesterday
18:09 derr: have version 22.2.5 compiled and tried out already
18:09 derr: going down to 22.2.4 now
18:09 derr: but
18:09 karolherbst: don't bother with minor steps
18:09 derr: having little faith in it
18:10 derr: minor steps like ?
18:10 karolherbst: did glxinfo ran from the meson devenv env show the right version?
18:10 derr:look at soreau ,,, did it boss ? =)
18:10 derr: soreau been helping,,,,, been doing all the work..
18:11 karolherbst: kinda need to verify it properly works, because I'd _assume_ that up to 23.0 the performance should be fine
18:11 derr: fine performance is a relative term im thinking,, my fps was,, near 99 most of the time before update if that is what u mean
18:12 soreau: derr: you tried 22.2.4, now building 22.2.5
18:12 derr: i think glxinfo ran from the meson devenv
18:12 derr: oh,, other way around ? =) ok
18:12 karolherbst: derr: right.. but when you play the game with your own built mesa, was the performance any better?
18:12 karolherbst: or rather
18:12 karolherbst: was it like before
18:13 derr: was like before ,, mostly, got stomped a bit tring to downsize resolution but ,, was not near like before
18:13 derr: might have been some increase in performance,, think it was up to 50 60 fps
18:13 karolherbst: mhhh..
18:13 karolherbst: is that a debug or a release build?
18:13 derr: might have been the map, only tried 5 min
18:14 derr: of cs ? steams release build i assume ?
18:14 karolherbst: mesa I mean
18:14 derr: ah
18:14 derr: i dunnno
18:14 derr: we git cloned it from somewhere
18:15 derr: scrolling up to see =)
18:15 derr: just see 'git checkout mesa-22.2.4'
18:15 derr: we set server or,, where to fetch from ealier *scroll more*
18:15 derr: git clone https://gitlab.freedesktop.org/mesa/mesa
18:15 derr: from there
18:15 karolherbst: it's part of the meson setup. Could check with `meson configure` from inside the build directory what's the value of "buildtype"
18:16 derr: i should try ?
18:16 karolherbst: it's like the third option or something
18:16 karolherbst: if it's set to debug or so, you should run `meson configure -Dbuildtype=release` and rebuild
18:17 derr: soreau: im allowed to try ? :) soreau sorta boss on my pc now
18:17 soreau: oh yea, that might help (:
18:17 karolherbst: heh
18:17 derr: bossman says ok
18:17 derr: ok
18:17 soreau: derr: yea, you want release
18:17 soreau: will be faster overall
18:17 karolherbst: helpful for comparing performance :)
18:17 soreau: optimizations etc
18:17 derr: its doing,, something,, i think,, or did
18:17 derr: lots of colors even
18:17 derr: i think its done
18:18 derr: a colon appeared
18:18 derr: q ?
18:18 karolherbst: yeah
18:18 derr: alright
18:18 karolherbst: but like, does it say "buildtype debug"?
18:18 derr: buildtype debugoptimized [plain, debug, Build type to use
18:18 karolherbst: ahh
18:18 karolherbst: mhhh
18:19 karolherbst: that still gives you assert which _could_ slow things down
18:19 karolherbst: but shouldn't all that much
18:19 derr: its not just 1 thing that counts huh
18:20 karolherbst: yeah.. there is b_ndebug as well which normally should be if-release, which means, asserts are disabled when setting buildtype to release
18:20 karolherbst: but anyway...
18:20 karolherbst: debugoptimized isn't bad per se
18:20 karolherbst: I think you just want to get some more reliable data first
18:20 derr: data like ?
18:20 karolherbst: like.. how fast is it now (system installed mesa) and how fast was it before
18:20 karolherbst: like.. running the game in a proper benchmark mode
18:21 derr: me saying i FEEL game was faster before dont count for good measure huh,, fair enough
18:21 karolherbst: yeah...
18:21 derr: hard to measure before tough,,
18:21 derr: now everytime i install steam, steam forces me to upgrade at once mesa
18:22 derr: could in theory , install gsclient (another cs client) but,, might not be,, quite same either,,, should be same mesa library tough if that is all that counts
18:23 derr: reinstall ubuntu, install glsclient , no steam, and try make some numbers
18:23 derr: glxinfo gives numbers ? i can get numberes to feed to someone to make it usefull ?
18:24 derr: i can screenshoot fps ...
18:24 derr: printscreen..
18:38 soreau: karolherbst: derr says it works with 22.2.5 but not 22.2.4 nor master
18:38 karolherbst: huh? I don't see why 22.2.4 would be any worse than 22.2.5
18:39 soreau: idk, maybe it was still using the system driver for some reason
18:40 soreau: and this just in: seems to be vblank_mode
18:40 karolherbst: ahh
18:41 karolherbst: Mind trying 22.3 then? I think that's the first version which should show less performance then? Or at least that would be my guess
18:41 derr: what the !"#¤% is vblank_mode ,, seems to make 50fps diff
18:41 derr: im up to 100 fps now
18:41 derr: never had no 100 fps
18:41 derr: im very happy
18:41 derr: but yea
18:41 derr: so yea ill try 22.3 if that makes you happy
18:41 soreau: derr: can you try without meson devenv, just `vblank_mode=0 steam`?
18:42 derr: soreau gets beer and pizza..
18:42 karolherbst: if you have some time, trying 22.3 and then this MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28641 would be helpful
18:42 karolherbst: if that MR gets you close to 100 then that would fix the performance regression
18:42 derr: in same dir i launch the other stuff from ? mesa dor ?
18:42 karolherbst: in future releases I mean
18:42 derr: meas dir*
18:43 derr: future fix would be very good
18:43 derr: steam dont do much of that
18:43 derr: it seems
18:43 derr: soreau: 'vblank_mode=0 steam' in any terminal anywhere ?
18:43 derr: ill try
18:44 derr: i need the.. ''s ? ..
18:44 derr: and, i already have steam up
18:45 derr: i closed it, trying
18:45 soreau: derr: If it works this way, and steam doesn't clobber your env var, yea, close steam and then run that command and see if launching the game 'normally', 'works'
18:46 derr: steam did open
18:46 derr: lots of errout
18:46 derr: or,, messages at least
18:46 derr: ill try open cs
18:46 derr: haah
18:46 derr: stupid steam
18:46 derr: im on 100 fps
18:46 derr: 99\100
18:46 derr: fluxing a bit
18:47 derr: i move steam original binary and replace it with #!/bin/bash ; vblank_mode=0 steam ?
18:47 derr: +path to original...
18:47 derr: or such ?
18:48 soreau: derr: you can do whatever you want, it's FOSS ;)
18:58 derr: karo, u still want me to try 23 version ? its any point still ?
19:06 soreau: I think you already have
19:06 soreau: because that's what is in steam>help>info
19:08 derr: oh yea , it is
19:08 derr: Driver Version: 3.3 (Compatibility Profile) Mesa 23.2.1-1ubuntu3.1
19:08 derr: 23 can go jump in sea
19:10 karolherbst: I think it would just be worth trying out that MR, but I'm kinda busy giving detailed instructions how to git fetch an MR and stuff atm
19:10 karolherbst: or today
19:13 derr: im a bum with no real job, i might come around another day.. no promises