07:40 MrCooper: sima: maybe it's something else, clearly there is some bug somewhere which prevents the throttling from working as intended though
07:42 tzimmermann: MrCooper, i think the calculation in the timer's get_vblank_timestamp is incorrect
07:43 tzimmermann: AFAIU it's supposed to return the timestamp of the first visible scanline after the most recent vblank irq.
07:44 tzimmermann: and the vblank timer's implementation always returns the timestamp of the last vblank timeout
07:44 tzimmermann: i'm still investigating, but that looks like a lead
07:45 MrCooper: another thing I notice is that drm_crtc_vblank_start_timer uses a relative timer with fixed interval, which presumably doesn't result in firing at regular intervals when the timer keeps getting enabled and disabled again?
07:47 MrCooper: might be better to use an absolute timer and keep extrapolating the target time when it fires
07:47 tzimmermann: that's also worth investigating
07:49 tzimmermann: IIRC the original implementation was for testing with vkms. likely these problems never materialized unless someone looks at a real display output
07:56 MrCooper: tzimmermann: I assume you're aware of this, just in case though: the timestamp can be in the future, if scanout is currently in a vertical blank region
07:56 tzimmermann: MrCooper, yes. with vblank timer, that timestamp is apparently never in the future
10:36 lucaceresoli: mripard: what's the plan with "[PATCH v4 0/2] drm: Rename drm_atomic_state"?
10:37 lucaceresoli: mripard: as it touches lots of files, shouldn't it be applied soon?